From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8A7D0BB79 for ; Thu, 24 Oct 2024 09:08:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 718696B0085; Thu, 24 Oct 2024 05:08:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C8746B0088; Thu, 24 Oct 2024 05:08:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568B86B0089; Thu, 24 Oct 2024 05:08:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3971F6B0085 for ; Thu, 24 Oct 2024 05:08:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C0E216118A for ; Thu, 24 Oct 2024 09:08:22 +0000 (UTC) X-FDA: 82707920106.16.C7A7DED Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id A3E74140017 for ; Thu, 24 Oct 2024 09:08:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mkuu2YeN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bE/zrgR4"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mkuu2YeN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bE/zrgR4"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729760868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MbgmDp1U0gRrqSHvz8PN05JPJEeL6GyP2lAdORSK+fc=; b=uNdMpgCtb3uudKzlWSUL1Af6x/bc/N8FC+z1NFHBzpdcoM7vna3ZWGGGpiYrQamg05BHD4 9M9UHeZaiaymvjCf6GPBVol/bJ09bk+zzRg4GwPbgCS5oR1nybV6GjgvwD8FgjhV0R1JBf 6xYyXs+IWXwSAOSA6BrxMmcI/qcQD6w= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mkuu2YeN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bE/zrgR4"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mkuu2YeN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bE/zrgR4"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729760868; a=rsa-sha256; cv=none; b=E1YXxdt4jwndsVkrcSOikEy2MHlMwCEiavvqvy4W9atHirHEJgfzU2C4SUNdlwzJlT/dlB sNKqY8P4cC+Sc2nrdUd/9SYNWfOODZl+mpUylrQq61CROv5FW6z21sLnNgF2EQ7MFFVGWb 2FFUwU/pCme4OvtOETanhcUyR0bErK8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6AF741FEF0; Thu, 24 Oct 2024 09:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729760918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MbgmDp1U0gRrqSHvz8PN05JPJEeL6GyP2lAdORSK+fc=; b=Mkuu2YeN42cv2bqkbfjpF6cBZkn9okipK8oszuQO6tONyyn/3uh63g5hwTB8gLU5mOsEEa RqAz5F8xAyGfMEcPWSeEcj5rBTHVoukzW4tWIRy4B+zYQ8JjVKg236568Ru9YPiY6+8xdV LQ3pFHuDUO3hEcjPgGSizt/zjn7mfME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729760918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MbgmDp1U0gRrqSHvz8PN05JPJEeL6GyP2lAdORSK+fc=; b=bE/zrgR4viAIw3CqcyKCS7Sxcre+Fl3EfXZa2AVwWTAuga2ragKH7NUykNoeOm4OopGmoP IVESQ11tfYoCuVAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729760918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MbgmDp1U0gRrqSHvz8PN05JPJEeL6GyP2lAdORSK+fc=; b=Mkuu2YeN42cv2bqkbfjpF6cBZkn9okipK8oszuQO6tONyyn/3uh63g5hwTB8gLU5mOsEEa RqAz5F8xAyGfMEcPWSeEcj5rBTHVoukzW4tWIRy4B+zYQ8JjVKg236568Ru9YPiY6+8xdV LQ3pFHuDUO3hEcjPgGSizt/zjn7mfME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729760918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MbgmDp1U0gRrqSHvz8PN05JPJEeL6GyP2lAdORSK+fc=; b=bE/zrgR4viAIw3CqcyKCS7Sxcre+Fl3EfXZa2AVwWTAuga2ragKH7NUykNoeOm4OopGmoP IVESQ11tfYoCuVAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4D9331368E; Thu, 24 Oct 2024 09:08:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HwD/EZYOGme5QwAAD6G6ig (envelope-from ); Thu, 24 Oct 2024 09:08:38 +0000 Message-ID: <1625e2e0-06ad-459c-b941-41fadea2008d@suse.cz> Date: Thu, 24 Oct 2024 11:08:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shrinker: avoid memleak in alloc_shrinker_info Content-Language: en-US To: Chen Ridong , Roman Gushchin , akpm@linux-foundation.org, david@fromorbit.com Cc: Muchun Song , Anshuman Khandual , "Kirill A. Shutemov" , zhengqi.arch@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangweiyang2@huawei.com References: <1BD74B20-879A-4159-B957-1223553217C1@linux.dev> <0b883f9e-451f-41c2-805f-7f5bc7eebee2@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 4nnuw5qjd8dcxp98dtjqjymhk544ikkc X-Rspamd-Queue-Id: A3E74140017 X-Rspamd-Server: rspam11 X-HE-Tag: 1729760906-681844 X-HE-Meta: U2FsdGVkX185EQkKzufbucRprJWBEDoZYEO0B8CDOGwqj/ZhKsn+nH/J9vLUYb+KJSmj5MwnwxDdhracA0mVEQxmtqANmkK+i5BkHfvF1UzzsIxFD04Sj+G6Kqj+vAayCqfl5ClTLI/92cKh6qCDQKhswt3KkPjb4uZUBMqepiCU3wv8osmQOZsPgjlZFTerlME9sARWyE8CY575oTynBVhxwYZIMkBmTbymflFC2tPNwRV3fVeLiluKpMRSdOAZAplmyG4jU4cR55VOKyi3X/cwNOVm2Oa5zabXpXkNYXrwsg0muzKlsuyV8wsQx7tJmF9lJ4CuLjo4/osWKFK5aDIH+gFiI0JLKUPwkqPJUyoxK0HPy4j2VCjZB6p7mNYbjXj55xDhk/Wb6mvdigUSGs2irsvBtv0nSFCSUs+n7UQ7rAhagrKvVG5nAwdQbrAI5RyM4/NOv2QJoR9WZOXoOXvftZogiCP5SNahfCq/RMUcNs/d10fx8FQD38Qeajg4381wWjTkfVP7zSaaUmRZuSzkTvUQBoSEdkbGcFZHhglwCcygM291xitCo9dK/i37znr4VHKM9K9rFbM+Db+XbY7SPiW0qMfLter0HjoiD9hwSAQxF8HG3v+DucfsdYQVxzBSJgqi7eJTDagh4/VZo6tgPF86FJEmclXtoc9hWZTQbwfbgva/QST9SyjKq+RD5ugujjtqQPjjuAB85+DePXbCXgycuo4Rvln40ZQ5/1VxGMk138uBJVCn4jUaj4CaPsOetDrIb4EFK63DjNJbfPDMHDpPSfUzlP9eh8jHr3MFRwEY+QgV+F+P8rEow2hGrMTMu29jSdX6DuzzVPPXjY3mrEd3J503WsfNio8nmn7xEk1Cr4evrgi4c6Us4QZln9CehbewhH3uun6TeoA9XizIxH5mKcanSIyReJQ/Pwcirg0yEqJ7BpYtYqu8oI9vXqLVBRoobMBQa/PnCcM 7KviMSh6 cbJeTMmNvPddWnuKz5NVrgg9tLHufCKh43wr05mvBX90Eecl6DMGzA7CiT8rzQx2FWmLwxb4VFEqGvHZJrcex7rM9u3pxfi2LhiJ/+d/vcC1nGX3NgMUw8yVrfmGz8tRx/wm57pzY8VuI1NaB9FMr+H9w40wNoIZD4lVzgEItGg93wftd9o+WRRwyqDf5j0RcKAH8C6FJxplmTdtbyjcANHY+JDwk4s18BGfg7c7D/GasJVOqRJDpo9yvabusqzJh7Pn7ukFbI6LgoUfm1YqY6666LZfFjpo2IgPAo6NGkK/kkn7xFvDmHZAr5yeOy83qwmrNg42WHh7TI1kDJVVfo2X+ybraqBiY8twEWwYg1EcakC0TbB4vAPmou2K+dHYrGVt3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/24/24 03:26, Chen Ridong wrote: >>>> For example, if we use his v1 proposal, we should do >>>> the cleanups again for info. But for goto-based >>>> version, we just add another label to do the >>>> cleanups and go to the new label for failure case. goto-based fix is what I insisted on. I copied my previous suggested fix here to clarify my opinion. >>> >>> Again, info is a loop-iteration-local variable, v1 fix making it truly local >>> is the way to go. If there are further cleanups added in the loop itself in >>> the future, they could hopefully keep being local to the loop as well. >>> Cleanup of info outside the loop iteration is breaking its real scope. >> >> +1 to that. >> >> I don't think it's such a big deal and both versions are ok, but I strongly >> prefer the original version (without introduction of a new label). >> >> Please, feel free to use >> Acked-by: Roman Gushchin >> with the original version. >> >> Thanks! > > I agree with Roman. > Hello, Andrew and Dave, Do you have any opinions? > > The original version: > https://lore.kernel.org/linux-kernel/4184c61f-80f7-4adc-8929-c29f959cb8df@huawei.com/ Hi, Can you resend the v1 as v3, but also move the declaration of "struct shrinker_info *info;" inside the for_each_node() block? Also you can add all the acks collected for that version and mine too: Acked-by: Vlastimil Babka Thanks. > Best regards, > Ridong > >