From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C66C07E96 for ; Thu, 8 Jul 2021 23:23:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D737613C8 for ; Thu, 8 Jul 2021 23:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D737613C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A32EE6B0011; Thu, 8 Jul 2021 19:23:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E2076B0070; Thu, 8 Jul 2021 19:23:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883596B0071; Thu, 8 Jul 2021 19:23:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 4CAD16B0011 for ; Thu, 8 Jul 2021 19:23:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 83E6C1848B for ; Thu, 8 Jul 2021 23:23:17 +0000 (UTC) X-FDA: 78340998834.03.B4170DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id ECD6A600208E for ; Thu, 8 Jul 2021 23:23:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6E94B21EF1; Thu, 8 Jul 2021 23:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625786595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dxM1c9BhJWVt1uyGK7GAta4cNMJsWsrxFKFXFaQyZMw=; b=GKoj8FVZ45+gI1yMOaoY7chroA1Ekjx1I95wGrjnB07SZ2Y2R8lBDnE+H69TKj8cB8NWQZ kTpG64Xq3Gbb+kMQkSHfJPpZc8mIDtheWF3ShaDs5Q6CxD/mLCJj6+rg9yhcmXDiz7EEfj iTrow6laRP53AMrTiW/7cKa/JrBPtfY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625786595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dxM1c9BhJWVt1uyGK7GAta4cNMJsWsrxFKFXFaQyZMw=; b=JBSliye15uCnPBkGqaPirLsOQ0zeqRO8QeWoklO82aUpjZ18QFljdzeWF8IrDaAF5guTOf 4ZnBNknPNOdF5hAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2128513B21; Thu, 8 Jul 2021 23:23:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MN01MeGI52CudQAAMHmgww (envelope-from ); Thu, 08 Jul 2021 23:23:13 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Chuck Lever" Cc: linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/3] Bulk-release pages during NFSD read splice In-reply-to: <162575623717.2532.8517369487503961860.stgit@klimt.1015granger.net> References: <162575623717.2532.8517369487503961860.stgit@klimt.1015granger.net> Date: Fri, 09 Jul 2021 09:23:10 +1000 Message-id: <162578659050.31036.16278478540386858207@noble.neil.brown.name> Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GKoj8FVZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JBSliye1; dmarc=none; spf=pass (imf10.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ECD6A600208E X-Stat-Signature: ishdiae3dgnrjraz1xdf4ga5hprydbfs X-HE-Tag: 1625786596-97925 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 09 Jul 2021, Chuck Lever wrote: > > In this version of the series, each nfsd thread never accrues more > than 16 pages. We can easily make that larger or smaller, but 16 > already reduces the rate of put_pages() calls to a minute fraction > of what it was, and does not consume much additional space in struct > svc_rqst. > > Comments welcome! Very nice. Does "1/16" really count as "minute"? Or did I miss something and it is actually a smaller fraction? Either way: excellent work. Reviewed-by: NeilBrown NeilBrown > > --- > > Chuck Lever (3): > NFSD: Clean up splice actor > SUNRPC: Add svc_rqst_replace_page() API > NFSD: Batch release pages during splice read > > > fs/nfsd/vfs.c | 20 +++++--------------- > include/linux/sunrpc/svc.h | 5 +++++ > net/sunrpc/svc.c | 29 +++++++++++++++++++++++++++++ > 3 files changed, 39 insertions(+), 15 deletions(-) > > -- > Chuck Lever > >