From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF9EC64E7B for ; Fri, 27 Nov 2020 12:04:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F277822228 for ; Fri, 27 Nov 2020 12:04:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F277822228 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 537806B0068; Fri, 27 Nov 2020 07:04:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E6EF6B006C; Fri, 27 Nov 2020 07:04:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 425346B006E; Fri, 27 Nov 2020 07:04:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 2D72E6B0068 for ; Fri, 27 Nov 2020 07:04:42 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D4D333638 for ; Fri, 27 Nov 2020 12:04:41 +0000 (UTC) X-FDA: 77530066362.04.sleep75_2d1807d27387 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id B99F28013B8F for ; Fri, 27 Nov 2020 12:04:41 +0000 (UTC) X-HE-Tag: sleep75_2d1807d27387 X-Filterd-Recvd-Size: 2730 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Nov 2020 12:04:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D8BFADCA; Fri, 27 Nov 2020 12:04:40 +0000 (UTC) Subject: Re: [PATCH 13/44] block: use disk_part_iter_exit in disk_part_iter_next To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-14-hch@lst.de> From: Hannes Reinecke Message-ID: <1624f174-4182-744c-56ad-b50a391a6bb7@suse.de> Date: Fri, 27 Nov 2020 13:04:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201126130422.92945-14-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/26/20 2:03 PM, Christoph Hellwig wrote: > Call disk_part_iter_exit in disk_part_iter_next instead of duplicating > the functionality. >=20 > Signed-off-by: Christoph Hellwig > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jan Kara > Reviewed-by: Johannes Thumshirn > Acked-by: Tejun Heo > --- > block/genhd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/block/genhd.c b/block/genhd.c > index 4e039524f92b8f..0bd9c41dd4cb69 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -227,8 +227,7 @@ struct hd_struct *disk_part_iter_next(struct disk_p= art_iter *piter) > int inc, end; > =20 > /* put the last partition */ > - disk_put_part(piter->part); > - piter->part =3D NULL; > + disk_part_iter_exit(piter); > =20 > /* get part_tbl */ > rcu_read_lock(); >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg HRB 36809 (AG N=C3=BCrnberg), Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6= rffer