From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A446C47082 for ; Sat, 5 Jun 2021 05:45:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7B9661408 for ; Sat, 5 Jun 2021 05:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7B9661408 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B62C6B006E; Sat, 5 Jun 2021 01:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 666CE6B0070; Sat, 5 Jun 2021 01:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E2056B0071; Sat, 5 Jun 2021 01:45:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 190896B006E for ; Sat, 5 Jun 2021 01:45:00 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AC33C181AEF1A for ; Sat, 5 Jun 2021 05:44:59 +0000 (UTC) X-FDA: 78218581518.10.98CBEC0 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 44C344202A32 for ; Sat, 5 Jun 2021 05:44:59 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id u9so5654872plr.1 for ; Fri, 04 Jun 2021 22:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=JOIBq+kEIRNe1HY/dU/O4ueknvMC0Jdakk1cdBJSPGw=; b=bmjRiedlJqGYPmfoB1i8FSdNGJRe69WfRRrbZKLnzmCjCN6oYAc7C+cA6rGIaualIa l4qfmOQJIsm7mhy2xoCiiJH+FQPWEeFsp+EXdX5NbUH6NsMQaY+MlseKfd3Hvx4uOVGn UXRafGp2Fj88+KWaP6+yFK6VGS1/vyvOtdyFE0a+tsXogRE4WZXsTm1ULstUvITaipP4 epBUGZ2XXQp+BJ0jYpiTueNcZ4TaFVTYz7io/EVMlyKqefZueRmwrZW5ZOgK9kQvVamJ /MZu3JkZo3Q7ZQFVUbpZ+xH0misk9s54/+KbVu0/tQItvT6W0oLt0ZQJdJOPg0+V+cNY fYFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=JOIBq+kEIRNe1HY/dU/O4ueknvMC0Jdakk1cdBJSPGw=; b=goh8HJ2gNXmxlUeCgscjDtBcMVObwC9dZRqmd6YP2qa7iudapGBH9LYW5V0XPCDQqq itNTXMatMFMiVl+IevvVmSgnWR4ENDeOzIwLTFcd8gcN1LcADyZtvxXIkWp/Vikcn5c2 9pj2U02W598m3pD2wYQdY4JvIksYw+1gHRW9eOWnTxBCt0BTeY0jmFQXDb6xcYjlLZfZ 4WR97BYK8EC/sMfG2Hgw90L+N19IUbwRVqXNYd6BIf1PAHfnOZ/8miL3RkaqpozzzoTe hM5uKYdrXZhevvOYPFcGr7PDgGkgbVHBTW9jK3nkuwjUllyCWgAoCX8YWaesvZQubTMh bJ+w== X-Gm-Message-State: AOAM533jxxgTV4hcPt5sFPq8tUXgMr4fhZGQMujiGxg7+glvk1u/7hbX 4hoQVWQzrrjKtxsJqkT1RHJviMdHfwU= X-Google-Smtp-Source: ABdhPJxvqDGzb9ptMsdZWbbSUmPkKDSnpbG8bYthCJXvTG4JTcEDkvH65Y6fagb+39d85vOfUJU5mA== X-Received: by 2002:a62:7b4c:0:b029:2e9:cec2:e252 with SMTP id w73-20020a627b4c0000b02902e9cec2e252mr7446083pfc.56.1622861549693; Fri, 04 Jun 2021 19:52:29 -0700 (PDT) Received: from localhost (60-242-147-73.tpgi.com.au. [60.242.147.73]) by smtp.gmail.com with ESMTPSA id iq15sm3337816pjb.53.2021.06.04.19.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 19:52:29 -0700 (PDT) Date: Sat, 05 Jun 2021 12:52:23 +1000 From: Nicholas Piggin Subject: Re: [PATCH v3 0/4] shoot lazy tlbs To: Andrew Morton , Andy Lutomirski Cc: Anton Blanchard , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Randy Dunlap References: <20210601062303.3932513-1-npiggin@gmail.com> <603ffd67-3638-4c47-8067-c1bdfdf65f1b@kernel.org> <991660c3-c2bf-c303-a55c-7454f0cc45f7@kernel.org> <1622851909.wxi3vcx3m8.astroid@bobo.none> <1622852601.xyhcpcfd7y.astroid@bobo.none> In-Reply-To: <1622852601.xyhcpcfd7y.astroid@bobo.none> MIME-Version: 1.0 Message-Id: <1622861133.mb1njgfop9.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bmjRiedl; spf=pass (imf02.hostedemail.com: domain of npiggin@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 44C344202A32 X-Stat-Signature: ht46jtke5f3f7jfx4iisk4cfmx9n5map X-HE-Tag: 1622871899-845445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Nicholas Piggin's message of June 5, 2021 10:26 am: > Excerpts from Nicholas Piggin's message of June 5, 2021 10:17 am: >> Excerpts from Andy Lutomirski's message of June 5, 2021 3:05 am: >>> On 6/4/21 9:54 AM, Andy Lutomirski wrote: >>>> On 5/31/21 11:22 PM, Nicholas Piggin wrote: >>>>> There haven't been objections to the series since last posting, this >>>>> is just a rebase and tidies up a few comments minor patch rearranging= . >>>>> >>>>=20 >>>> I continue to object to having too many modes. I like my more generic >>>> improvements better. Let me try to find some time to email again. >>>>=20 >>>=20 >>> Specifically, this: >>>=20 >>> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?= h=3Dx86/mm >>=20 >> That's worse than what powerpc does with the shoot lazies code so=20 >> we wouldn't use it anyway. >>=20 >> The fact is mm-cpumask and lazy mm is very architecture specific, so I=20 >> don't really see that another "mode" is such a problem, it's for the=20 >> most part "this is what powerpc does" -> "this is what powerpc does". >> The only mode in the context switch is just "take a ref on the lazy mm" >> or "don't take a ref". Surely that's not too onerous to add!? >>=20 >> Actually the bigger part of it is actually the no-lazy mmu mode which >> is not yet used, I thought it was a neat little demonstrator of how code >> works with/without lazy but I will get rid of that for submission. >=20 > I admit that does add a bit more churn than necessary maybe that was > the main objection. >=20 > Here is the entire kernel/sched/core.c change after that is removed. > Pretty simple now. I'll resubmit. If it gives you some concerns about a great complex new mode, I'll put it a different way -- all this allows is the arch to say that it does not use lazy tlb mms beyond their refcounted lifetime, so there is no need to refcount the lazy tlb reference. That's all it is. One implementation of that is shoot lazies, and that could be done entirely in arch/powerpc via destroy_context (I just put=20 it in mm/ in case it is useful to others, but that's no real=20 difference). So you see it's really just about management of lazies, the refcounting is just a bit on the side. And lazy management is highly arch specific, x86 being one of the really different complex ones there including very complex and unique interactions with membarrier ordering, so that can't be a fair objection. Thanks, Nick