From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766A0C47082 for ; Sat, 5 Jun 2021 05:04:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 140656121F for ; Sat, 5 Jun 2021 05:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 140656121F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A034A6B0036; Sat, 5 Jun 2021 01:04:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A09C6B006C; Sat, 5 Jun 2021 01:04:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F4EC6B006E; Sat, 5 Jun 2021 01:04:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 4AA356B0036 for ; Sat, 5 Jun 2021 01:04:30 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D9A2EA8E6 for ; Sat, 5 Jun 2021 05:04:29 +0000 (UTC) X-FDA: 78218479458.38.20E8746 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf08.hostedemail.com (Postfix) with ESMTP id 415C7801937B for ; Sat, 5 Jun 2021 05:04:29 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id q7so12406355iob.4 for ; Fri, 04 Jun 2021 22:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=/jqiL/qTfJjmBNhopBIMzK+jxUaOluXuMLOEamwPvz4=; b=ooclrGet83DUu230tf4FqjEw2jni37mOcex/cGUcFjMlNdwwCLSISFDiNRYVGZ9NQA B4SgPsfHY6NHGf+Gp66PHRzYG/TuTxaFDmhYJhFKvW/6CFD1XZdBVUoDjbjWjY8FD6oh t9nz3xwRWtomGIQkOo8YDeWKAC17Y1UmYvFzpar/5hOKvXSH6R2IfU0ngKebihdFo86X VAWza+XExghJ6BtC+oyThvexpU6t7NfhWBExIhZJENY8GlAF6gPpaMAgdHMO2s/qUW5V 4TnJfwhemtLgA49w4ebjwlJ4GOhiqZDiQUS6bn4D5Y2ZoQBlU7zppo8mkYcZ1Gpiybv0 dF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=/jqiL/qTfJjmBNhopBIMzK+jxUaOluXuMLOEamwPvz4=; b=J5gY0l+tOiVCy4DK62Ew9/++1np5ff09oa/ZJVN9lRGsn3Iu23LYOQY9GvfDqPmpu+ tQR+ZKJFewoVrCMDa72KfnrVMiaeE4J1KA93BAdrFNuScbzVeuxMPtLc0TUWk4fFGDMa 20PtYUjIlI3CpX+VxxuZ2z9VxytuuV50NyKiUS4xcTfGL//dAEuCPAkcuD2d75/kWD1x jfOyd3942RdSJ4YvOsH62nV+qWKfhuV9DvVUlSmSOVbMEha/qrRs9G0W8wMISXGft1GY QhKJDxx9Nxm17HEJ1KjRrkSn2odYVG6hEwA1a6Pmtd0IRLaQVXdKB+9kxwR7oOQjKfuZ cZSg== X-Gm-Message-State: AOAM532y/0xCOl5Ej6vCbp3V9bI+BSH9oeJmXKAKmFi5u0/JfJ2kNHBI 401X8TTrjOmPzUAurel5mziWPTLpocI= X-Google-Smtp-Source: ABdhPJxX5xGQ+5qD398du3WDmRtK/4PslOYTIhUdOtbETp67cATNtF6hZ89Y4CwdJ6aYpZEVsE0mEw== X-Received: by 2002:a63:8c09:: with SMTP id m9mr1584275pgd.392.1622852276317; Fri, 04 Jun 2021 17:17:56 -0700 (PDT) Received: from localhost (60-242-147-73.tpgi.com.au. [60.242.147.73]) by smtp.gmail.com with ESMTPSA id l126sm2665004pfl.16.2021.06.04.17.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 17:17:56 -0700 (PDT) Date: Sat, 05 Jun 2021 10:17:50 +1000 From: Nicholas Piggin Subject: Re: [PATCH v3 0/4] shoot lazy tlbs To: Andrew Morton , Andy Lutomirski Cc: Anton Blanchard , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Randy Dunlap References: <20210601062303.3932513-1-npiggin@gmail.com> <603ffd67-3638-4c47-8067-c1bdfdf65f1b@kernel.org> <991660c3-c2bf-c303-a55c-7454f0cc45f7@kernel.org> In-Reply-To: <991660c3-c2bf-c303-a55c-7454f0cc45f7@kernel.org> MIME-Version: 1.0 Message-Id: <1622851909.wxi3vcx3m8.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 415C7801937B X-Stat-Signature: pdqp3yzsxd4pmi55nrps7p5p33c9cgku Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ooclrGet; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of npiggin@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=npiggin@gmail.com X-HE-Tag: 1622869469-277018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Andy Lutomirski's message of June 5, 2021 3:05 am: > On 6/4/21 9:54 AM, Andy Lutomirski wrote: >> On 5/31/21 11:22 PM, Nicholas Piggin wrote: >>> There haven't been objections to the series since last posting, this >>> is just a rebase and tidies up a few comments minor patch rearranging. >>> >>=20 >> I continue to object to having too many modes. I like my more generic >> improvements better. Let me try to find some time to email again. >>=20 >=20 > Specifically, this: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h= =3Dx86/mm That's worse than what powerpc does with the shoot lazies code so=20 we wouldn't use it anyway. The fact is mm-cpumask and lazy mm is very architecture specific, so I=20 don't really see that another "mode" is such a problem, it's for the=20 most part "this is what powerpc does" -> "this is what powerpc does". The only mode in the context switch is just "take a ref on the lazy mm" or "don't take a ref". Surely that's not too onerous to add!? Actually the bigger part of it is actually the no-lazy mmu mode which is not yet used, I thought it was a neat little demonstrator of how code works with/without lazy but I will get rid of that for submission. > I, or someone, needs to dust off my membarrier series before any of > these kinds of changes get made. The barrier situation in the scheduler > is too confusing otherwise. >=20 I disagree, I've disentangled the changes from membarrier stuff now,=20 they can be done concurrently. Thanks, Nick