From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50371C47080 for ; Tue, 1 Jun 2021 05:06:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E885F610A1 for ; Tue, 1 Jun 2021 05:06:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E885F610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 57C446B006C; Tue, 1 Jun 2021 01:06:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 506266B006E; Tue, 1 Jun 2021 01:06:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358788D0002; Tue, 1 Jun 2021 01:06:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id F37076B006C for ; Tue, 1 Jun 2021 01:06:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 861F0181AEF07 for ; Tue, 1 Jun 2021 05:06:08 +0000 (UTC) X-FDA: 78203968416.22.EC8ABC9 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 63087C00CBE5 for ; Tue, 1 Jun 2021 05:05:56 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id e1so1966515pld.13 for ; Mon, 31 May 2021 22:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=e5qvMdO65ddgkxTkwMp4LtkG0AF6rMARr7Rc/ENsSLw=; b=QTHXHt0IibbNKOROvNpSmffXtVayeniTeW55uNxmOegMERLcrwGz6TzApqlmMI7c3C ZlgodXB2QrmDhfU0IS0fo8pa2CumG+XjLxlW2rx02Lww4zsIC9f30yoMgBMpT1BPMv+i zNKJ+rK1DgHYFtYwfAF+dz2p4+ZMlR3PIHcG5gUWit8kXbsWuP7nqrENJZTG24lqtY+b 0kyRN2QYZRSCr77MxU/eXCnBHSiActjgAiAlOvPDuuPy8Cel5JlDNrnGpr6+hinnDKGi V7n723oj9g7Ca1BVNszCXrVCEM+wcYThKii3w+fLu6Njy6VWkXjTTZsS6nMR6nhVN/u1 D/mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=e5qvMdO65ddgkxTkwMp4LtkG0AF6rMARr7Rc/ENsSLw=; b=TPkqlRMMe+YQ63b7gFziAL6fgP2XAAcattWIXit7EsGXqOoqYnzRvX7UfK6u179nYw ihEu8DYU2JM8L920DX0pjmLIEvwiLrZZmSU43rP8Px0zi0KBoz1Kni7J038CUt0Dwxl3 b9Jte6DdzKXqOZZLyy0Wbm+nxeg732ZqQ8FkcNZoPFCYLyReeqn4EDf05fliA5mHmhQx Ldr8iCMIX+JmAbI4EOf8e5auCXb3Le1bMc6SyKFXUlyRoBfIW4fuAygfSdlJ5HbanJkZ /Sci50KL9wqPjnt7pkrP/d8fH/eqPrtIQgvYSg+ZDR+dfhqXj62R49QAddDspkgqhZFc jGlw== X-Gm-Message-State: AOAM532IZDOn+2HBxl52kqXs7HYI9nYYnCUsicK7NvjskQEOKSwRIiVR ZEx1sCTWRt2pz5i6vjket+KTqgRkmXc= X-Google-Smtp-Source: ABdhPJza9IsABxYDud0KFNFHVFgnyugSwZhSHMd93Ihc3K57H12jqvwxyLj7U45suQ8hPYlhRRvcFQ== X-Received: by 2002:a17:902:9a45:b029:101:81d0:c5a3 with SMTP id x5-20020a1709029a45b029010181d0c5a3mr17313178plv.52.1622523966949; Mon, 31 May 2021 22:06:06 -0700 (PDT) Received: from localhost (60-241-69-122.static.tpgi.com.au. [60.241.69.122]) by smtp.gmail.com with ESMTPSA id b7sm11758487pfv.149.2021.05.31.22.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 22:06:06 -0700 (PDT) Date: Tue, 01 Jun 2021 15:06:01 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 1/3] mm: add __ prefix to page_cpupid_reset_last because it is non-atomic To: linux-mm@kvack.org Cc: Peter Zijlstra References: <20210317064730.546507-1-npiggin@gmail.com> In-Reply-To: <20210317064730.546507-1-npiggin@gmail.com> MIME-Version: 1.0 Message-Id: <1622523859.o1wybsy51g.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 63087C00CBE5 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=QTHXHt0I; spf=pass (imf22.hostedemail.com: domain of npiggin@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: p93u18uz7wmsh4yaor8b1q5ah7fssmbo X-HE-Tag: 1622523956-350402 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ping? Any concerns about these patches? Thanks, Nick Excerpts from Nicholas Piggin's message of March 17, 2021 4:47 pm: > Add a __ prefix to indicate that it should be used in non-atomic > situations (where the page is not subject to concurrent flags > access, following the pattern of the other page flags modifications). >=20 > This prepares for an atomic version. >=20 > Signed-off-by: Nicholas Piggin > --- > Rebase only. Any comments on this idea? >=20 > Thanks, > Nick >=20 > include/linux/mm.h | 6 +++--- > mm/page_alloc.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 64a71bf20536..086ab710383f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1396,7 +1396,7 @@ static inline int page_cpupid_last(struct page *pag= e) > { > return page->_last_cpupid; > } > -static inline void page_cpupid_reset_last(struct page *page) > +static inline void __page_cpupid_reset_last(struct page *page) > { > page->_last_cpupid =3D -1 & LAST_CPUPID_MASK; > } > @@ -1408,7 +1408,7 @@ static inline int page_cpupid_last(struct page *pag= e) > =20 > extern int page_cpupid_xchg_last(struct page *page, int cpupid); > =20 > -static inline void page_cpupid_reset_last(struct page *page) > +static inline void __page_cpupid_reset_last(struct page *page) > { > page->flags |=3D LAST_CPUPID_MASK << LAST_CPUPID_PGSHIFT; > } > @@ -1449,7 +1449,7 @@ static inline bool cpupid_pid_unset(int cpupid) > return true; > } > =20 > -static inline void page_cpupid_reset_last(struct page *page) > +static inline void __page_cpupid_reset_last(struct page *page) > { > } > =20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index cfc72873961d..172368357e73 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1266,7 +1266,7 @@ static __always_inline bool free_pages_prepare(stru= ct page *page, > if (bad) > return false; > =20 > - page_cpupid_reset_last(page); > + __page_cpupid_reset_last(page); > page->flags &=3D ~PAGE_FLAGS_CHECK_AT_PREP; > reset_page_owner(page, order); > =20 > @@ -1463,7 +1463,7 @@ static void __meminit __init_single_page(struct pag= e *page, unsigned long pfn, > set_page_links(page, zone, nid, pfn); > init_page_count(page); > page_mapcount_reset(page); > - page_cpupid_reset_last(page); > + __page_cpupid_reset_last(page); > page_kasan_tag_reset(page); > =20 > INIT_LIST_HEAD(&page->lru); > --=20 > 2.23.0 >=20 >=20