From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE9FC4707F for ; Thu, 27 May 2021 09:23:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD5F3613E3 for ; Thu, 27 May 2021 09:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD5F3613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AA706B0072; Thu, 27 May 2021 05:23:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 632BA6B0073; Thu, 27 May 2021 05:23:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 486E86B0074; Thu, 27 May 2021 05:23:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 1625C6B0072 for ; Thu, 27 May 2021 05:23:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AB01B824999B for ; Thu, 27 May 2021 09:23:47 +0000 (UTC) X-FDA: 78186473694.28.EEB3B53 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id E9F9CC0042EE for ; Thu, 27 May 2021 09:23:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 04C24613DD; Thu, 27 May 2021 09:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622107426; bh=r7Eml1o1QP4wqIZ6ZV2m4JGCP/6QpFSNYipS5ccY5Ew=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=gzCKlXnwAOxkBxulKoviVY2NFUdUpnRNRqEXojWnfsNcIm2B72cJWEgTe9bm7wvIZ nsHbmB/sXdGqPuxiJZIeHtaqAIeqJx0NS6VHCTyk4pwfY53/7qDhma2uziGE3rEdmq pFyLLrohrvBwjY4a5PjU/fEO1QdxAzxgKH8TqyA4= Subject: Patch "mm, vmstat: drop zone->lock in /proc/pagetypeinfo" has been added to the 4.14-stable tree To: akpm@linux-foundation.org,apw@shadowen.org,aruna.ramakrishna@oracle.com,clameter@sgi.com,gregkh@linuxfoundation.org,khalid.aziz@oracle.com,linux-mm@kvack.org,mel@csn.ul.ie,stephen.s.brennan@oracle.com Cc: From: Date: Thu, 27 May 2021 11:23:44 +0200 In-Reply-To: <20210526174613.339990-1-stephen.s.brennan@oracle.com> Message-ID: <1622107424186201@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 X-stable: commit X-Patchwork-Hint: ignore Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=gzCKlXnw; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E9F9CC0042EE X-Stat-Signature: d7xcx7k77kx8hxjwj5c9uxdi1bitodbw X-HE-Tag: 1622107418-551500 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a note to let you know that I've just added the patch titled mm, vmstat: drop zone->lock in /proc/pagetypeinfo to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=3Dlinux/kernel/git/stable/stable-queue.g= it;a=3Dsummary The filename of the patch is: mm-vmstat-drop-zone-lock-in-proc-pagetypeinfo.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Thu May 27 11:14:38 AM CEST 2021 From: Stephen Brennan Date: Wed, 26 May 2021 10:46:13 -0700 Subject: mm, vmstat: drop zone->lock in /proc/pagetypeinfo To: stable@vger.kernel.org Cc: Stephen Brennan , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, C= hristoph Lameter , Mel Gorman , Andy Whi= tcroft , Aruna Ramakrishna , Khalid Aziz Message-ID: <20210526174613.339990-1-stephen.s.brennan@oracle.com> From: Stephen Brennan Commit 93b3a674485f6a4b8ffff85d1682d5e8b7c51560 upstream Commit 93b3a674485f ("mm,vmstat: reduce zone->lock holding time by /proc/pagetypeinfo") upstream caps the number of iterations over each free_list at 100,000, and also drops the zone->lock in between each migrate type. Capping the iteration count alters the file contents in some cases, which means this approach may not be suitable for stable backports. However, dropping zone->lock in between migrate types (and, as a result, page orders) will not change the /proc/pagetypeinfo file contents. It can significantly reduce the length of time spent with IRQs disabled, which can prevent missed interrupts or soft lockups which we have observed on systems with particularly large memory. Thus, this commit is a modified version of the upstream one which only drops the lock in between migrate types. Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation a= voidance to /proc/pagetypeinfo") Signed-off-by: Stephen Brennan Reviewed-by: Aruna Ramakrishna Reviewed-by: Khalid Aziz Signed-off-by: Greg Kroah-Hartman --- mm/vmstat.c | 3 +++ 1 file changed, 3 insertions(+) --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1313,6 +1313,9 @@ static void pagetypeinfo_showfree_print( list_for_each(curr, &area->free_list[mtype]) freecount++; seq_printf(m, "%6lu ", freecount); + spin_unlock_irq(&zone->lock); + cond_resched(); + spin_lock_irq(&zone->lock); } seq_putc(m, '\n'); } Patches currently in stable-queue which might be from stephen.s.brennan@o= racle.com are queue-4.14/mm-vmstat-drop-zone-lock-in-proc-pagetypeinfo.patch