From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF7DC3DA49 for ; Tue, 23 Jul 2024 10:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03BD76B0088; Tue, 23 Jul 2024 06:18:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D936B008A; Tue, 23 Jul 2024 06:18:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE046B008C; Tue, 23 Jul 2024 06:18:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BEC336B0088 for ; Tue, 23 Jul 2024 06:18:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 48001161DCE for ; Tue, 23 Jul 2024 10:18:04 +0000 (UTC) X-FDA: 82370616888.27.99E35C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 0C27C100018 for ; Tue, 23 Jul 2024 10:18:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dKGt9Xca; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721729858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3j4Y7GKdDQsDIXrm9FcVVcCOdvIkQaL9wqx7KuVIzeY=; b=KuMLuyVRI2OJmQajDVQkcgO/ob+nVevB4b/NJ/LCdCTdczii7dyXTgSMm0l+o6pRUeYoWW kn8amUF2a34gu3dUHqIItoWpLFQvuw/pgjohcFesS1dDkHIU/BGuhDi9cNzcYZJaj5maVf 8VcDXEWb6zqULWQCaHAlyXUMNRyM+TE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dKGt9Xca; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721729858; a=rsa-sha256; cv=none; b=uOS9uCUXjzeGk9I0/nggWFfx4WdMPBlRGP+Y5V38FPmIZQA/pcUCxHy3SEBh6SyqtmCXic dZneUshMiZJ8KCiIyj09CEdrJr6V9Xy6mTkjeh1zK2C2BHi2poZEHr/epVE16IB3fT5TG6 /SIphoNOeCg2QsFeUUf2cHTHvcs8kFo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721729881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3j4Y7GKdDQsDIXrm9FcVVcCOdvIkQaL9wqx7KuVIzeY=; b=dKGt9XcaPbSkJ07MRNauOC7ZYq4yToQ6NKwmRRwcIR0rD5z6j03RRPcUt/mVU5x3XKjEm+ buXXRlfMnKOXasXkiOEVwp63ctxEMtwXPZiC8RtAgpRjGGgsSpwDgxMQ4asoM56OODIJmO o3bdiAlCFh0JB5PGYShlUIJAX4VXpNA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-71yo5x0MP7qtrw71q_QIcg-1; Tue, 23 Jul 2024 06:17:59 -0400 X-MC-Unique: 71yo5x0MP7qtrw71q_QIcg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-36857dd6913so2737075f8f.2 for ; Tue, 23 Jul 2024 03:17:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721729878; x=1722334678; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3j4Y7GKdDQsDIXrm9FcVVcCOdvIkQaL9wqx7KuVIzeY=; b=WCRwASNvWw6LnMng3tuMGugUPGHAUeGfIDqY/Pggfchjx2DBagcMOym3Ut/MCaRqnf 9As9FPDOoi1iS3wMV/PwfaEMljPgnuT09UWoPb8ovCMDOukFJdUgPwSdZ8hfMCGKN7y3 gAPKcKAzphXlcXuiqUfHe6Tmpfpgg8+a1cf4OMe1Gs6bA+ItN8jvb79P9pNoDAi/P1mi RMPxNhDWcBHa1K6n+UhykiPcEwr3+YJweUQgGEvfBl0dqz/SQ8wstPmS5bPce/KjRg+M j4iLIX5pjAPRiAz+wAW6fYUbeNqTVEin81zjSVUYIDNX1l1C+AnuPVC0eXSiYPXDCtgQ qscw== X-Forwarded-Encrypted: i=1; AJvYcCUZl+DgfPhSEUerkM+c00bZ3NO5qePSFdILJcwgVKosnNXrFt3ndAH8adGvnZ53PYw0PX3pBC35pJRcAJlB9lKdfdE= X-Gm-Message-State: AOJu0YzWuBQPxeRcMwUIkEdmlAja+yxo7x/V4wlcDpw61y0BdEfRiQ/f J8OCAoorF5T8RDXiiQwRcNp0XZly581zq4ImdnMFt3yfqcXI6xQuLkPLwrmMvASrW1V8BvvUZDC uxOFjqT1aBezyeOSosTSyYS6VsuXYB6WsN+bVgi2fzDm5z//M X-Received: by 2002:a05:6000:154d:b0:368:4e2e:7596 with SMTP id ffacd0b85a97d-369dec1e50cmr2642400f8f.37.1721729878629; Tue, 23 Jul 2024 03:17:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrm3AC2cxKkpu+sq3Ii9RJOUIHoGm2gLG+gxaEGBnjakrqS9oWSEElkQVsp6V9nna9hmn6Tg== X-Received: by 2002:a05:6000:154d:b0:368:4e2e:7596 with SMTP id ffacd0b85a97d-369dec1e50cmr2642373f8f.37.1721729878146; Tue, 23 Jul 2024 03:17:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ed00:9dc2:1adb:d133:4434? (p200300cbc72fed009dc21adbd1334434.dip0.t-ipconnect.de. [2003:cb:c72f:ed00:9dc2:1adb:d133:4434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787cf182sm11120465f8f.82.2024.07.23.03.17.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 03:17:57 -0700 (PDT) Message-ID: <1621fcbd-38b5-46a8-8b68-911f2920d52e@redhat.com> Date: Tue, 23 Jul 2024 12:17:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. To: Kefeng Wang , Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: "Huang, Ying" , Baolin Wang , linux-kernel@vger.kernel.org References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-3-ziy@nvidia.com> <5230d72e-81fa-4ef1-b386-90bd3b06bf0e@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0C27C100018 X-Stat-Signature: scx3uqmk1j9fh5j9ex4dznjj1pj9eh7n X-Rspam-User: X-HE-Tag: 1721729881-414951 X-HE-Meta: U2FsdGVkX194aygSeSVgpvHkZsJ4oZTPeookEsDUOrTghQUl0lcTfQ07B0Hk4taiar+b48Wt5Rv2abg1Gicf4TmnIzrFkpCXQ2alOx702CqLoK7P/HVnuOOzq73RldPDA3SOn/SjnNnqpmTQBS/0rjkrriaYFlMYUNlG2kiiMcS4P8AO5f63sTjBiIIBT27XuSjZdCMfeQnRmQTkja7KtF2nMENlz4qJEB4xP4P/RtdIpX1a3qFE9epL8wjQ2m1sThPTCDaLe88yLVPd6mXpEx6o+Ju8SwMqCo+mD7Zn1ZJMvteuF0PMJba7m/7k9fygsLHPB0VXO6sgSYyEEb5SiS8Rol4TqM2eoTkrNWvf38G4W/eaJqjpk1KM6dntVxjtw//4BrqRIIh3QLPZ8uUCnCx2uThzzXhCmGoztvmmcF6lu490BNREx2Xv1DoeSxKK2DIHoswy/Db0we0zYfl1K1hgSIqHeO01So3IYUtKj0NlFT1aR7nez3pb9YFMzpnyy7WTcY7wcRrQ28Jgm+xm2Mrv+E+/b6xfdF48CJjnucoeY3D5YLhuFwabbWi6PmbJa29QUWZkzB2YcDyQzWnKo0n1xO+hcHRxsRhIN7La/g10UedQ8xw6QjQr3T+VFiew1xYhFwmmYZOxDJ/B31W6q6U8EN7dMWrGRR9k6ADVrHDyfi74hjcda1OzngCr2n95W4LeWh8xt91ILGZlB3o5QfZWdCJbO8JsrhczGuz+qtFQLIrHEXvYExbweeNER/NLbZyl6nUzZHQt9QQ8mXMiB8ltXCEZT4yIHeKR5qeVYmN1SZtKZU9EB1BdHdHVSmWzEVjC12r/DVTJ1aS3FEbaF+b7bmIKBmbZ5Bc6R6M04ziQau3g3/39Artu4K31jn8iHaQdFq1wnQJWGRvQrVlH70iz/84e+hzDDyyzMkJ6qe6xxhZbuIpdt4i8/wM6aHTvyRXp9XmTI0AaYNNJsVi ebX+vii5 Fe9YG9mEg/XHSvvAA6BAyqXSL+Ns5fmFUYjMZt1J+vUxVEYo4Kx9crz5MvLXTrdJH1Y+Yt395I9davPy+dnEtxPgwNSElKJX8F+tUbhNoCdGyaKa6IAmJE6tkgcD2S7DI5dz553Tf2aRkWGjV+k9GaQEjPVtokrD0i3I9a1n9jf6mraGjoGpMk0WvaXhBwNLCt9IwFpw6HnzC1Uym8uKNH4eeo5En/58U0PXI9oiWtlx/ODeUITE1G/sZYl7TeaGyqZylHFh8zZoQJnIYK/EPfL/rNRQfitiU1QGjWh0cz++7zJ7Raz0PFGnQ+nE56TSoxAw49yfeSJj7bNfHS1ByomAG0VX8GCGltAqxngiVmFzIGsniZkj+xHGG6yJcjGaQdjd2tDJhKK5JVMeETEh7rA/8LjX5Q5iQvS/XHxgov8u2hHjVdBqCVbOgcFReimKu1avXMkWghq5D17auofj350FbLRK37JkEP2VbCq9S+Be0rGfx19A62UEff1NkJWZam7eV3FZkDrKDkKKpxR1L50uBuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.07.24 05:24, Kefeng Wang wrote: > > > On 2024/7/23 9:54, Zi Yan wrote: >> On Mon Jul 22, 2024 at 9:48 PM EDT, Kefeng Wang wrote: >>> >>> >>> On 2024/7/23 1:29, Zi Yan wrote: >>>> memory tiering can be enabled/disabled at runtime and >>>> sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check >>>> it. In migrate_misplaced_folio(), the check is missing when >>>> PGPROMOTE_SUCCESS is incremented. Add the missing check. >>>> >>>> Reported-by: Kefeng Wang >>>> Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ >>>> Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") >>>> Signed-off-by: Zi Yan >>> >>> Reviewed-by: Kefeng Wang >>> >> Thanks. >> >>>> --- >>>> mm/migrate.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/mm/migrate.c b/mm/migrate.c >>>> index bdbb5bb04c91..b819809da470 100644 >>>> --- a/mm/migrate.c >>>> +++ b/mm/migrate.c >>>> @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, >>>> putback_movable_pages(&migratepages); >>>> if (nr_succeeded) { >>>> count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); >>>> - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) >>>> + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) >>>> + && !node_is_toptier(folio_nid(folio)) >>>> + && node_is_toptier(node)) >>>> mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, >>>> nr_succeeded); >>> >>> The should be in advance of patch2, and change above to use >>> folio_has_cpupid() helper() too. >> >> It shares the same logic of !folio_has_cpupid() but it might be confusing to >> put !folio_has_cpupid(folio) && node_is_toptier(node) here. folio's >> cpupid has nothing to do with the stats here, thus I did not use the >> function. > > If folio don't include access time, we do migrate it but it isn't a > promotion, so don't count it, other comments? > > PS: Could we rename folio_has_cpupid() to folio_has_access_time(), even > without memory_tiering, we still have cpupid in folio, right? Maybe call it "folio_use_cpupid()" or sth like that? The "has" is a bit misleading, because the folio has a cpuid in any case, no? -- Cheers, David / dhildenb