From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBBEE7718B for ; Fri, 20 Dec 2024 15:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84ED26B00A9; Fri, 20 Dec 2024 10:56:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FF0F6B00AA; Fri, 20 Dec 2024 10:56:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 678996B00AB; Fri, 20 Dec 2024 10:56:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 49F826B00A9 for ; Fri, 20 Dec 2024 10:56:13 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB1141A0C23 for ; Fri, 20 Dec 2024 15:56:12 +0000 (UTC) X-FDA: 82915788186.15.895BAB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 742174000D for ; Fri, 20 Dec 2024 15:55:34 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWxk82yF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734710154; a=rsa-sha256; cv=none; b=5Ze52se2qYAZTM9jU2DTSv7m4nKoFx/bhTmlKIWUY3Rpx4xCXyVk2U3UbTjCy2R6fcxRhB zaLhGbvarlViv8u/UBIe1HeFSfd1SZLkUlfSzBbHEQWmhLnlsY7hZ24L1UG3hR7ROJK7zE Uqn0hhGLYVcXVIEQ911r5DUBqNNo3Y4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWxk82yF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734710154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NLoAskMueOumQ6CBIoVvHO8Q1h51MqpuP9iIVcbi2PI=; b=M3wr2JHBhgzw4+2OfvXKPUg8HToW+p8ntFDGzONcqyyI+VFtIq5Xdo1ZSCxXoCcFlt8OQH JhzWdtwydQGuMNStL95Sp6kenjzr+l6bMJyHVc9En3HY9xUoTEMU/CDpMxgCRfiGdxSU3g ma3P/6qzvbrGkOuq6dD/dP8lIzzFvjg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734710169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NLoAskMueOumQ6CBIoVvHO8Q1h51MqpuP9iIVcbi2PI=; b=OWxk82yF9cDQnmS+skOXGq3PVFDAWEX4Q8YNo9HQ5qa6BNxCxawwHXUyDlj5HJePWDl61N NQGUHpZpMDw9hS2SwI8cRMBX/riqhXCUERhMyUi46TxtiG1HuEdOgLL1uIf9lkdhzuWwZz HSpd3zCoeWNaZG15Ai4WVgaiAYpK29E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-7qbCkALzPkaih0IFdCKcMg-1; Fri, 20 Dec 2024 10:56:08 -0500 X-MC-Unique: 7qbCkALzPkaih0IFdCKcMg-1 X-Mimecast-MFC-AGG-ID: 7qbCkALzPkaih0IFdCKcMg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so17766175e9.3 for ; Fri, 20 Dec 2024 07:56:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734710167; x=1735314967; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NLoAskMueOumQ6CBIoVvHO8Q1h51MqpuP9iIVcbi2PI=; b=JJ7UqEArSybJ40uCHhemAOS6YRyy5aVS49ZTAFp4yUG6zxTNwOfhkPlw/gn4f2YJJw GQYDVwjhClvuIkdsjRg8KhXCu0++Nzwvzgf3WyW0GQPF2g5LlmtY/1iGnUC54+PZCkir J80VOg83zCGdHJi+dt0uUvQDp2+iawwVkx5j1Tp5BXNgpJ6ydYE2dbk0Cal6wJnw9q6D P7SOcxaxO+5++N+HfFgCCX1oHIr45OQH3sK0V5KE1DGa+KKvpr8k/3E0abrc7mKq7Al6 1Ipfuxw2B8acTSXv5OLK1jZVEoCQ2D8Oe79KCZ82TFU1mICkHRlxmulGfM0AWHrTskoe Q3Vg== X-Gm-Message-State: AOJu0Yw6duBRraOZa7p2Z2pM5cNbU2q/j4XkLJtlK9X1UwzrgFB+R4/v 4/tzGry6bMJKFJQNNtuKCMQBsy+/V7ANp+iltHOW14zxJOU4FIMVEjuFWXNn5TSJF179GMqGXNI +knzJyW0ZCd9qh1DFhNHxilviwA3OwuamVOe/tQFgo8xi5FHCVNSl4C2Tvu8= X-Gm-Gg: ASbGncsq03nP1FF8mdYyxk0wEpXEcS4Y5QsSfZjBL/pyEOCwODMFDmtSW72C/CKEHfI /tJAiGD3QrwUyFu0VifF6EkX6PqEHdcUGDX/F45yzvkWJu+MR/+kaNhAEz6KMC3P1IhPjwBrSAR 0p3Gsxs/1GYR+0osbJN/ziabIiR7AhWvoDoGaCMtaY9dTk842osQm16o7LlAqFcbs4xjKgHAd66 8HOr13d2U0K9rcz6QUurwaH9J3Tu/R5DWNVzEVidtF8IDZbX9SckOpJqH7PD44AtHAKThsQvWuI KWepquNuVlQCTEekTW5Qz1cIiU9zNLhxDIYYQr32F/eqBITaSNkjYomQi/y3wiFTSK3RJ2DoqfD 35wG+1HNf X-Received: by 2002:a05:600c:1388:b0:434:9c60:95a3 with SMTP id 5b1f17b1804b1-43668642725mr28625765e9.11.1734710167089; Fri, 20 Dec 2024 07:56:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIjjnR/RjFdFAWWzPt1Pg5WWrOXZd11R1T3clf0qwYTw4fQxX0acgLkSQ+g4AlanZ8as6DnQ== X-Received: by 2002:a05:600c:1388:b0:434:9c60:95a3 with SMTP id 5b1f17b1804b1-43668642725mr28625585e9.11.1734710166773; Fri, 20 Dec 2024 07:56:06 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366127c493sm48625755e9.28.2024.12.20.07.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 07:56:05 -0800 (PST) Message-ID: <161e99cd-543b-4be2-a6c1-d7c4ff4e74a2@redhat.com> Date: Fri, 20 Dec 2024 16:56:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add build-time option to set hotplug default type To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@kvack.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org References: <20241220144518.206208-1-gourry@gourry.net> <11911ad7-527b-411b-9896-fea06bf38a26@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V5OeJxGYPu0O6DedVcgImPlooziCSs5H22QxULpujXU_1734710167 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 742174000D X-Stat-Signature: aw4emgupgeomufrhw7xtpygyxqmfn4rc X-HE-Tag: 1734710134-312983 X-HE-Meta: U2FsdGVkX199iYqw4fpAyBlS6OYfWapeukb/kOA9PSYYAR14UNXgZ/8WSUFGGFIV68RUVaQ00aiLQ4Mn2ViDgcucv2TPjH/mJHgCqFxXINNao7y0eMkH+mOlE2PcKIhHuLO8iXNHtPT4hoU9duRshmae9TkKL/ys+avSWYIsncYjgQhnKD0m/+yo2AsbNU39i+aFAAbyW0zDWCq0wJSqYINXjRECRNZdsmhBFmeunMD/NDQPCQmQ7H34d3nbopMiurO+A6kCwoD6AQ/gq9QXKJTyBOsxyvrOZlHFLFmiX9+Ejno+K7D58xH8XKxPIIBy1yLp/qgs6bAthXOey5mU+W1mxeXb1f5g4B7QW1paqfvgRt96oN5W1BKhzQ1TiG0xIL7ht7khHaBi+GmCN2M3ahbcfhuLCckIkR1X5AEv+yDgrVlYgX1PX/P92Ce3LDHn0HOVT01KLmz1bdkOxSbRT5J5H1Rx2CriBXoI7Huw4aPPhgoVPvh98/Q+MRStBL5NP1fkpApQo3F74uruW+bdR7lNBhZdQgJueOqyBk2At3pS8XGLK+JeIueaSKKxPqJGswFAGyP2oM3qGuLxAqwKGh/Ofsa6CBzVm7lFTCN+CHj6AAttulDMiNog9NQ18DMPhT996oH9SO5grTdTUrE2k9SNJnHj4eL2lwJVOZUNLXNbPUFB/17mMWzDh4qvvpm8ySkOMCbOsgAmADHHHzF1y0D0wvkS/xAVq9NnTb25sYiCcndMqivBGUgw7ZkLEWMXOfyBKW4BEObCVDbs/MXvRGrRal16dh9sW9tEmTC79ofSucKvrwrQeWUOFoi+bLUZfCX2DcHzeXAgIhuCXlxZ658GwYihMZ/bs5Fi807sZZ8FLQ6v+8kmxfgrbrgRmb6iti7QLdgkCTWGF/yXRbRl2KiRC0qZ5L6TsirSD0VYYuNJkrkc65D6br8fKDIUGDFEq4amQt/IvtZCfA3y7XQ hne9/wBh 8c+NicBxnvWmPX8q3+kaSZdDqYdohyFavFkvCju4qTeyK6IpFFlWnBd8BDepFZrhB5Kx+O/72dqBWdyGmKf/zVBG3xkUQ2rS5uuGVnaqaghlLdCe1bEyuokB7BNyw/sxOjV8JxhLWOxnya8cwVaEZCZblPTeHTMIde/UlR7fqUIOP4cDspCSjNLz1mlCWcIW9UMx4OSjURxvs3UFGnWkkxY0/r8LfBGDy4xqC0ZRcM05b8I/OrJV9wu15vrsP9LMtelaFlrmYs+PsHiCUZhm3dTjLLWwHxpOzoreoQkbamXSep+yOAmpwBUUOuzK1j+Ex9XNpsYJvUZLx7Ix6ZCvGo3WhS+F5l9HEGSux7fUmU9rp4rdLiZaby93mV4TlJbhMssemWNMQ/GKNJTg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 16:17, Gregory Price wrote: > On Fri, Dec 20, 2024 at 03:59:58PM +0100, David Hildenbrand wrote: >> On 20.12.24 15:45, Gregory Price wrote: >>> When memory hotplug auto-online is enabled, hotplug memory blocks are >>> onlined into ZONE_NORMAL by default. The `memhp_default_state` boot >>> param allows runtime configuration, but no build-time config exists. >> >> + you can configure it at runtime. >> >>> >>> Add a build-time configuration option to change default hotplug zone. >>> >>> build config: >>> MEMHP_DEFAULT_TYPE >>> >>> Selections: >>> MEMHP_DEFAULT_TYPE_NORMAL => mhp_default_online_type = "online" >>> MEMHP_DEFAULT_TYPE_MOVABLE => mhp_default_online_type = "online_movable" >>> >>> When MEMORY_HOTPLUG_DEFAULT_ONLINE is disabled, MEMHP_DEFAULT_TYPE is >>> set to "offline" to match the current system behavior. >>> >>> ZONE_NORMAL still remains the default, because for systems with a large >>> amount of hotplug memory, defaulting it to ZONE_MOVABLE may result in >>> portions failing to online if sufficient ZONE_NORMAL memory does not >>> exist to describe it. >>> >> >> What's the use case? >> >> I'm hoping that we can move away from the compile-time option and let user >> space, who better knows what to do (especially with different kinds of >> memory having different requirements) configure auto-onlining or online >> manually (e.g., devdax). >> > > At Meta we have a fairly complex boot process that goes through multiple > kernels before we get to a target kernel to run workloads. Each of those> kernels may have health-checks that want to see the memory is online. Fancy, I'd love to learn some more about that if there is public information available somewhere. > > The build switch makes this particular feature consistent for us across > all those kernels without having to carry the boot parameter. Eventually > we'd like to move to udev, but it's not feasible for us right now due > to the state of CXL BIOS/Platform/Drivers - driver-management does not > work reliable for all platforms and all devices. I see. > > This gets us where we're going while the rest catch up. Understood, let me review the patch briefly. -- Cheers, David / dhildenb