From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5B8C433B4 for ; Sat, 17 Apr 2021 02:39:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8687F61107 for ; Sat, 17 Apr 2021 02:39:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8687F61107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4C196B006C; Fri, 16 Apr 2021 22:39:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAD956B006E; Fri, 16 Apr 2021 22:39:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4E116B0070; Fri, 16 Apr 2021 22:39:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 96E036B006C for ; Fri, 16 Apr 2021 22:39:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 474D7585D for ; Sat, 17 Apr 2021 02:39:53 +0000 (UTC) X-FDA: 78040303866.30.FA63E36 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 25F532000250 for ; Sat, 17 Apr 2021 02:39:54 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id d124so19495196pfa.13 for ; Fri, 16 Apr 2021 19:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=d+i0hnWpFX+Mj0V53vmK2vj8eRQNdZ7OmdBSqZs2JJu/wGdZaWjUSK5j03u+Qpqm/L JZoSxrNu88qDz90SkZdyhY8BYMglj4UmZjcr6iTK6UWLU0FqAmcd8fGLlLW1/vwJH7wv uZwheH6dxMQ1lPMdfOj75qaFpNBsekFCKLNIKBUCKAHiCRAF0DdRBY6UyDKiQziz4PNl OXUB/cWg0CbBphwRIMSOla1jFmUsP8imKGMwzwRREmU2d5lIuEVgaf0gxRGcDX3ZhLHv QWLgav7Bm3QDC+X/8lCvPBVXjQw1dbC6orZs1vwa6Fgu1hfu0U5vP03SdT7jUqw9PySn oCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=agPae8naPI8Fvhu/25RQGBHE0MyqkxIqIAvh0yIQE8X7Ho9EZNXMWwmgvqIg855tPq UMG98TYQaoD9ErBPjuVj+JF93KK2McRsQfMeT4umkCs2f/BSPJgCRcaPSIei7cQiEH+W I4eb5Md788C/OLNIrLt/p5jgLYpuv7JFKHA1hPlivXL4x5AclFfAY4Ih2bqCKV1b6Hrj pw5o842hUiVKkgDzGM8ktSUgQHSQy+0Nd95Ui0jH3Ps/HnDmyQMyZy8t+3SW20b8Em8R gBCBKrJ1QEtG4OyljPNFNEVCbYls6Lg6QXaYYyCV6dMYhToJw67mkWDjo3gBroAtkyn2 i93Q== X-Gm-Message-State: AOAM531Ck3VAECgkCyq/ANLW+D7iboB+5TpBQdOULHwq0iUpS0lJHVke tCb9MZ5mZMku632IZpFE3EY= X-Google-Smtp-Source: ABdhPJzKHRpN7gEF064yyI6uHK9DoHuLx2LLT4PLDM9LCYl5VihNm2cIzm1UeMD0xnn7UN5ajHvQVg== X-Received: by 2002:a63:28c2:: with SMTP id o185mr1752428pgo.40.1618627191851; Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Received: from localhost (193-116-90-211.tpgi.com.au. [193.116.90.211]) by smtp.gmail.com with ESMTPSA id k19sm6304711pgl.1.2021.04.16.19.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Date: Sat, 17 Apr 2021 12:39:45 +1000 From: Nicholas Piggin Subject: Re: [PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings To: Andrew Morton , Christophe Leroy Cc: Ding Tianhong , Christoph Hellwig , Jonathan Cameron , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Michael Ellerman , =?iso-8859-1?q?Rick=0A?= Edgecombe , Stephen Rothwell References: <20210317062402.533919-1-npiggin@gmail.com> <20210317062402.533919-15-npiggin@gmail.com> <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> In-Reply-To: <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> MIME-Version: 1.0 Message-Id: <1618627160.9nazv519mt.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 25F532000250 X-Stat-Signature: opukzxtdrqdqww55eree5c688yh6oq9x Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-pf1-f180.google.com; client-ip=209.85.210.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618627194-774342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Andrew Morton's message of April 16, 2021 4:55 am: > On Thu, 15 Apr 2021 12:23:55 +0200 Christophe Leroy wrote: >> > + * is done. STRICT_MODULE_RWX may require extra work to support this >> > + * too. >> > + */ >> > =20 >> > - return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, GFP= _KERNEL, >> > - PAGE_KERNEL_EXEC, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, >>=20 >>=20 >> I think you should add the following in >>=20 >> #ifndef MODULES_VADDR >> #define MODULES_VADDR VMALLOC_START >> #define MODULES_END VMALLOC_END >> #endif >>=20 >> And leave module_alloc() as is (just removing the enclosing #ifdef MODUL= ES_VADDR and adding the=20 >> VM_NO_HUGE_VMAP flag) >>=20 >> This would minimise the conflits with the changes I did in powerpc/next = reported by Stephen R. >>=20 >=20 > I'll drop powerpc-64s-radix-enable-huge-vmalloc-mappings.patch for now, > make life simpler. Yeah that's fine. > Nick, a redo on top of Christophe's changes in linux-next would be best > please. Will do. Thanks, Nick