From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41885C433B4 for ; Thu, 1 Apr 2021 15:58:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD28261247 for ; Thu, 1 Apr 2021 15:58:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD28261247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19E6D6B0073; Thu, 1 Apr 2021 11:58:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180E96B0074; Thu, 1 Apr 2021 11:58:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03D286B0075; Thu, 1 Apr 2021 11:58:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id DC4846B0073 for ; Thu, 1 Apr 2021 11:58:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9BCBD8249980 for ; Thu, 1 Apr 2021 15:58:07 +0000 (UTC) X-FDA: 77984254614.13.9524256 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 53D09A000396 for ; Thu, 1 Apr 2021 15:58:06 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id l1so1220718plg.12 for ; Thu, 01 Apr 2021 08:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=XSWTbuudGCpn8J8lHaA+sjrRENPnrSOni3X3Esa/ZJg=; b=uSSlsyUkkMaUrUKOVDfXs9B9PDe4WrmMkGKsEBmnO65ahicCLhSSjoLnkmqpSPaPii nyX8t2r4TUVZaWjix0PJTB9gLt+teJhRMPg8x+Z5ztJuEhyjoHh3NJmKmtxBKlByhI3f v9vMD8Jo9KeAeVs14i3nMZiMXR6GQLohBxw0tFWz3NIPlo8mlha4BHUwqB/wS1mIRHbU kTVJKGHiWlkD+JCTSSo+b+0ehK+spogt2i5Vq/jAUUi/T3ixwm1f7t5L7ATTyWIPx88T YWjlT3yMCSh2rezCV0WLwK1WX6oLbQ02alZ6bC4lYZ/ErON0b15kYLGZVEg67aoPwq5c 1WmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=XSWTbuudGCpn8J8lHaA+sjrRENPnrSOni3X3Esa/ZJg=; b=AOqNCJMDGYHDsy3Y+iL0AOEFuKY2CZA2wrsRFqXyMpQorxU8VA2eJ4krEWs1CYlFAM jL5Tne4nVhEBIHgGSpD40c/3cGX+V+6XmlQiBeVdWuMFaYUp8el6yJgliN6PgiGs7kAD X3Sf8MCVYyzlAf63R4W7e1ni6Nhv3iIUlJM0zimmMEwqsjK4ffmoSoAxR998kAvUVauY 5fhpgmefrD2HIphyUAIVe5jisKil6ZTDG4JkIwsARDIQqMWCcx16Zm1TnL0gn05flmZm Yx5+EgzPNdTZg5iDd7NjdELkDP1Kpx276Vr2tcG85pu486/wYzeTTtAdsfiaV+0HfCGH Xasw== X-Gm-Message-State: AOAM533OnCo3+c1/bpYMmfiOm+zYPxVxI+FUL+V6qeeLRsptuqVZGxE/ 7wTlO9ZNMSpDvE+E1OCeWxo= X-Google-Smtp-Source: ABdhPJwr0S7Rpk56rytj/6KrM5kAIMkcrX47IjuKNmWhVan06wH7Yn9+HzTPGQI2a5t36qxnwDpM2A== X-Received: by 2002:a17:90a:13c5:: with SMTP id s5mr9287075pjf.31.1617292686409; Thu, 01 Apr 2021 08:58:06 -0700 (PDT) Received: from localhost ([1.128.221.79]) by smtp.gmail.com with ESMTPSA id v18sm6037363pfn.117.2021.04.01.08.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 08:58:06 -0700 (PDT) Date: Fri, 02 Apr 2021 01:58:00 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 4/5] mm/vmalloc: remove unmap_kernel_range To: Andrew Morton , linux-mm@kvack.org Cc: Christoph Hellwig References: <20210322021806.892164-1-npiggin@gmail.com> <20210322021806.892164-5-npiggin@gmail.com> In-Reply-To: <20210322021806.892164-5-npiggin@gmail.com> MIME-Version: 1.0 Message-Id: <1617292598.m6g0knx24s.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1o6bykchfocie766u3ufri17qramm37i X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 53D09A000396 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-pl1-f181.google.com; client-ip=209.85.214.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617292686-543361 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Nicholas Piggin's message of March 22, 2021 12:18 pm: > This is a shim around vunmap_range, get rid of it. >=20 > Move the main API comment from the _noflush variant to the normal > variant, and make _noflush internal to mm/. This requires a fix for nommu builds and a comment bug that sfr noticed. --- Fix for "mm/vmalloc: remove unmap_kernel_range" Fixes: mm/vmalloc.c:425: warning: expecting prototype for vunmap_range_noflush(). Prototype was for vunmap_range() instead percpu.c:undefined reference to `vunmap_range_noflush` on NOMMU builds Signed-off-by: Nicholas Piggin --- mm/internal.h | 3 +++ mm/vmalloc.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index 8b20d5039b74..217fff7c7807 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -632,6 +632,9 @@ int vmap_pages_range_noflush(unsigned long addr, unsign= ed long end, { return -EINVAL; } +static inline void vunmap_range_noflush(unsigned long start, unsigned long= end) +{ +} #endif =20 #endif /* __MM_INTERNAL_H */ diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 5423f6c1417f..f99c1bf714cd 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -413,7 +413,7 @@ void vunmap_range_noflush(unsigned long start, unsigned= long end) } =20 /** - * vunmap_range_noflush - unmap kernel virtual addresses + * vunmap_range - unmap kernel virtual addresses * @addr: start of the VM area to unmap * @end: end of the VM area to unmap (non-inclusive) * --=20 2.23.0