From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87905C433DB for ; Sun, 24 Jan 2021 12:22:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F334D22CA1 for ; Sun, 24 Jan 2021 12:22:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F334D22CA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 484166B0008; Sun, 24 Jan 2021 07:22:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40CD36B000A; Sun, 24 Jan 2021 07:22:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5FC6B000C; Sun, 24 Jan 2021 07:22:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 142616B0008 for ; Sun, 24 Jan 2021 07:22:31 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD89D180ACEE4 for ; Sun, 24 Jan 2021 12:22:30 +0000 (UTC) X-FDA: 77740581660.15.magic56_32145f32757d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id A858E1814B0CC for ; Sun, 24 Jan 2021 12:22:30 +0000 (UTC) X-HE-Tag: magic56_32145f32757d X-Filterd-Recvd-Size: 4752 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 12:22:30 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id x18so5915236pln.6 for ; Sun, 24 Jan 2021 04:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=CRaVGlQqRX3eurTgpUbO4LACsIgYJz7bYMhi3+skM5w=; b=bKuMIpY94qcNZor5JJbg9y1rkV+5c8vEcy8sNNmZrJUwLgNFSRZhf+all1fV932huz wST13It32l8icQp15BnImsizqjvbJQLYNhoL7x7ZRkgBgcOfNuR8Oy0kVPUtgd1ORKS6 JEyqT1VlF3ILsaDXQZtPvomWZNaQJnlMIURLJq0oMoqXmWEnsJ9AEU7HJ5sPiJoq/dOm vwEBo/rNNqQJZ9HFhwjQUVLozjNpoyus8kim5gwC4+mChA5Y9Kan3xIm7TjU2jav6WrC 5DV23rzG1YktYfARiBniJtFxlEvfZYmXbYjVn2fO51jteM+KsG+O3Dr62VcXSAjmPccp gqtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=CRaVGlQqRX3eurTgpUbO4LACsIgYJz7bYMhi3+skM5w=; b=oGaVp7qjbPWEXtqdnWIKsDUwCQUTvEkEb+BFgGxxRBymnVKmLHiS5I/ido/jz8bFWb 7Mwo1GeRg80nI8yUPx3ZHI/IMAQq+DLfIfehkElFPwlSH6OHW57JQlRQkrNtXkFLqS3Q /5CmBYUrx6TA/S43vXoWNwN0xEJIyXx8YRdsVDj1yrfvIyYTjtRmnurMdPwC9g4IATNh IXrH0rF0/z6klc7hHq83+PNSel2Na59cfcZRRzfzFO4P/P0Ng/CW89y1EVcIMeZffCK7 z8f677F44c3B0iMHq9a30q2QSGW7rgLh/dItY1Exf5Xp793dWI3jCtLJEwjFmnSeHS3Q SP0g== X-Gm-Message-State: AOAM532D2h2nnozXEwNalL7IYyg8DTxm5h7zr44omk2xrWGdE9i4yHQe Hnsopx5sYfSddBSZHRgnMm0= X-Google-Smtp-Source: ABdhPJy/cCBq2SaALYuvfokncGx1EYWoF3TIXnlyNQ1FvlbAreoJvYPu98Y/UK3bgTxLg0uNGqM4cA== X-Received: by 2002:a17:90a:de97:: with SMTP id n23mr7464729pjv.216.1611490949139; Sun, 24 Jan 2021 04:22:29 -0800 (PST) Received: from localhost ([124.170.13.62]) by smtp.gmail.com with ESMTPSA id 5sm13830020pff.125.2021.01.24.04.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 04:22:28 -0800 (PST) Date: Sun, 24 Jan 2021 22:22:22 +1000 From: Nicholas Piggin Subject: Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup To: Christoph Hellwig Cc: Andrew Morton , Borislav Petkov , Catalin Marinas , Christophe Leroy , Ding Tianhong , "H. Peter Anvin" , Jonathan Cameron , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Zefan Li , Ingo Molnar , Rick Edgecombe , Thomas Gleixner , Will Deacon , x86@kernel.org References: <20210124082230.2118861-1-npiggin@gmail.com> <20210124082230.2118861-6-npiggin@gmail.com> <20210124114008.GE694255@infradead.org> In-Reply-To: <20210124114008.GE694255@infradead.org> MIME-Version: 1.0 Message-Id: <1611489959.87u9aj91nf.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Christoph Hellwig's message of January 24, 2021 9:40 pm: >> diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/v= malloc.h >> index 2ca708ab9b20..597b40405319 100644 >> --- a/arch/arm64/include/asm/vmalloc.h >> +++ b/arch/arm64/include/asm/vmalloc.h >> @@ -1,4 +1,12 @@ >> #ifndef _ASM_ARM64_VMALLOC_H >> #define _ASM_ARM64_VMALLOC_H >> =20 >> +#include >> + >> +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP >> +bool arch_vmap_p4d_supported(pgprot_t prot); >> +bool arch_vmap_pud_supported(pgprot_t prot); >> +bool arch_vmap_pmd_supported(pgprot_t prot); >> +#endif >=20 > Shouldn't the be inlines or macros? Also it would be useful > if the architectures would not have to override all functions > but just those that are it actually implements? It gets better in the next patches. I did it this way again to avoid=20 moving a lot of code at the same time as changing name / prototype slightly. I didn't see individual generic fallbacks being all that useful really=20 at this scale. I don't mind keeping the explicit false. > Also lots of > 80 char lines in the patch. Yeah there's a few, I can reduce those. Thanks, Nick