From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04812D5B154 for ; Mon, 28 Oct 2024 21:28:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95BC76B0092; Mon, 28 Oct 2024 17:28:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 932A36B0096; Mon, 28 Oct 2024 17:28:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ACC66B00AE; Mon, 28 Oct 2024 17:28:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5CF166B0092 for ; Mon, 28 Oct 2024 17:28:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D9CA516048E for ; Mon, 28 Oct 2024 21:28:51 +0000 (UTC) X-FDA: 82724299686.07.9022CD4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 2212C40003 for ; Mon, 28 Oct 2024 21:28:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gY4S+t2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Yx611nV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gY4S+t2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Yx611nV; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730150849; a=rsa-sha256; cv=none; b=bC3FaQdK0TAngYZIJAmYaQ2gddy+yudwhQUAVvv7FF1nKG1zuw0Dr1vkU9lNdchKKiwCX/ 9q2TAz97ciSY0zdAFJQk1Fp2Vqhq7VClZSbZWN1M3U5s5ECpZBX44cX4eEOjCbwXkSr/ep GKDPB+xz9Y0HHUiGR4X0j2THQ9yqnEc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gY4S+t2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Yx611nV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gY4S+t2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Yx611nV; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730150849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3D2dtsJXjqQOtB0+meeTCf0vlHG3Ad378pPp6PP5FRU=; b=H1RFNJifn/9C4o7CGi4P7iWwbljiHzrm0jm7OlKUOKb2la97ORpdtDSP6Po4TlEtbrx9V8 O2dD25yUZbg9wPgzC4o6VNfEWxz6Re2L095Gn4sRd5M7QWVVXOk/bOjWuYV3NwhgPEFDar SgKMAsGFJGtcrefaNSu/DsmXJF4ItWU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C04A81FB77; Mon, 28 Oct 2024 21:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730150927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3D2dtsJXjqQOtB0+meeTCf0vlHG3Ad378pPp6PP5FRU=; b=gY4S+t2lqE1DJRPEygvR4Zo2PiJJpaMppdYeu1Ay0Ww1MuvRhx+eSKgpfidSUIWARm4UD9 xCZN++gvce6iGQxNQQvJDFMOjxQn91zcl8C/KQmnAvup05Mvgaprwj82a9CCgeWH7rx5TN NxaDL8BJV8h53m1Q1koPrnJG1wPE/V4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730150927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3D2dtsJXjqQOtB0+meeTCf0vlHG3Ad378pPp6PP5FRU=; b=2Yx611nVglvbQbNLxDSerKFPar75CUHMN8NqfWiLT39z7P657rpybVsZTlpEv/SpYIUqjf NPDQ9rUeBWR6o7DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730150927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3D2dtsJXjqQOtB0+meeTCf0vlHG3Ad378pPp6PP5FRU=; b=gY4S+t2lqE1DJRPEygvR4Zo2PiJJpaMppdYeu1Ay0Ww1MuvRhx+eSKgpfidSUIWARm4UD9 xCZN++gvce6iGQxNQQvJDFMOjxQn91zcl8C/KQmnAvup05Mvgaprwj82a9CCgeWH7rx5TN NxaDL8BJV8h53m1Q1koPrnJG1wPE/V4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730150927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3D2dtsJXjqQOtB0+meeTCf0vlHG3Ad378pPp6PP5FRU=; b=2Yx611nVglvbQbNLxDSerKFPar75CUHMN8NqfWiLT39z7P657rpybVsZTlpEv/SpYIUqjf NPDQ9rUeBWR6o7DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9FF64136DC; Mon, 28 Oct 2024 21:28:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ncpoJg8CIGeUcAAAD6G6ig (envelope-from ); Mon, 28 Oct 2024 21:28:47 +0000 Message-ID: <1608957a-d138-4401-98ef-7fbe5fb7c387@suse.cz> Date: Mon, 28 Oct 2024 22:28:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Content-Language: en-US To: Linus Torvalds Cc: Lorenzo Stoakes , "Liam R. Howlett" , Mark Brown , Andrew Morton , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> <438f50c5-8b8c-444f-ae85-10e5151f3f24@lucifer.local> <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> <0b64edb9-491e-4dcd-8dc1-d3c8a336a49b@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: opbcj6ezt4zia5armtrfou8k7fr9mm4q X-Rspamd-Queue-Id: 2212C40003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730150910-598959 X-HE-Meta: U2FsdGVkX18kAm33DG8vhiU5a6SDDr1pGR5+CmMf6XoTruH0qsrC7D6kM4QVUVzbgyvQ5PSR5pdHTbq1zQghsAsidODCMh8lQjyrV62/eH1eUo7Pe39BQ5tPnLYMjEN1aAdWG0Yu9QfmmVy/CXvAIZKFZfofFJVTS3iNaO9hJoB4V7gt3hcbF1NYD76Ap+7f0KdXp2LeUyR1MgVmzNYIVCXag1CrGw+fB41R+yyy2A1+Jb71WMZVKy4/V/Z9IRgnzxjESs7I4Ny7xnX8C1ypNB1MSWnogyRCBok3atRlXMykBZI1GVaEvpn2xiNPmu/ot2KO3PH/q5fYyEgnHCUrNyTfJNR/WyO4FjiRUjAjvzXLNw3RhiDeogGCNlw6aUfJl/DIaPS7FcLzV83EmB1QdT53telYX2BR754RqZcPH2dwsFaWL+G1+87xSl1QYJZfor84uzuVqkzSu2aldXIrxscaC7R3Ae6g1tlSNUT5Ufpr71xAL0p+v6QvaRA8FB4mCnJ93c9UgRWaNFxXoRxfd+Yo+pwqC0IddyjLOjDPLvROpCuBFvGDKhqnMZvFPH5qSd3vJTL95WiEF/77iy0LuYZGXy7K6icLDClun6rdvW6bhba++Lr9fV188YoWCxXrzcCLjRO1myK+efdzsiAts7h9Xp8c+CQPYeSFvyUlcoX9CaO9YwNlU4Lv1/6P0HZYZHlzkKw80x/9HC1dSY47RMQqwx9on34MMruqg1J675Bkc03wdV/5anH8pTtxt32yMZ3YlqVk3aYyCxbFYo76fIYjhn0980GJLDw5by2zz6aE2JiT00o7T6IIyHJipu4AR/91lhv2W2VcnR1GgXM7ehwzl3k4qAk7qQXChdOrYUwmsKBSpK7gTzoenP7V7g7deTrT/XIzY5b+lk2ys/vFOSs5Wf/ogEnQEpVzHyrk66/nL28PXyZCTcfT+jbNNO44NkttS7uR2TrqmlVrkXN g49eHcTk lbw0fegsKPFjY/6G7N0lbvCmRdx4Wszftebt+MHdUw9mtjzBVcrB0aC7Ej/P+HfobH1WfjhibG+HH9T3FvjbHCnLhhNraZ18FPRKyS5jdNVCql4QPAFYkq0TJ4kaqjlIdWCE9pd0SbTWCHrB6BCcGRFE1ILNU4hs7sLN+PvdJjNibDnwpQCC0NGN53uXDLRYZRZasEr8g5fthCP82GEEOPLLs37MBSEFXV+H7TEZg4jNJHAbuFQ1J0dq9yvm3SAJVIPjuC+ZanNWv5gmBitDvIj2dspAPDvqEEDlqYLjI11GQ/EE8c7qfxuwxwjFDhmYjHTGqm1mmwI7rXns= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/28/24 22:19, Linus Torvalds wrote: > On Mon, 28 Oct 2024 at 11:00, Vlastimil Babka wrote: >> >> VM_MTE_ALLOWED is also set by arm64's arch_calc_vm_flag_bits(): >> >> if (system_supports_mte() && (flags & MAP_ANONYMOUS)) >> return VM_MTE_ALLOWED; > > Yeah, but that should just move into arch_validate_flags() too. > There's no reason why that's done in a separate place. > > Linus Right, and VM_DATA_DEFAULT_FLAGS is only used in do_brk_flags() which is also an anonymous VMA, and it doesn't perform arch_validate_flags() anyway.