From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3C1C433E0 for ; Wed, 23 Dec 2020 07:13:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7088620E65 for ; Wed, 23 Dec 2020 07:13:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7088620E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9654A8D0019; Wed, 23 Dec 2020 02:13:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9156C8D0015; Wed, 23 Dec 2020 02:13:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82BEC8D0019; Wed, 23 Dec 2020 02:13:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 6DB578D0015 for ; Wed, 23 Dec 2020 02:13:17 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2E8581EF3 for ; Wed, 23 Dec 2020 07:13:17 +0000 (UTC) X-FDA: 77623680834.05.rod18_150a5d527466 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 16E9C1803EF0C for ; Wed, 23 Dec 2020 07:13:17 +0000 (UTC) X-HE-Tag: rod18_150a5d527466 X-Filterd-Recvd-Size: 3642 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 07:13:16 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id v1so2559098pjr.2 for ; Tue, 22 Dec 2020 23:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OLLlABMcnLaZ2+a25LVeCiRaOI6+Z0TYRuLGAo/ldK0=; b=a3FnPaniGpHWcXQOuLqTbicTgC70fiK2pkKHHjX2jAofd2HZDvgGHn44ak6iP9K2om x+N+B41pi69PNhEs+GbPEYIop4V1MHU9d4ClDnxMmGQiJD0MGKiuQ0y6o3wzzEUbqJO/ mu+lGBStZWTdA/KRs081vtcIpzMdN6s0vwuoKCI/yI2uXwpexwgIbgnQPmg4nd9zirGL KDWu/7ACgzYtvz6HlzndusLSVYK7b+0IUmvj49STX7D6p54LYPDgR9IPwho5qvuTFu4F 6yvZMoawKrFv+hCfzxYF8PijrW4oo9knI9PnxEYGQSaf+2kSi13nO+0zAejICNfsHWsp VAEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OLLlABMcnLaZ2+a25LVeCiRaOI6+Z0TYRuLGAo/ldK0=; b=OSFy+8Sn8MZp0+/beRH0TOib3HxMgmJ7+VumeisWCjhyZLCK8Bz31Hir24mYAsqHK4 /N5qPj3ZlcXdZ8Vv37BSU2P8Tdhpun8h8xLY0IV513XqID3oLU3WMTs8xD1FcdTVslZI t7p2a7JZASN8hPRkBEagwVUyyioeWeCVvuxN1Kz4M0E+Vk7uemOhFtvYXZpBJLvKPbBL Xz9I2YTur8jfiLN4/+D3+49aG9qnytWrBlfPuU+6BMi83epXNScIFrpBTD/WoPbJ4b3Q TgxZo69uoYbjsH8vHRdHQV7FuS50y3nkDcxsBPZ2fTAWiBhuZDQn6Mq9Qamvm3JHt+Or Z3nw== X-Gm-Message-State: AOAM532OUeF+iRd+P9BYmHhAFxEfZwIVv0mtQ+nI9wJOZIEmxtKP/omZ xep6mUL2pKFH2WFWxzhYunQ= X-Google-Smtp-Source: ABdhPJzBSoblsqkrl6LTyCzAEK6lWXx35D0TlsHdqE8LerqVWCULllGiC/SQnqe2mzQz70uL8OAdUQ== X-Received: by 2002:a17:902:bf06:b029:dc:1f:ac61 with SMTP id bi6-20020a170902bf06b02900dc001fac61mr2863215plb.16.1608707595652; Tue, 22 Dec 2020 23:13:15 -0800 (PST) Received: from ubuntu.localdomain ([202.155.238.152]) by smtp.gmail.com with ESMTPSA id v9sm22063528pff.102.2020.12.22.23.13.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 23:13:15 -0800 (PST) From: hui yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, YangHui Subject: [PATCH] mm:remove useless code Date: Wed, 23 Dec 2020 15:13:09 +0800 Message-Id: <1608707589-6067-1-git-send-email-yanghui.def@gmail.com> X-Mailer: git-send-email 2.7.4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: YangHui remove useless code Signed-off-by: YangHui --- mm/vmscan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 257cba7..af1d176 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1234,8 +1234,8 @@ static unsigned int shrink_page_list(struct list_head *page_list, * Try to allocate it some swap space here. * Lazyfree page could be freed directly */ - if (PageAnon(page) && PageSwapBacked(page)) { - if (!PageSwapCache(page)) { + if (PageAnon(page) && PageSwapBacked(page) && + !PageSwapCache(page)) { if (!(sc->gfp_mask & __GFP_IO)) goto keep_locked; if (PageTransHuge(page)) { @@ -1270,7 +1270,6 @@ static unsigned int shrink_page_list(struct list_head *page_list, /* Adding to swap updated mapping */ mapping = page_mapping(page); - } } else if (unlikely(PageTransHuge(page))) { /* Split file THP */ if (split_huge_page_to_list(page, page_list)) -- 2.7.4