From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29667C282D1 for ; Thu, 6 Mar 2025 14:42:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EBC1280003; Thu, 6 Mar 2025 09:42:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29BCD280001; Thu, 6 Mar 2025 09:42:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1165C280003; Thu, 6 Mar 2025 09:42:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB706280001 for ; Thu, 6 Mar 2025 09:42:40 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52723142391 for ; Thu, 6 Mar 2025 14:40:43 +0000 (UTC) X-FDA: 83191387566.25.907F4C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9276E140003 for ; Thu, 6 Mar 2025 14:40:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2kxRx2o; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741272040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pRXqlMTO8KnZMf65hCtbEVZBgewx/3LqEuRqTciOKdg=; b=Zk7eXwkjjdBPmgNNCY9OFoJT1r8qNV9I2kPb1qww+xGCT4np34UOwFSqysCFoOGTp07UEr 1b2HjMVnNamJfzkUdM2A8tV7UCciIBzHmmy3toQpLPpK5Jmo+AVUmeXyacTFBPfYsCNXdp Hy9fTMudYhcLq3cbK1Uznj5sMD8XU50= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2kxRx2o; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741272040; a=rsa-sha256; cv=none; b=ae+CdebL2fRGyglxCx4d1vnll21cKIcrzjaT9azAiYpRqIH+VPuXr4/xctxSRwNWnlMPtL +8ca8F+gk9Ao0RzVtKmzZxfKgS1xTTtNT+HuylhtfF06nEn+pufFIHN3Z5o4VHCQnLKcla /SqD7fNgSO5mOc38VAUzTWMmIvM+uqg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741272039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pRXqlMTO8KnZMf65hCtbEVZBgewx/3LqEuRqTciOKdg=; b=c2kxRx2oXEtQv3/PrCl7+baQ99kjVtukuyqthf2cuE3ARe8n1NcySh5hF4SKz/rdbjC+Vr 43ls5NNtBWV2ecAsSCq4pqUNXXjv30RxHk3D4Hh7JfymzN/yxydgM5rPy4UxuHOCCDwXAc x7rXzA36IfrT19wLfENH2voA+xdHeWw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-dO_uEGvuPGWHgL0YYo5nTQ-1; Thu, 06 Mar 2025 09:40:31 -0500 X-MC-Unique: dO_uEGvuPGWHgL0YYo5nTQ-1 X-Mimecast-MFC-AGG-ID: dO_uEGvuPGWHgL0YYo5nTQ_1741272030 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3911232fd8bso511114f8f.3 for ; Thu, 06 Mar 2025 06:40:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741272030; x=1741876830; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pRXqlMTO8KnZMf65hCtbEVZBgewx/3LqEuRqTciOKdg=; b=kRAleg0K8SM0Xx30HA0UHjp8WOym2DBBY1VEHqWvK6q8NhFw5Ce02HSwOSMtkQkORg SpG7+s5k+dJyYUIwkJp5q5jVOav/ygsixmZIGEm/vnDfeqd9Vy6Vue3I8qC1+9dXYN2/ iPC2y9RqegFI91LWYEyoYrTf0h8bDaAVI2vab+yhfKvmmpEMcnTlLMw2Fg4WArmGNENt HkwXiVAdy7ONIcTY50rRFL/I0/b7VERPKkdmRMKKY6Wds/D2nx+o2KQ155b5uq2MM7fi KXr/8lBnP4TNV2oj8jIwikylmrPLUMH30BBPhTQJa2P7ld+/y8/4qdUVr2rp5CRilfqe 1dOw== X-Forwarded-Encrypted: i=1; AJvYcCUtmclFDuukj2nj0grGXzS1GWdLujWnByq7q7Ya/mMVRwXbUh040jJPGfgiXDal2skEj8B2c+xcuw==@kvack.org X-Gm-Message-State: AOJu0Yx9O8jNEqOJEDyYJ70kE+tV0pUi2Rh7UE3ThvmU47ffS5twusyq R19oX9foqsGe+CnNU/xGFt2eU5VuWIqhzwinlXlNvM1YcnaKfbvs7MxzzMR7orQsJqYh/u7kfiD ex480qu8erzvVAAVQTTbg+bnGv/mVnHVACdj+GHb0qLyegDYP X-Gm-Gg: ASbGncvpgm+2qRpKH7820I9oRseFaTFaMNWGs+jJNaGpMehDu5za7u9nRvZWUb53fm+ ZrV5Im+NZwboYMAv46bHcecZqIFnCJ6mlYOG3en7y3jt5Y3Mna3UWDAMubiGnfXZoJ5es2TrKbj vu5UGZYWqaeIMZQZTCSpPqy+xjVjRnAaxCAoFHgulufU1kXW3iY3WsZuPUNnn5LzKktDStE4e/D pGdqhdGjP8XZc733Sx/FnKum1wWebU155njECrCYAbmj76aIMB+/AZIL4jRVCGBUf/acLBWxyTk mnzRuB7F6wUM/vQW3W2IN2LYjtVcgeDUEwXPxzHxxkWl/aPcpOW7o3SYzTQyF/bUy2VMfZK0ifB SzcxdEL0RdQ3ykfrqZVlkGPgqqPtDfjRI0MfwkBaF1b8= X-Received: by 2002:a5d:47c2:0:b0:38f:2a32:abbb with SMTP id ffacd0b85a97d-3911f714d5dmr5314934f8f.4.1741272030009; Thu, 06 Mar 2025 06:40:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtI9mMXBhwkIi8UD8ii9/+uMbYJ6GObW5v/10syJXLcZpuCccFfu+VuAtQ9RJ18+4Ew3Hd9w== X-Received: by 2002:a5d:47c2:0:b0:38f:2a32:abbb with SMTP id ffacd0b85a97d-3911f714d5dmr5314921f8f.4.1741272029577; Thu, 06 Mar 2025 06:40:29 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:4400:2f98:9b35:6822:ce54? (p200300cbc74d44002f989b356822ce54.dip0.t-ipconnect.de. [2003:cb:c74d:4400:2f98:9b35:6822:ce54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0e2bacsm2239129f8f.78.2025.03.06.06.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 06:40:29 -0800 (PST) Message-ID: <16023193-6cb4-46d1-91c4-43342e7e6d30@redhat.com> Date: Thu, 6 Mar 2025 15:40:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems To: Brendan Jackman Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DqHnr47MQ0YO5AR9M5rVfuZRqFlzUq7fi4qOn16Qr-U_1741272030 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ke53nykqt36r1qeeftrncjnp65qp4ady X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9276E140003 X-Rspam-User: X-HE-Tag: 1741272040-218659 X-HE-Meta: U2FsdGVkX1+uG267GK1b7LujrBBXa5+U8nKYvglF6z4GJl1qH6UYAMUBteOszPOBAJho2fIE/ZYiDPOTKN1VJ14GLOtD9x2QytSbet7fujn+5fB0GlrL6kMk9r+HgnX6FxPL1G8I8VItTVZu+GGDGoB5GC6ys67LFkZAZhOaI/LM9Lz0Feoq67Hiw/AdPeBiyjlY4xMvwxNKr6foJrRHsNidOG+CFWtWJFfLIWtpnNN2VW2W3ddM1adea8qYUJBrTKJivhbGd1i0frr0e0sbKpoiQC2d2w6sRQ/87CFmwFkyKUFw+wPjlvXd7s7zh18OZqN44/KV2Kbj6vqSuCw7Bstw1Fz4mOXOnxBIupPH97P8kLJVDdMm0L2XJ2Sm71fUFRq9GC9wIfNWwXrsq9EoYhZB71Zxs8J2KuKMQMydc0OmUnFGWwHN9RjkNslLvmGy0QFgDfzWYCwm/tjTEfwAUzFSz4WvmLmaukD1BhPeWIB6wcDYt07cQCuJJ2Eh2O9FUIL3ekWk0y19aTE2u4dW//pIajqc8GlzogyNycRIZJ28SP91I+SIMkz1dWDL1R3BUHRFPeif5ptudWa8jaY9daVNuwFK/Xo84uxMH/LaS0IWQKL/eEoHeHhJLZYy9oiifz7BHI3uUU23tM0iFqgeNq8SL+tqNB/gS2tFOfVYyheyxkli7Hbha1n5lur5QV23TANrF00EDDp7GbnmSFpiTPuQ7v7ecMQSZpqRoimAaQmnvhHkklOBF5/q+Ddn4KPqKDDL0eqV0kI9LhSLuRYJzVUqql2bhyCwAmuFktvpsQ3cYsrXMDM4NpwcVHg1ijk7TYpgHcmmzwhrDUl2mYMPZFFwjUZYrYHAtCZBs7pbp5s14vZo6RQb4QFQI/urzkd8GWEkVm+/vXEpYUQPSM+Z58ULJIPlDy991Gn3ryYYE53qYSY8KT+bfpoiEVsAoQBu6mbudR0hKY1zgXGvRwc jMmndhkn 230eBYEw1OCzTVsO5J1xyVbG9O9mn8YQycwlCd0ZXU/wPojGD5NwCb0gE6UGz2nzzCtCTB1eNSHiOfB9NiJjZ33JjiEIBRyUKYLQcJM+nq7uqiHvS8pDI7AeAWTJIaKIJJoSwtaexZEt1MYzycJdha5mMppbPmFWg/fgEmJ4I7Polhl6BJo/BPRWAmuETgBJX/N9fPF8YkN2C5gcDBSAXp7B154NPuK6j2J/I8v3asEJG+V6P39/ONb1Z66lG95KYt0Ud7NITjs4kcEPNVzJaUy2ZLXx6ho8KG7A8l4+qLtOerD85LnZrCOt9F5PZ1KT4BALE9bFndlQkLBshoLSjmeL5zgjorGQYpaqpO0JMM4YGlyywv3nqm1NLSgQNKegYjcyyyLehiYp1VzESZ4dYUgFfARviCqzL0Cz1QcDc4/BsSyQuF0gtK3rx+fCS6L7L/qrBANvO/iLjpxP0+bghQvstZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003229, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.03.25 13:42, Brendan Jackman wrote: > On Thu, Mar 06, 2025 at 10:28:09AM +0100, David Hildenbrand wrote: >> On 28.02.25 17:54, Brendan Jackman wrote: >>> Some filesystems don't support funtract()ing unlinked files. They return >>> ENOENT. In that case, skip the test. >>> >> >> That's not documented in the man page, so is this a bug of these >> filesystems? > Note that I meant that ftruncate doesn't mention this in the man page. The only occurrence is "ENOENT The named file does not exist.", and that only applies to truncate, not ftruncate. > Um... > > unlink(2) does say: > > If the name was the last link to a file but any processes still have > the file open, the file will remain in existence until the last file > descriptor referring to it is closed. > > And POSIX says > > If one or more processes have the file open when the last link is > removed, the link shall be removed before unlink() returns, but the > removal of the file contents shall be postponed until all references > to the file are closed Right, it's supposed to just stay around, it simply cannot be looked up anymore. > I didn't call it a bug in the commit message because my impression was > always that filesystem semantics are broadly determined by vibes. But > looking at the above I do feel more confident that the "unlink isn't > delete" thing is actually a pretty solid expectation. I have a faint recollection that 9pfs is problematic with unlink ... and indeed: https://gitlab.com/qemu-project/qemu/-/issues/103 I'm not sure at this point what's expected to work and what not with 9pfs at this point. > >> What are examples for these weird filesystems? > > My experience of the issue is with 9pfs. broonie reported on #mm that > NFS can display similar issues but I haven't hit it myself. > >> As we have the fstype available, we could instead simply reject more >> filesystems earlier. See fs_is_unknown(). > > Oh. I didn't know this was so easy, I thought that checking the > filesystem type would require some awful walk to find the mountpoint > and join it against the mount list. (Now I think about it, I should > have recorded this rationale in the commit message, so you could > easily see my bogus reasoning). > > If there's a syscall to just say "what FS is this file on please?" > we should just do that and explicitly denylist the systems that are > known to have issues. I will just do 9pfs for now. Maybe we can log > warning if the error shows up on systems that aren't listed, then if > someone does run into it on NFS they should get a strong clue about > what the problem is. Yes, just skip 9pfs early, and mention in the commit message that 9pfs has a history of being probematic with "use-after-unlink", maybe mentioning the discussion I linked above. Maybe something like this would work? diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a614..349e40d3979f2 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -47,6 +47,16 @@ static __fsword_t get_fs_type(int fd) return ret ? 0 : fs.f_type; } +static bool fs_is_problematic(__fsword_t fs_type) +{ + switch (fs_type) { + case V9FS_MAGIC: + return false; + default: + return true; + } +} + static bool fs_is_unknown(__fsword_t fs_type) { /* @@ -95,6 +105,11 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) char *mem; int ret; + if (fs_is_problematic(fs_type)) { + ksft_test_result_skip("problematic fs\n"); + return; + } + if (ftruncate(fd, size)) { ksft_test_result_fail("ftruncate() failed\n"); return; I am not 100% sure if V9FS_MAGIC is what we should be using? "man fstatfs" lists most magic values. -- Cheers, David / dhildenb