From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E6EC4332F for ; Fri, 3 Nov 2023 12:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6F4428001A; Fri, 3 Nov 2023 08:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1E4E28000F; Fri, 3 Nov 2023 08:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897F528001A; Fri, 3 Nov 2023 08:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 784BF28000F for ; Fri, 3 Nov 2023 08:59:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 49DB21204F7 for ; Fri, 3 Nov 2023 12:59:39 +0000 (UTC) X-FDA: 81416649678.13.00D6250 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id F1A72140006 for ; Fri, 3 Nov 2023 12:59:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IgXg0B8o; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699016376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qGvxE1TdNLz4iTVDTpQ4IJBdvLBoFmJbY/H0N64mqPQ=; b=1X1aYyes9nHAnjVoKa3UFXI0PL+LK8HIgoO4alC+ndWF5CtD7L9bzjm76EVMnypKZBliOM GzHBkyiHkH4WOYQKbHGkg3jcdb3wvBDN1ehUCCKKQeTKORkEiKyYdKpz0gNln14xQ5Mq6u SCYagYbDwsNtwru+TgyPjVgWpxkkbFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699016376; a=rsa-sha256; cv=none; b=NFMfFNRDdqeJli9RJj6Sqr66+RaXhuDyUaMxnwhMfmUfbGjtSnqURg+JH5yaKoS4EKCgus +61n/o3qdPEA56q0CGkSXZmp8LMzb9ouSupwCYpRmquPCWUbK6Lz9xgcwpB8Hg14ycmBjG fvZZgcAkFuNmCXJoMpKiGX1yuCsBJas= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IgXg0B8o; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699016375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qGvxE1TdNLz4iTVDTpQ4IJBdvLBoFmJbY/H0N64mqPQ=; b=IgXg0B8oDfTzYG6mpzijzNBni+/vfc1D+xkvoo2V5P6vLiNlr4ENTdkxkffrwUJpOVX1z/ /4nuOYAlt/gMueJiz56IDrluliK9tZBZRIGHokBp8zo3dP42O7Uzo/z8TYygQuAqbiL+iS GUrQajZcuOZasEL4t1TyaQpjSaKM7w4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-g6RN0oO_N929_OPphEMdiA-1; Fri, 03 Nov 2023 08:59:31 -0400 X-MC-Unique: g6RN0oO_N929_OPphEMdiA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40853e14f16so13173175e9.1 for ; Fri, 03 Nov 2023 05:59:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699016370; x=1699621170; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qGvxE1TdNLz4iTVDTpQ4IJBdvLBoFmJbY/H0N64mqPQ=; b=OrvKnAHfpDoNomC6s0eMK19bHvLu0n8D0B8iIEMprHS0sLWTyBdPz+JcJ3REQEwdZX ii4PfD6J94usooo1dQhPu/8ZOIpZ+7BWkkKEoovR1GsDdQU/tLHaBMljTtwfVKsnqODa 8QY6iJVCoZzELbE62DcsbBCV2BLAY4qIhUg0K87fia8JRqdDyDKPMfa56SnHsylvorYu Zo9C65IBoFWgJScaeZEs1JmDglcLUf5uTuZ5b4Nlu8hJk9EDLzwrgYT/562dAHnnYtLa p9pKIHWk9qTkIM4cau/WS7LhYNsVhYJZjaC5GbMBoQBlpde9KcF3F6JTYnjlLZfWFzXw LvLQ== X-Gm-Message-State: AOJu0Yzdj43gjD5yyUkGNaph/lMoqv/I+e1k73wqb+lFqmGq2cA97eeO la61LvH+OQCt7Afd+3xYB5yP6Q261CKHOiKtPQ2cTxUCUEqpxEXWp+nIkN3G3SIj07+1dRppNte YVHrSlCOwV8c= X-Received: by 2002:adf:d1ed:0:b0:32f:810e:8a3f with SMTP id g13-20020adfd1ed000000b0032f810e8a3fmr16714951wrd.14.1699016370651; Fri, 03 Nov 2023 05:59:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyBS6Z00CC8vwD2VjTJLhG+y55gMeontkOP+IPGK1FAnt0REikOBq2K+D/yLhaFXGK4BHSoA== X-Received: by 2002:adf:d1ed:0:b0:32f:810e:8a3f with SMTP id g13-20020adfd1ed000000b0032f810e8a3fmr16714925wrd.14.1699016370211; Fri, 03 Nov 2023 05:59:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:a600:bc48:cd31:d01f:f468? (p200300cbc70aa600bc48cd31d01ff468.dip0.t-ipconnect.de. [2003:cb:c70a:a600:bc48:cd31:d01f:f468]) by smtp.gmail.com with ESMTPSA id j5-20020adfe505000000b0031fd849e797sm1398010wrm.105.2023.11.03.05.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Nov 2023 05:59:29 -0700 (PDT) Message-ID: <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com> Date: Fri, 3 Nov 2023 13:59:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built To: Peter Zijlstra Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> <20231103124606.GB8262@noisy.programming.kicks-ass.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231103124606.GB8262@noisy.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fhckxpt9k67hrheido5os8mc63y9ohmu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F1A72140006 X-Rspam-User: X-HE-Tag: 1699016375-926561 X-HE-Meta: U2FsdGVkX19ov0RE92vAIDbSpz2EJe068zWaRFCAhlzk6bEg1AA1TyD+5TgKHbOVv8qVVL6F+vqyA3d3BeqRPTLpDlemNwebxBTiJcXt5W0s/+YDOVHmhILgSEOoc7iTODNDag806UHooRe2xh12JblwArnDp6gn7s4Z343iXy218Th68+L8Mb+mbE7Y3yEwhA2ex752A6511+K8LUAQ1AkHhOwvwThW00+wqycjTuthOgP2fUQhbf0jrwOVA44Bw/yzzzuouSYAjGfCCFbk7AXybHOXIespJ0zeBIFkI+hou/6D4epSZ6fZPK50TZG5OwMnuQtBr4Y8wz8njDrLxNt8HCh6hXMYpEyiFd9/WX4+nSgKIX0oXPOcJmHLFAi1OtByH2y+VKc3C2ZsnM6smmmNpRROOnd/sAzoonxiPxUxkjnr3CrjH3M4BSfM3Y9V5jofNptuwFcPutaw7BaHa+ijiXUh/NZtw7103qHya3w6wBht8C/zJr84SUBmkdUthVvOkYtwItT+Z2a+4Z7Ym52kupvZYo75uXUL4bU2KYe/gkNijOT+8MLdDIoFqv57OfpZR82385nypKFUTVK6eHVHdBWcOBBAVjL7xLC/Ig8szEw5tLb9lEluEAIriZuvVwUI1044zlH386gAaQgLeOouXUjL0EW38HCRropd0okgE7TB/8sP0LP641/JJIF9kwjIXtC+wnhUefsIUqa55h7fmrXTgwonhaI60CDw0BeLUfgCwHQo0i9kp6BK27r/ErG68hvVZ8vAakOOGFPsrgWGKD1TuUk3fx7S2bkgDs8Dn1QXJobFcAMUWJPy/vIF09xQUIzLiUZ7apyqQyXczkVQglK1tfos8kbgMzDHex+V52qJJO2hUijZrqW/EOWiQ7mrqlYIHv9sTAwO57l1uLzw0L7CS4j4Z3d1/P4s+pF55lzVoFTFOexaNP9tif3i3EflRl5FZk5yiV3kxSf QCL6/iz3 7hfckf0Nb4rBkbtqK4XiQ3i4ht5qU4uFbhCfb7Fk3BU/NRSN6ba0tPRIc9eNSiqZgZKzNDzp7Jzk3XTMivx4wOq8sFYJNZf/tcUCATf4LQf59taPyryBFQd/poOXLbEczxB5nNrmhvk549QHJwzut/Ec3v3C1DjZOYbyWqrRLgNiFABm3lYpPKPFpUBOZgdHyEck0RMgvQUQF2JDfgpmax/Ki5Zq1QbQ4WeOLMmMCdg8UwMhF1IkdaTE8JJNJct8rCnt9ksoR8BCw83qTiW+Oj1IO7Sqam59RBDD2lmY8sOl9QwQZZPKWv2ytyK16RrX0RSBsz5ow1saBIZk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.11.23 13:46, Peter Zijlstra wrote: > On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: >> On 03.11.23 13:16, Peter Zijlstra wrote: >>> On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: >>>> As per a discussion with Muhammad Usama Anjum [1], the following is how >>>> one is supposed to build selftests: >>>> >>>> make headers && make -C tools/testing/selftests/mm >>>> >>>> Change the selftest build system's lib.mk to fail out with a helpful >>>> message if that prerequisite "make headers" has not been done yet. >>>> >>> >>> NAK NAK NAK >>> >>> This now means I can no longer run selftests, I thank you very much! :-/ >>> >>> root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 >>> make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' >>> *** >>> *** The source tree is not clean, please run 'make mrproper' >>> *** in /usr/src/linux-2.6 >>> >>> >>> I've always done: >>> >>> cd tools/testing/selftests/x86; make >>> >>> and that has always worked >>> >>> Now I can't bloody well build *any* selftest or risk not being able to >>> do builds. >> >> This change landed in 6.5, no? And 6.6 was just released. Just curious why >> you notice that now. > > Dunno, last time I edited the selftests and needed to recompile was a > few weeks ago. Okay. the question is if your workflow can be easily adjusted, or if we can improve that header handling as a whole. The problem I had with this recently: just because we did a "make headers" once in a git tree doesn't mean that it is still up-to-date. So once some selftest changes showed up that require newer headers, building the selftests again fails without a hint that another round of "make headers" would be required. -- Cheers, David / dhildenb