From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D775C6FD1C for ; Fri, 24 Mar 2023 03:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8C1F6B0075; Thu, 23 Mar 2023 23:43:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3CE66B0078; Thu, 23 Mar 2023 23:43:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2AD26B007B; Thu, 23 Mar 2023 23:43:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B68926B0075 for ; Thu, 23 Mar 2023 23:43:26 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7EBF9AABF3 for ; Fri, 24 Mar 2023 03:43:25 +0000 (UTC) X-FDA: 80602396770.11.5AD884F Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf15.hostedemail.com (Postfix) with ESMTP id 0299CA000D for ; Fri, 24 Mar 2023 03:43:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679629403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KK3VfphL9l3VIadEUlJuZiUfD9SetqZMav1K56yPxYo=; b=O91hnZ5SJd9O3vC+FOqXdEoV/TCnv5n6lTCPnDbPn3WrY/q01RxCCt7e2pLtDxgU3GjcvE avUZziWveco9n0J5GJ8YI2u7/DxkVfY6cXGsWQe2YJB1ZEZRYCncKsh/mcd80VWE9vAjQO gp65Tr5wUpNRLEjeHPOpWONrA6Hr5mQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679629403; a=rsa-sha256; cv=none; b=YPOortGDf7HBqyRXURL9PLfNeaKHHpqRAf6VQkhADu0XgpBPXITiVNMG91OpdLE6yplqox XrBecv55QsjNOXJyr0UoJwjg5GfWhRqyab9SQQhvZ7EoAJ93sxKgGWq+0bhKJkLkGfuK1M C04zDpAHRDQkIbzepRhbMQLA2Mb7aME= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PjSdh38bJz17Nrg; Fri, 24 Mar 2023 11:40:08 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 11:43:13 +0800 Message-ID: <15f4892c-e0dc-ff37-45a8-a1a025c2d929@huawei.com> Date: Fri, 24 Mar 2023 11:43:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: kfence: fix handling discontiguous page Content-Language: en-US To: Muchun Song , , , , , , , CC: , , References: <20230323025003.94447-1-songmuchun@bytedance.com> From: Kefeng Wang In-Reply-To: <20230323025003.94447-1-songmuchun@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ddrttt9y1xgfyf7k789hhyg5oeut96ng X-Rspamd-Queue-Id: 0299CA000D X-HE-Tag: 1679629401-750543 X-HE-Meta: U2FsdGVkX19j3YHUVsJjI495zkxHhLEyQNa1qluMQPVgWqbMxdto6QlgtDcfm+2qxnJZe5hXE5UrB1cBXIDPNhmkYvIB+geFqd0jffgjxIwaeyTQ8AnGON3BhA5GpMR4VVJm7jf8jd95v0CM0BwWik5XwqsG1YblFpxpW8myPAMggVtuTwuTB9f5RLFpIAaj83pBFs2bYG0IOrs/A+CnyngtG/zZeEQgPZBGnI+RTtaEH2o4poR19086A6uGE/SmUIXF9K9OMyZP3RxrrP4/gHOxIqkVpj0RrEr8uQ0uNg/Bpgpq+DqmNlqOz38z7AG+nEzb4FCYY2OGFcHGQV25GP3Qo2IqOZ/i9+njdZBoLKFhkEx2v2Z0O10FziyK74HaoWuG1Bqv35tvb+yhIU73eomz+Ex54+axCmPkbaTaGMytBsPczf3/3vy411/a6K3/1tRCwu8UFhOdr+IBCD7ZWUo9yuJhJ/m7IDNPG19/NuN0wVqjpzqLyAPnPqPjFMBLg8YGEZ5Aqmhu23F1lk2P6ZZ4U9MOlkUBik5BBhDw5GA5uZ1ayz4TVeYB/D+ZVjZG0f+G330otQlrlQOqy2sjGqY79TcKyyNh3NAwUXYjx+OINTFUVVb7hzjc/4bzgg1tFP1awjvB/GJ2SLrNxqa2wKFlfO9YLjZUClbT1htT6hIRxcZEV2HD18NrMbQIEWApRwegUvo5ovW2Kb2Md+Itf4M0LQqluprUw1VQIrdYEaUDJpF58IJF9W+6JMxLsUYeCn8FIzwlYD1l//f1bThBfTJl33PA5mecYNAC6m1IoZU+WgRac4lMAaAeB6fFMc/tEzgxUXPaMn9BWweJzvfEXjZuxvRWYDgqARiT1RwJVV8omuCZI/yc5mGdzWEnpCZOUCMSUfTROncLOqTYtlquHdM8ykDk5V5fLVRwfDFMY9ZxPE2dxS2L+47U4uaA2BHiPbwexEstrMUToO0cK38 IICKLNPB BGbk+vefaO4158fHm88NALMylxvZuA656Zs8DIsU44fXAtspQj2s7lhZ8AfwZolypRWMJzD0GRZIwtLvxTDKRy0BXDcAjRMrDRyiQFTnFgFlnFr4pMsfqJo8T/7ZVLu8fdv1R5a8diyRFozm43dJcbCOkiMDkEnhgSq0BnkUOHnMRTVBfriLrDhUdL9RpYaHZr8TORMh1J9qHEflwf4at72fmoVwrzYRbOcNqElN21T0nYHU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/23 10:50, Muchun Song wrote: > The struct pages could be discontiguous when the kfence pool is allocated > via alloc_contig_pages() with CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP. > So, the iteration should use nth_page(). > Reviewed-by: Kefeng Wang > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") > Signed-off-by: Muchun Song > --- > mm/kfence/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index d66092dd187c..1065e0568d05 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -556,7 +556,7 @@ static unsigned long kfence_init_pool(void) > * enters __slab_free() slow-path. > */ > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(&pages[i]); > + struct slab *slab = page_slab(nth_page(pages, i)); > > if (!i || (i % 2)) > continue; > @@ -602,7 +602,7 @@ static unsigned long kfence_init_pool(void) > > reset_slab: > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(&pages[i]); > + struct slab *slab = page_slab(nth_page(pages, i)); > > if (!i || (i % 2)) > continue;