From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D802DCD13CF for ; Mon, 2 Sep 2024 13:33:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57E2C6B00D5; Mon, 2 Sep 2024 09:33:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52CC66B00D7; Mon, 2 Sep 2024 09:33:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CD7E8D0098; Mon, 2 Sep 2024 09:33:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E2E16B00D5 for ; Mon, 2 Sep 2024 09:33:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8526E141CB4 for ; Mon, 2 Sep 2024 13:33:19 +0000 (UTC) X-FDA: 82519889718.30.5F453A0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 24A5040005 for ; Mon, 2 Sep 2024 13:33:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q8NcdWpL; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725283872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BatJX0UrZrv0JixsK5bHxW6Hou59a+F6YK/s6g/HXTs=; b=wYixpi9Xe/l99ccGi5uqMkDhJcqCQjZMCumZ4nY9c/wYUAs/idh0ZEk9P+peYt9Eqy0k2M H711UIT06tZsnlhdbRi2y5OChW6AidYaxNoICAYb6D+vGT9mSBI0ID46b67QTBS+6hHfbl wALggpR0avH1Ii1EjL20Z4NzHPczMDk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q8NcdWpL; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725283872; a=rsa-sha256; cv=none; b=NuV/xdDi4HcF8sVD2pdGJgq/wiILxSYbUmUPHP6j1VxfM1PJ8yBsABPCLJWiXkWAWrGG7x e/f1OLOqDorK7NdPAX4IWlVhI8DvUT/fu4Agr8NEPXzMPYMVBguK4K5q7VkUfsb6l4P1z3 9qqBir3moJjaoUv0RpFxQL12BXK12Z4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725283996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BatJX0UrZrv0JixsK5bHxW6Hou59a+F6YK/s6g/HXTs=; b=Q8NcdWpLxz+huS8aUVtRwPzkQapAC8lk5s8pBUYxJNHX/ZbhF/j+5mg1NG4jDyjnotYBlh Kh5eTRakAWKCdUtDGDKJqf8bFa23ZxSTi9zJZtQ3GWTprgMuDACD+T0HTDpEh4KmyOwRmt ZJWYZL9YdABW0Oc9VH94AhzDZFg2vvg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-ZnFdiKBgPQy56nClBmWFxQ-1; Mon, 02 Sep 2024 09:33:15 -0400 X-MC-Unique: ZnFdiKBgPQy56nClBmWFxQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42bb9fa67d7so39247335e9.0 for ; Mon, 02 Sep 2024 06:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725283994; x=1725888794; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BatJX0UrZrv0JixsK5bHxW6Hou59a+F6YK/s6g/HXTs=; b=v0qQvQS7JyWT28w4lSmFSXS6aNgH1K7w4vx9t3OLS0ZtjrY5LFUUpQWNThgcFIK3Le UZG6Hey2/UNguoaKo0jhtfMpha0UhRPrPSWTm+AyDlGtrvqUVKQmKZagQudwWRch3HVU LKdv14tHhAygLZI121JA8kvwwiT8n7kLGFX1FeyfTQ9afIBS1JuhEO/56y/F5ZYD9JPJ VR8qjw5TtGK5uF+XhpCad92sU24K0f6X5il8V13bCRIfLaZFowg9WcePkGHiMVksCIS0 QwioShBtiPL1JiVoDVx/IfhzFkdkTRUsZUwS1Ru0v0FdgOLL3jhlmFdOX1FgW2jxzrnO 2QAg== X-Forwarded-Encrypted: i=1; AJvYcCU7yGkBTLX8N2WjF9BKHzTenWnVUrbYDKilYFyKuiknw9ExpR/jzP9sFoBvE+/eNuGGw4Btrbwm5A==@kvack.org X-Gm-Message-State: AOJu0YzOS3aQlswIgmDcQWubHpTI71pmmR8DSAkpsMr4dohY3ST6WGCA aekZKuv1znl8goQQbTdFaGeh8jrDzRodhIP7jn2kMOyTHBztmbt7Y6HfBi8vr8ulioeAwbUsoUi vfBtYR+0wXq3oBP46WAu0K42TDnDDNp+iZvBjFk0vn2zkK7Fw X-Received: by 2002:a05:600c:4512:b0:426:5e8e:aa48 with SMTP id 5b1f17b1804b1-42bb01c1ff9mr131513855e9.22.1725283993918; Mon, 02 Sep 2024 06:33:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyRPmzpxcMqfNupV7IiaUohULHAhvhx0y6pDhqULdWQA+ozHPmnZsnbRmineAjrj+cCGVwQQ== X-Received: by 2002:a05:600c:4512:b0:426:5e8e:aa48 with SMTP id 5b1f17b1804b1-42bb01c1ff9mr131513345e9.22.1725283993008; Mon, 02 Sep 2024 06:33:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bba3f2875sm117904625e9.41.2024.09.02.06.33.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 06:33:12 -0700 (PDT) Message-ID: <15f31ce4-6e41-4444-963b-77c9bea33b86@redhat.com> Date: Mon, 2 Sep 2024 15:33:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: control mthp per process/cgroup To: Baolin Wang , Nanyong Sun , Matthew Wilcox Cc: hughd@google.com, akpm@linux-foundation.org, ryan.roberts@arm.com, baohua@kernel.org, ioworker0@gmail.com, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240816091327.54183-1-sunnanyong@huawei.com> <3ac1e404-a531-a380-7a2f-6adae4640da6@huawei.com> <2cfb4e1a-d9be-47ab-b92d-94cd65bfec43@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2cfb4e1a-d9be-47ab-b92d-94cd65bfec43@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 24A5040005 X-Stat-Signature: 9mba7npuw7atj6wkpoz1jgf419ng77wt X-Rspam-User: X-HE-Tag: 1725283996-441696 X-HE-Meta: U2FsdGVkX1+x2I5Z+QzrS6m+U1Dn3CnDRQ9dBcZ3MlVvBYSx8V+LKGHT3ozVoRfpRQaoTld1Ko8G5xv0I5Emg4Bfe/HlY9Hr1kmf1vZWhmyihlW1AEhAGKzSF1ThkESKFDr4l0HRJrVz9FklMojXfXIc2Pra82YdqSNUeUvRCf7e+2BCne+go1RYwwmhJPu6SUkjGOmBWXA+rYhXSdoTXUQtAB4eVO8qgleTCdK7pXpzUTSXBfzNhRwQGKytS7Q4mPrmETCwlmgXrcHYzZrwQ7E8+IOQ4Zi0RFLtvcP2nk8RgTUxmM/r2r40/jbFafRlepGTgkpTDpIuKAa5yR05ph7h8Gf/XNQIOuiGCk1fgV6FImxm5gaqZo13ZTtxUIeaWl0fdjlGmbEXpkHSxSFnkCVC4VcJEUGTJN8rIoVskqPUz4AWMnYj+C5K1YO3jN5Z+JS3GSeXXVMpCPdgESZpSofVRYCIIu0K3zyEroofpBRCbQkhs7sTdlgzTVJ3YClLt/ksYc+9xu56RtQ0swFfELkmQeIcmoMEyNLGl5I+ehkwuPb7+rcA8+RUasZSkP/hZGQ6Qye6+rtI+wmANy30HY7q9gb2Ld3a/59bcRe452biwp+7Z73NnKynF4fPAfgo3C8w/FdbwGUxLzfV34xpYtQGQpoKnzJWqNyDLYGPlDDnVH/yB6S4L0IM6LoLL/zxMpdyhsXY8f8kkSi4pWOEENkUbVVFGstiu+O2gXFgoaYDfJKJIpC9KWAMBxnsgE7kPh1+IuEVubPm4vqURFJAbQ6CsgffqnZn0frn3hVZMpEOVntUlVoka/kDeZmoUqRNlCSCtwFzvlmkGkvVMrAT6sXJ7QG4Jm31B6X1zon0Df89o0M5/iISUTno57I9l+1WzBCTZQ5F0bc3Tw3KC+eE93owgKXEV08daZdOQljrfl3lnISEmPFJW+fG1vA43iQOE8P0TOI0b1Nv8iWB++p 43pb8OC0 jJhQgQc7jHpp77Idqgy7eKkmlAWa5RD3A8NM45BCXAwgZkJpUADNglBeu8O0i5wjxneEK2jKEGAj5ufutGW16czaD/jCO8z+Mk42V0OhTzWVH5QjzHX6a3yn2iPUOHKuqmRpwiOHx+Vrn5RY/xfdYHP/0uyoCECmW0VGFQohIdbuCGYDtdnUBWBEPBJdLV6XzI3T+evAgmfr0alJ6/XSnvuqGz1dq1m6OJjLXQcYrhxCsls8N5oBvioe6DJXmI695mQhD2QWm2G0C0O1Pgd0C0crriNHQFcqocZtaeCb6pFxmKOV7xEKAoY70S3LnO2tMd6wNPc0OPAD+PrQCsfBsNC3NaB7K8xB9kYp+gibkw5CCBtx7wAUC2qTweNtg4ZnfYVrbRmZZ2EYNrNQdnSfm8pvs83b9jF9Lla6aaaIR+hjN95wkNlxx2DGa+0ng6QQ0dVN5yEu7X055pRJ4lFkzC+65KWK755Yye1yJP/+E+CCCMIs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.09.24 11:36, Baolin Wang wrote: > > > On 2024/8/19 13:58, Nanyong Sun wrote: >> On 2024/8/17 2:15, Matthew Wilcox wrote: >> >>> On Fri, Aug 16, 2024 at 05:13:27PM +0800, Nanyong Sun wrote: >>>> Now the large folio control interfaces is system wide and tend to be >>>> default on: file systems use large folio by default if supported, >>>> mTHP is tend to default enable when boot [1]. >>>> When large folio enabled, some workloads have performance benefit, >>>> but some may not and some side effects can happen: the memory usage >>>> may increase, direct reclaim maybe more frequently because of more >>>> large order allocations, result in cpu usage also increases. We observed >>>> this on a product environment which run nginx, the pgscan_direct count >>>> increased a lot than before, can reach to 3000 times per second, and >>>> disable file large folio can fix this. >>> Can you share any details of your nginx workload that shows a regression? >>> The heuristics for allocating large folios are completely untuned, so >>> having data for a workload which performs better with small folios is >>> very valuable. >>> >>> . >> The RPS(/Requests per second/) which is the performance metric of nginx >> workload has no >> regression(also no improvement)，we just observed that  pgscan_direct >> rate is much higher >> with large folio. >> So far, we have tested some workloads' benchmark, some did not have >> performance improvement >> but also did not have regression. >> In a production environment, different workloads may be deployed on a >> machine. Therefore, >> do we need to add a process/cgroup level control to prevent workloads >> that will not have >> performance improvement from using mTHP? In this way, the memory >> overhead and direct reclaim >> caused by mTHP can be avoided for those process/cgroup. > > OK. So no regression with mTHP, seems just some theoretical analysis. > > IMHO, it would be better to evaluate your 'per-cgroup mTHP control' idea > on some real workloads, and gather some data to evaluation, which can be > more convincing. Agreed! -- Cheers, David / dhildenb