From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A55C4167B for ; Mon, 28 Mar 2022 12:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 425778D0003; Mon, 28 Mar 2022 08:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AD818D0001; Mon, 28 Mar 2022 08:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 200E28D0003; Mon, 28 Mar 2022 08:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 0E6448D0001 for ; Mon, 28 Mar 2022 08:33:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id D3011121397 for ; Mon, 28 Mar 2022 12:33:50 +0000 (UTC) X-FDA: 79293736620.08.3330317 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 48EFC10003D for ; Mon, 28 Mar 2022 12:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648470829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ROdC7Jw3x8bFNSVJnYtQV9N5qoumVwi1dU/TOVEmlwk=; b=STOjbwaWoZ06IEOjUxndxlTMpVOdUim1KRvpfh1G+ADbdruulr/MUTUmFpVr486qK4U0H+ SiXT31M9yrSKhntKyjLf3XBnRgnshF/kUcwGA2zQKein74i+C/RX/Kj66TlIGX5PGijVv7 oxRGlPF5oDLG25jTOdulNAX6LPMrksc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-278-jzzy9rZUPfmkO3bni-6thA-1; Mon, 28 Mar 2022 08:33:48 -0400 X-MC-Unique: jzzy9rZUPfmkO3bni-6thA-1 Received: by mail-wm1-f70.google.com with SMTP id t124-20020a1c4682000000b0038c8e8f8212so5454903wma.2 for ; Mon, 28 Mar 2022 05:33:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=ROdC7Jw3x8bFNSVJnYtQV9N5qoumVwi1dU/TOVEmlwk=; b=Xbi2PrcwSRUI18bruRhCqX+m0Lqz6Alt6v8ZEqtPF4MpXdxi5rR2QcPPuG1xi7u1cw II/pTWCvXDrd65r9aOLp5C9blDuRWhWwF2N29m/Ium+kEWC5QKGb1611NG6mm9Mq3nlL MasrpyOo2+RQ05tb5ypiTz5crtoh9hFMX0yaJi5JaHqi0qQeJHYTn/tPrDTX9uUS2Qqe d2G2M2wFIoe1DmoTPZgMBXTnWTfQ8NwZGZ5ji8f4WoYJvf90tYVGwYEP74pLJCFlipSE UFOZCSG7elr0iVe02Z6u6WbiPx13nvIKU6zqomGPAG8Y1Xow0Es9F2tMHo+7e/xb+IvT hLJg== X-Gm-Message-State: AOAM530YZUzXb5BfQVP8Fei0yBIxb1wID1Hc5mB9I/VbLOirag1Gffqq AMs6XFE0+awwQ5vEQ5MTA40qs5gF3/YdPxxWn3P5VyiRUH460DP2EV/Gv/tDJYutwDE+FGTRW2N Psi/4OhfTcuU= X-Received: by 2002:a7b:c20b:0:b0:38c:6ed9:f4f with SMTP id x11-20020a7bc20b000000b0038c6ed90f4fmr26635122wmi.131.1648470827365; Mon, 28 Mar 2022 05:33:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhJwZZoG6Q1E+o6y6M1ilGgoNUpfEciP71qUcwMG1+HNmb4HQyx8CnO6u8Jy0aUNhZ3oDjCQ== X-Received: by 2002:a7b:c20b:0:b0:38c:6ed9:f4f with SMTP id x11-20020a7bc20b000000b0038c6ed90f4fmr26635096wmi.131.1648470827144; Mon, 28 Mar 2022 05:33:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:2200:50d1:ff5c:5927:203a? (p200300cbc704220050d1ff5c5927203a.dip0.t-ipconnect.de. [2003:cb:c704:2200:50d1:ff5c:5927:203a]) by smtp.gmail.com with ESMTPSA id a11-20020a5d456b000000b0020406ce0e06sm12047500wrc.94.2022.03.28.05.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 05:33:46 -0700 (PDT) Message-ID: <15e3f11b-1551-a9c2-c348-bbe1ae1d9ef7@redhat.com> Date: Mon, 28 Mar 2022 14:33:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 7/9] mm: Calc the right pfn if page size is not 4K To: Wupeng Ma , akpm@linux-foundation.org, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net Cc: ardb@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zyccr.com, dvhart@infradead.org, andy@infradead.org, rppt@kernel.org, paulmck@kernel.org, peterz@infradead.org, jroedel@suse.de, songmuchun@bytedance.com, macro@orcam.me.uk, frederic@kernel.org, W_Armin@gmx.de, john.garry@huawei.com, seanjc@google.com, tsbogend@alpha.franken.de, anshuman.khandual@arm.com, chenhuacai@kernel.org, gpiccoli@igalia.com, mark.rutland@arm.com, wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org References: <20220326064632.131637-1-mawupeng1@huawei.com> <20220326064632.131637-8-mawupeng1@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220326064632.131637-8-mawupeng1@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=STOjbwaW; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 48EFC10003D X-Stat-Signature: p1gd4ypmze8miigc1n31uzzspqirgc68 X-HE-Tag: 1648470830-59659 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.03.22 07:46, Wupeng Ma wrote: > From: Ma Wupeng > > Pervious 0x100000 is used to check the 4G limit in s/Pervious/Previous/ > find_zone_movable_pfns_for_nodes(). This is right in x86 because > the page size can only be 4K. But 16K and 64K are available in > arm64. So replate it with SIZE_4G >> PAGE_SHIFT. s/replate/replace/ > > Signed-off-by: Ma Wupeng > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6e0b4596cde9..41fd987b5b93 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7811,7 +7811,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > usable_startpfn = memblock_region_memory_base_pfn(r); > > - if (usable_startpfn < 0x100000) { > + if (usable_startpfn < (SZ_4G >> PAGE_SHIFT)) { PHYS_PFN(SZ_4G) ? > mem_below_4gb_not_mirrored = true; > continue; > } -- Thanks, David / dhildenb