From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Dev Jain <dev.jain@arm.com>
Cc: akpm@linux-foundation.org, axelrasmussen@google.com,
yuanchu@google.com, weixugc@google.com, david@kernel.org,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, riel@surriel.com,
harry.yoo@oracle.com, jannh@google.com, ryan.roberts@arm.com,
baohua@kernel.org, baolin.wang@linux.alibaba.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-unstable] mm: Fix uffd-wp bit loss when batching file folio unmapping
Date: Fri, 16 Jan 2026 09:48:55 +0000 [thread overview]
Message-ID: <15e2a0d8-e8f1-488c-8fce-c0a2a5182086@lucifer.local> (raw)
In-Reply-To: <4b784eef-e874-45a6-828a-4fc2acab6fb7@arm.com>
On Fri, Jan 16, 2026 at 03:10:23PM +0530, Dev Jain wrote:
>
> On 16/01/26 2:09 pm, Lorenzo Stoakes wrote:
> I saw that the last comment on that series was more than a week back, so best
> thought to just do a folded fix on top of it - and I had formed the impression
> (from the conversations on list) that akpm prefers fixes over respins : )
>
> If a respin is preferred here then I am fine by that.
>
Generally we prefer fix-patches, sent in reply to the patch being altered and
sent by the series author.
Sending a patch with a Fixes: tag is never the correct way to fixup a patch
unless they're upstream or unchangeably-bound-for-upstream with a commit hash
that will be the same in Linus's tree.
You can by all means suggest a patch to an author by replying to the broken
patch, but then it's up to them whether to take it. Also then the courteous way
is to raise the issue in that reply and say something like 'it seems that the
below fixes the issue, can you check it?' or something like this.
But the correct course is to the respond to the series in all cases like this.
Thanks, Lorenzo
next prev parent reply other threads:[~2026-01-16 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 8:27 Dev Jain
2026-01-16 8:39 ` Lorenzo Stoakes
2026-01-16 9:40 ` Dev Jain
2026-01-16 9:48 ` Lorenzo Stoakes [this message]
2026-01-16 9:54 ` Dev Jain
2026-01-16 10:51 ` David Hildenbrand (Red Hat)
2026-01-17 17:46 ` Andrew Morton
2026-01-16 10:57 ` David Hildenbrand (Red Hat)
2026-01-16 11:12 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e2a0d8-e8f1-488c-8fce-c0a2a5182086@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=harry.yoo@oracle.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox