From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by kanga.kvack.org (Postfix) with ESMTP id 6C6666B0036 for ; Wed, 5 Feb 2014 13:39:38 -0500 (EST) Received: by mail-lb0-f176.google.com with SMTP id w7so640417lbi.35 for ; Wed, 05 Feb 2014 10:39:37 -0800 (PST) Received: from relay.parallels.com (relay.parallels.com. [195.214.232.42]) by mx.google.com with ESMTPS id z4si15543876lal.29.2014.02.05.10.39.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2014 10:39:35 -0800 (PST) From: Vladimir Davydov Subject: [PATCH -mm v15 04/13] memcg: make for_each_mem_cgroup macros public Date: Wed, 5 Feb 2014 22:39:20 +0400 Message-ID: <15dc781adf9407f415480726cce1fe27e8600a37.1391624021.git.vdavydov@parallels.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: dchinner@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org, glommer@gmail.com, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, devel@openvz.org, Glauber Costa , Balbir Singh , KAMEZAWA Hiroyuki I am going to use these macros in next patches, so let's move them to the header. These macros are very handy and they depend only on mem_cgroup_iter(), which is already public, so I guess it's worth it. Signed-off-by: Vladimir Davydov Cc: Glauber Costa Cc: Michal Hocko Cc: Johannes Weiner Cc: Balbir Singh Cc: KAMEZAWA Hiroyuki --- include/linux/memcontrol.h | 15 +++++++++++++++ mm/memcontrol.c | 15 --------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index abd0113b6620..0503b59c3fad 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -53,6 +53,21 @@ struct mem_cgroup_reclaim_cookie { unsigned int generation; }; +/* + * Iteration constructs for visiting all cgroups (under a tree). If + * loops are exited prematurely (break), mem_cgroup_iter_break() must + * be used for reference counting. + */ +#define for_each_mem_cgroup_tree(iter, root) \ + for (iter = mem_cgroup_iter(root, NULL, NULL); \ + iter != NULL; \ + iter = mem_cgroup_iter(root, iter, NULL)) + +#define for_each_mem_cgroup(iter) \ + for (iter = mem_cgroup_iter(NULL, NULL, NULL); \ + iter != NULL; \ + iter = mem_cgroup_iter(NULL, iter, NULL)) + #ifdef CONFIG_MEMCG /* * All "charge" functions with gfp_mask should use GFP_KERNEL or diff --git a/mm/memcontrol.c b/mm/memcontrol.c index deb5b9bb6188..854d0b8e3c45 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1297,21 +1297,6 @@ void mem_cgroup_iter_break(struct mem_cgroup *root, css_put(&prev->css); } -/* - * Iteration constructs for visiting all cgroups (under a tree). If - * loops are exited prematurely (break), mem_cgroup_iter_break() must - * be used for reference counting. - */ -#define for_each_mem_cgroup_tree(iter, root) \ - for (iter = mem_cgroup_iter(root, NULL, NULL); \ - iter != NULL; \ - iter = mem_cgroup_iter(root, iter, NULL)) - -#define for_each_mem_cgroup(iter) \ - for (iter = mem_cgroup_iter(NULL, NULL, NULL); \ - iter != NULL; \ - iter = mem_cgroup_iter(NULL, iter, NULL)) - void __mem_cgroup_count_vm_event(struct mm_struct *mm, enum vm_event_item idx) { struct mem_cgroup *memcg; -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org