From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCE0C433ED for ; Thu, 15 Apr 2021 17:41:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A04F613CB for ; Thu, 15 Apr 2021 17:41:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A04F613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A82E6B0036; Thu, 15 Apr 2021 13:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 533656B006C; Thu, 15 Apr 2021 13:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 366956B0070; Thu, 15 Apr 2021 13:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 1318C6B0036 for ; Thu, 15 Apr 2021 13:41:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C76615DDB for ; Thu, 15 Apr 2021 17:41:13 +0000 (UTC) X-FDA: 78035317626.17.7E76623 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id A093DE00010B for ; Thu, 15 Apr 2021 17:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618508472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wTimRIr0YgBuVLpWvKPM6c0MAPH0f+KQspjahIIUAlU=; b=en6naG7yeDtrwaR7ZZtFnUr+R6hn2DYzZYKFQ1N6sMFVCFiTrezUcTPLQX9AofpGy139BU isWujQzf79Z4SDD2KO7GPc8xxPDE3oE4hBXvzzJnWPxA3ZTXiRnypMMWhOYx6r5iFz5WNq UuskcrBhYHRomFB098eZOmAOmiJmtFs= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-WTkXxM1jNliykblINzsipQ-1; Thu, 15 Apr 2021 13:41:10 -0400 X-MC-Unique: WTkXxM1jNliykblINzsipQ-1 Received: by mail-qt1-f197.google.com with SMTP id w21-20020ac871950000b02901b1a8294c46so508840qto.7 for ; Thu, 15 Apr 2021 10:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wTimRIr0YgBuVLpWvKPM6c0MAPH0f+KQspjahIIUAlU=; b=PM0EbWxTd78dnDhqi3hpOuxUdd9/KnP3eJBc9YCZoyPlxUdXccRdmdgo0jhnUlqAg4 w/rUfRHJXDIp9WdkaqpJFEcAopsDYMMdSIgQ8Ic/LYk5QwIXTERlKOEbBumMvB7kLYwT 7aDzvJPrWmnzPRXqUEL7I3LdiyQ4HC+0A8IEAZTiZxhAF6MfNIB30oxVGEZBKGJMpm7w Y6ltw73xPGNvfu9CotoVlmDcNhmJD4mJThriOoC8yYYqBydLiJplEjDqOJlr/cDeKpnS qTFuF3BiqjvV/BHM4TrFMmLVCcwHaBZlpJ5aSaAfwLBzfYQt7UQl07aoIxhodxfeDK7a WxvQ== X-Gm-Message-State: AOAM530O6Dwt7h576SpBk5SC+jGWe6Yod7LHuC49CVpTCDzfH6XOo6Fo Rz6aigm7DsNLxr85C+k0Chqp6mSXeZ8tvS1G1l71i43d4IIaqzMwSupoOuu5XO6DMVL7KhZwJmX fGLlJQexTAEA= X-Received: by 2002:a37:7c5:: with SMTP id 188mr4791831qkh.348.1618508469964; Thu, 15 Apr 2021 10:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmgbFnszT76GybNyzgAt7zTaWK3t49+b+KRVvGIM0rKdDofO0Sm6ySwTeX6EQ7djs0OMFxww== X-Received: by 2002:a37:7c5:: with SMTP id 188mr4791794qkh.348.1618508469626; Thu, 15 Apr 2021 10:41:09 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id x18sm2247420qtj.58.2021.04.15.10.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 10:41:09 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead To: Matthew Wilcox Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun References: <20210414012027.5352-1-longman@redhat.com> <20210415171035.GB2531743@casper.infradead.org> Message-ID: <15cf3cfa-c221-9e84-9f5b-80082207efd3@redhat.com> Date: Thu, 15 Apr 2021 13:41:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210415171035.GB2531743@casper.infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=llong@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A093DE00010B X-Stat-Signature: yaaf5z7z8gc3yccr5ky4my6jomp7uxpt Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618508472-975838 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/15/21 1:10 PM, Matthew Wilcox wrote: > On Tue, Apr 13, 2021 at 09:20:22PM -0400, Waiman Long wrote: >> With memory accounting disable, the run time was 2.848s. With memory >> accounting enabled, the run times with the application of various >> patches in the patchset were: >> >> Applied patches Run time Accounting overhead Overhead %age >> --------------- -------- ------------------- ------------- >> None 10.800s 7.952s 100.0% >> 1-2 9.140s 6.292s 79.1% >> 1-3 7.641s 4.793s 60.3% >> 1-5 6.801s 3.953s 49.7% > I think this is a misleading way to report the overhead. I would have said: > > 10.800s 7.952s 279.2% > 9.140s 6.292s 220.9% > 7.641s 4.793s 168.3% > 6.801s 3.953s 138.8% > What I want to emphasize is the reduction in the accounting overhead part of execution time. Your percentage used the accounting disable time as the denominator. I think both are valid, I will be more clear about that in my version of the patch. Thanks, Longman