From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57CEC282EC for ; Fri, 14 Mar 2025 12:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA9BC280002; Fri, 14 Mar 2025 08:11:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C31C8280001; Fri, 14 Mar 2025 08:11:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86D2280002; Fri, 14 Mar 2025 08:11:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87661280001 for ; Fri, 14 Mar 2025 08:11:13 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AA753120FCA for ; Fri, 14 Mar 2025 12:11:14 +0000 (UTC) X-FDA: 83220041268.10.BEA15AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id BC8E4180014 for ; Fri, 14 Mar 2025 12:10:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dFReOsjM; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741954253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N+W7JLYSi3FHd5wiExWEG1bnYG61jBb9yzI4idWzEYc=; b=edU3jsIwtbqcOAoMM1g9KBPXOjxfNwNHwqZcU8KTFQw/V/Fum1q9fwHsJSgasrrq+5cNhs 21T5FFSYFbLZ3LeAcuHQY5VUp/KWIUzuuJTnbfsm6j9J9WdgbLOgV5hzm/8ry8Z0lS/v2/ Io3Ahc5oU5RjB/BBu5v4tTHubW1j08A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741954254; a=rsa-sha256; cv=none; b=fOfNNF3de+2ZBCDrR72Iw27hb8SyNMyzBtmxxhyO2wZWOx7aj6cFzM6/YcmRvOK1C2SGyO s+/Vj+siSt7xlCKEWx8pAhmZ2Mafp9Tpa1Tw88KNl9BmS0bToUKHeTYDT6tCQsYZAVlD6u SwXBB9P/tp0O+JjLxt+Y2CVBcVZc+ys= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dFReOsjM; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741954253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N+W7JLYSi3FHd5wiExWEG1bnYG61jBb9yzI4idWzEYc=; b=dFReOsjMg+u2A6l7GBU1B/9dwPWO9g8hSpbWsBokKYdvjHBF0DjrtW69UMo7j0Jo09/LS0 5AHxTk0/3fVOSm9v3obab5qz1KJDE5xlDtSQYgk5KbuxJBRGS72K4dqWWiXpJBi71gpLSH FU9p6/bX/H4vuHchcyXW9qj2AK2n8Z8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-pswnqQI_PfqWKXMIaBCX5w-1; Fri, 14 Mar 2025 08:10:51 -0400 X-MC-Unique: pswnqQI_PfqWKXMIaBCX5w-1 X-Mimecast-MFC-AGG-ID: pswnqQI_PfqWKXMIaBCX5w_1741954251 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43935e09897so15992005e9.1 for ; Fri, 14 Mar 2025 05:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741954250; x=1742559050; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=N+W7JLYSi3FHd5wiExWEG1bnYG61jBb9yzI4idWzEYc=; b=ZGHuWr2yvOD81H2N+rM7f//mFe0vNz4VlATQWyBOWDKxIp1sV9M4uDzW+uA+0/SoPI i0o1pgnkmYnfohIptqlVX3mo1o4Jgv2yyWFFPJ9fk/IV6XcgBZizVvPKhnotCq2AOTbG VQoRYmW5B9ywD4Vz9qKGbsq3gf44j9fILemX8CpDmfUVTfXn1y/Ita5+bEKCNbiOA43X RrEjanJ2P0NcjNw1ZeF8/gxtiqX8Exs8dZxSN1d9BnLzZfBSAj82FobhjSG3JV4wPqQG EbAmLzg5lrAdcB5gr6Y+yD/FLdtpjCI7RPP5I0+FuV+c6rk/eHAr8otKe0uPY0/i2p3d hMBQ== X-Forwarded-Encrypted: i=1; AJvYcCUVHRrPi4Cv/+X56W/jb08K9gitjSHJgyYE5oT9PmM4tzbn/yAP7C/O+wq74uxFGdJbS/tbjhFnYg==@kvack.org X-Gm-Message-State: AOJu0YyC7LLEuqLqEUWG/Qshd6UVflTTDUHTD0PgccraYxMyW12y4AVJ BgocPmXWCd/8SdRUekzfY+m/JejRvsKtM9HO23PdOp+DGm8srQRO/QKxzbnOLQ/j7OeFsTOP8Sw rD0YHSft7/GHA/1i4i7pPps1gYLb/zjMNbZVoHwutejfZwdZ3 X-Gm-Gg: ASbGncu89pf2y3wkPJmg7yRbJNq6eZsRCAWkhXothwNrooQRcN+z/8mLL+meBmyUHUg W5yHjlxfnzdzIBRP7wmnN/lzd0dhy2duO+/Oz88HMe+7iWAfe4g+4nD6ux6GGrmWzmA/hX9zFgX ws3zIxmwLwT2rTw6ywKcM0uWIDuDrOSP/TLOVn5KT4q6Atk+U0Fiu5FVHFDftQwzA2mYVOzu+BH wG5ocknwlYX9mB5RNZoydqvSkpVTTCIwki/F9c6driJC33Yv7a+FRNHZ5YCe78IWes4NqkLPXw4 03e4yy6RLm9ZlU3SYSvygUzZeHWfwQqGktFyM98LMBmdGELJERASxYOKHKb1Y7gG9AEB7KVKeGY MIuI8/a1hMis2g6gwNlD4VJCcUl1gxUflvR8FY3l6lyw= X-Received: by 2002:a05:600c:1908:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-43d1ec80980mr31107575e9.7.1741954250529; Fri, 14 Mar 2025 05:10:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoxby3mE34K41WTlTk/z5r+dIaWHqYottBOdqY1VDqMeig1kOOVvVsfUN57fluTQqQAxwE/g== X-Received: by 2002:a05:600c:1908:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-43d1ec80980mr31107225e9.7.1741954250152; Fri, 14 Mar 2025 05:10:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:2000:5e9f:9789:2c3b:8b3d? (p200300cbc74520005e9f97892c3b8b3d.dip0.t-ipconnect.de. [2003:cb:c745:2000:5e9f:9789:2c3b:8b3d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1ffbcfbcsm15437505e9.11.2025.03.14.05.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 05:10:49 -0700 (PDT) Message-ID: <15cc0c1d-2b02-41de-bf48-3c57cee97c53@redhat.com> Date: Fri, 14 Mar 2025 13:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems To: Brendan Jackman Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> <16023193-6cb4-46d1-91c4-43342e7e6d30@redhat.com> <41923b80-55f4-44b6-bc59-60327e5308f4@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NfUrRbVmg0FpG-Vym-tQV3rpQexiLOHrS0BQ9s0rDaM_1741954251 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BC8E4180014 X-Stat-Signature: qahhbwuazt9m6i7zhor586qjtrpmmxka X-HE-Tag: 1741954253-44860 X-HE-Meta: U2FsdGVkX19Vkfr9/Lw7+SG90vgd7SJ7jBtnyRFoxLpw8kV9iFfsivwxJenp/ds7vwlMtDqucQ/OiBuQcwQPe81vvVHAagZT6++7kE0vJiwRXHYUWucXgnRRf2+KhFtIDyiVzAlQLM1EAVJk8NYTLrqlcj0hhjfOVeCmqKsuUs3zPiVDtpOpmjjvGxG20l5TI/j6ir2OErPB/hilP47s1VMxzfZS9zTv5omDZqtm7TRJva4e8zGGOvh1V2dyBQwbaeQLFCrTaHeYZRv3VJcXfAqxA/RdyvBcsT12v88w9ljtFOqCHNfmNAAlyj64RV3M4qBINt4HsvFwiyWpPSxz7Z6YL6h9h16n5BrX0YMGMnKxtBwvosC/O9P4B9d2e0iuz/npz2iksDd/JuBtPUc7cPIhFWXYi7AwyLcy4Yf14LZLbPtsTk99jPIUFjt3nk+b13nq/J4jDnjpPHsst+l6g5rtfrpD0Nf99UXT4MKZdkQvcpfhmH0oFpRvjXXP2uxEf1dkuixMllTBZabJRWS+ZZZvYzw40AzI3QyWx6lGHqrUsdJ5JKDWEUVxYxY+9rtNnshDfwQ1dsnb23Ou5CSs1YB+ITmCCyreccPxtmsuTFvecWcQkFmCUses+aM16wa7YszRKBwSPAvHg+6hb5kCk/G3Cl4A7mdAyK2Ftby33E6y5dcobF2aQLL1IYirqIv0P5tWFDjEBzCOa2X+xiMdjMT5pPHLo9nF+NRgsYHr9Bvc2ygmVSUzJhvF6ucDP2bMrMTxAs2aMr8FFPQIQYbJoB5NE992Oea4EzQG+GIWA/9sYIG8TN/JBuK9BxlCi2c3qyhb0EAyGefd8HJ2EEnwaPPk9cxJRAcr4heBA37u9QO1w04Hc55D0WTCPxzHsf/+o8ve5eAJCFswBL6sZbCqGb4GkKX9xW2gKxIbqLrt2UorrAzIrMZLyr6XhtOSa7PtAzrfMUbQ/Qyi0t7c764 Dacb5Blq 1L5klczEdsmttj7hg8KMGFEbFvBYOGe6aGKinA9M68Bn1WjboZWIvIe4LIF8VUMCoyEzLTcO7EByzEWNKelvGDq2qg4eZ7qn++kgvnGvzp57n+WSLVb3dekTqQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.03.25 09:34, Brendan Jackman wrote: > On Tue, Mar 11, 2025 at 08:53:02PM +0100, David Hildenbrand wrote: >>> 2. 9pfs seems to pass the f_type through from the host. So you can't >>> detect it this way anyway. >>> >>> [3. I guess overlayfs & friends would also be an issue here although >>> that doesn't affect my usecase.] >>> >>> Anyway, I think we would have to scrape /proc/mounts to do this :( >>> >> >> The question I am asking myself: is this a 9pfs design bug or is it a 9pfs >> hypervisor bug. Because we shouldn't try too hard to work around hypervisor >> bugs. >> >> Which 9pfs implementation are you using in the hypervisor? > > I'm using QEMU via virtme-ng. IIUC virtme-ng knows how to use viortfs > for the rootfs, but for individually-mounted directories with > --rwdir/--rodir it uses 9pfs unconditionally. Ah okay, that makes sense. > > Even if it's a bug in QEMU, I think it is worth working around this > one way or another. QEMU by far the most practical way to run these > tests, and virtme-ng is probably the most popular/practical way to do > that. I'm afraid yes. Although allocating temp files form 9pfs is rather ... weird. :) One would assume that /tmp is usually backed by tmpfs. But well, a disto can do what it wants. > I think even if we are confident it's just a bunch of broken > code that isn't even in Linux, it's pragmatic to spend a certain > amount of energy on having green tests there. > Yeah, we're trying ... > (Also, this f_type thing might be totally intentional specified > filesystem behaviour, I don't know). I assume it's broken in various ways to mimic that you are a file system which you are not. Your approach is likely the easiest approach to deal with this 9pfs crap. Can you document in the code+description better what we learned, and why we cannot even trust f_type with crappy 9pfs? --- Cheers, David / dhildenb