From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB5CCD128A for ; Thu, 11 Apr 2024 12:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88DAE6B0099; Thu, 11 Apr 2024 08:55:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D336B009A; Thu, 11 Apr 2024 08:55:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 706FF6B009B; Thu, 11 Apr 2024 08:55:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 521966B0099 for ; Thu, 11 Apr 2024 08:55:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D17F1A060D for ; Thu, 11 Apr 2024 12:55:21 +0000 (UTC) X-FDA: 81997246842.14.EA016A3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id C3CE620003 for ; Thu, 11 Apr 2024 12:55:18 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hAkVHYUO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712840118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uxxTM9LQHbxdCULEs1M1u2JdrM0DQBJCHzt/sGa542U=; b=ECNi6axReSnfBMSgzmvmwYuja48nU5aFNyz5+PQZ/Dgb+oLINfpVlzO8fimNG6JbfQZSIv 869K0aNdno9tYwWOLT115rVKCy8XQ3D2wKHlrb5ElDRNjhSooLO2ZMTVXCuDx46UsJUkaq qikY4VXFppuPdtwGyjuVsv7plNaq7Ic= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hAkVHYUO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712840118; a=rsa-sha256; cv=none; b=nZFzL9SazgenQQdYq1YBVFGHEKa7/ovWotc+DMEJmE/5iAZrLNFndlZqsjU+isA5BHxPWB EPwLIeEidrLWKN2Rh4MS57XYnnv7OlN1w/AqNSUGWrlYSgBBjifxDd7u716okNuFqwiWbC UFYkz9o4IpOJ+vhhKc8B5MoK+eGt6tI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712840118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uxxTM9LQHbxdCULEs1M1u2JdrM0DQBJCHzt/sGa542U=; b=hAkVHYUOT30KBnojAvsHQ84A9t/n8ipGvlXIe+7jL9JRl7kQlb/O9hL3xz8kvPsxIZ4IsT dWpUhLHZf5qnOZXI4puNDn/gP2a5cjsB0zFpocz/WYsP7i4zdjWKKBDY+0q+cf8F3wXD9b /KQDLniSyfLHVW3iz00x/8E5Drw7inQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-7qLc5SeZM5qygV9Yt-ggOQ-1; Thu, 11 Apr 2024 08:55:16 -0400 X-MC-Unique: 7qLc5SeZM5qygV9Yt-ggOQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-516dc3ada5dso4402772e87.3 for ; Thu, 11 Apr 2024 05:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712840114; x=1713444914; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uxxTM9LQHbxdCULEs1M1u2JdrM0DQBJCHzt/sGa542U=; b=gF5C0c7uWVLd2Frc+8Xy2v8NF6DMGMJ4YZrRprAnP0v8RmjXpZ8aZd/KDpOaD+sFd9 q9cV0EsWbbkLhtRnvu2emicc2bHUWrl2M2//QP+xDvc0j3CRkxRb2Dt2mLC+rjx4moc3 ZB1xxtKAoVuMMhttccwXdUFg6e0pVccmbqsym3IbbF62im9GPBs618r7dW3dBxJQ929Z As54z6ur2i1VsBcQmbpq2/tq4hfRYKR0kfPC/n4PMFlYtPhuHmG4Du/bsDDo03sRw/uR RYTZVmka7vcOFDqdOnopqOHSQohUj+nNvFHOb5B5RfHP2NAiBbSdmPbqYDefsu8CVN/X GDWw== X-Forwarded-Encrypted: i=1; AJvYcCXe0UOnwM9E2duPnxOlqetMAXPUmECvvOIpZ05wJDl5AAh9AEyoa7aRo2O/y8k2+voRxOn0sYNYY5WZLHWzwphgMtE= X-Gm-Message-State: AOJu0YxhXwmVnWPAHSyHJ2jnDtBn29Kp5SLRzPgvU/i8WQ9tYp0feUhG d2tZ43t/2AqlRZ4lm7ysvK8Zofoxr0M9sHMfasNtZphzLOd2duAlBAn9hyy35+OLuKrA33S+5sP e7XPoi0bxuzyXhBKUTCCrSvzSgdT0z/rHzyJRTrg4JIjwjKe4 X-Received: by 2002:ac2:5451:0:b0:517:8b17:1f1a with SMTP id d17-20020ac25451000000b005178b171f1amr1357769lfn.68.1712840114398; Thu, 11 Apr 2024 05:55:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW7rThKEgUHr9qfAmY0TCRkzXRb83o/dAyDyLZJckFU+Wgg9LufwCuNE0aO0wij1RiIu6GEw== X-Received: by 2002:ac2:5451:0:b0:517:8b17:1f1a with SMTP id d17-20020ac25451000000b005178b171f1amr1357754lfn.68.1712840113952; Thu, 11 Apr 2024 05:55:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:4300:430f:1c83:1abc:1d66? (p200300cbc7244300430f1c831abc1d66.dip0.t-ipconnect.de. [2003:cb:c724:4300:430f:1c83:1abc:1d66]) by smtp.gmail.com with ESMTPSA id fc6-20020a05600c524600b00417ced7f6e4sm2218295wmb.45.2024.04.11.05.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 05:55:13 -0700 (PDT) Message-ID: <15bb1139-97aa-484c-9087-dccf6612ed39@redhat.com> Date: Thu, 11 Apr 2024 14:55:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed From: David Hildenbrand To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240327171737.919590-1-david@redhat.com> <20240327171737.919590-2-david@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C3CE620003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iwxncusk31t14douqzf9bn4i6ry13x3g X-HE-Tag: 1712840118-337487 X-HE-Meta: U2FsdGVkX19b2quxzUord1yDDrwzryP2Wl4B4yskJUGiLeJCZxUTCqvfPVsYxd/pXVpot1FRMQBte77E5uR1HmrojUffiQYQGITizEOqp0KSRprZ9XBVWYNPSOrHFz9LrD3zKLHtWx5rBFWiySa0n0RO/9vnC5bWoXKubkOjV/uOf5WARNd2BpxjHo4MQuqONi18vmluFw4/1d40Smks/bPnXaOxreR9sEOLxs48RlBs+j3+eP4sIvyRi125PPfRyBXcjiEjMIkLCqBW4ir1/nSLKLrg+mONCjfw+ESp9AUZgjuRljo7wpKT1oT4Dyfp1fXL4i4/+202BfAs8rwhpXGahJUN7tFJIxaKb/UJ04X2z9BbcgG771281w/2PDBOHlNBb56lIbQ1guXU6IvZSwS3DflhVpRkZN6kdFDvY5nR4kA0cdBsV9JjbT6hdj0/VS6chYAieLQi7whicg+Lh6ClpjzXA/u3wiOUwFE2YU5Llse1qqII8qrYQ/ryF9RpR6wP2PqEkjaht1W0rCnqCKREbBok7fcwk+YK2FtbSn3HbkheQfrECtWUXczAvYUYc/RhLkWq62ICz+jb81tVlynYjM7DOhDUtA7ptFWCYUCD1oqNFsZT8gT3RcDwVNb7NUBTMTWYpR18RXPdwwyO3RjbKWNAwLrlBRy1mCYqb1p4TAwisPNKXn6grpgafuC9FaJ6qnLkaC8vJ0tzxXhWmK+wwIoFlAskAHnehpp3tlL6m48P+UsnqWoKER0BQbh/kL/7lKAaY3Xr2gYXf0ftyrBFS+zs27p+2Kl6pMh/BYAPJvYMD247blviHCZojQJNCkXuOUsZttBBTn0uuRxhCqPzNLMdPg1d7ExXRLKQ+N3MgzEKTRb6y2IoJeo4GenOlsU7Hyq7RZxwCt8lOkQIUtp5GqyTB3ZnPPU3PvNLTVWMlmYus1biuzLJHOq6ttSczQZPF9UX+GbSi05KsKI tn5YoQpt WR/GBYz0mPsbe7MjB4ygf+1FNaSTZqNHbs6fVySKFz3/n8YlvibyI9vJu4PTrK4uyXeooyIaBHeHgdsjBgtf3SuszH9BpMWEXiKtfFFkhIPmLDMGFxK/olzRWgVFx6rioJC1YFfcZFx9/iRM7RG4ehV+ob6/DUwPcZpH4CUQBZs9z5Xk/4VTjRuu3JhfiElDNYsd8GHxqXs5CSAlFyWwGiU+fSmxUdcfoZJu+nCChzvdQdJpzXP+GXs+VH5V8k+5+GJ/Srs5wWZNwG1AGYR4o/LXnWNB38cn3GvhHaFdfpHxFjdp23YaER363wXPLmgFqqIMDIsa6Stuis0sMoJJkQSGwpivnIbN8k0vsED6dSic1UxUM1FolGVXNeZHidM21IuaeyPE4APc5kNBUWoQrDq39CwqrGPk1y4o3PtR6wttj5sQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.028037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.24 14:30, David Hildenbrand wrote: > On 11.04.24 14:26, Alexander Gordeev wrote: >> On Wed, Mar 27, 2024 at 06:17:36PM +0100, David Hildenbrand wrote: >> >> Hi David, >> ... >>> static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, >>> struct vm_area_struct *dst_vma, >>> unsigned long dst_addr) >>> @@ -324,6 +355,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, >>> spinlock_t *ptl; >>> int ret; >>> >>> + if (mm_forbids_zeropage(dst_vma->mm)) >> >> I assume, you were going to pass dst_vma->vm_mm here? >> This patch does not compile otherwise. > > Ah, I compiled it only on x86, where the parameter is ignored ... and > for testing the code path I forced mm_forbids_zeropage to be 1 on x86. Now I get it, I compiled it all on s390x, but not the individual patches, so patch #2 hid the issue in patch #1. Sneaky. :) -- Cheers, David / dhildenb