From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB37EED60B for ; Fri, 15 Sep 2023 15:43:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 437766B0381; Fri, 15 Sep 2023 11:43:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E8546B0382; Fri, 15 Sep 2023 11:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AFBD6B0383; Fri, 15 Sep 2023 11:43:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C4966B0381 for ; Fri, 15 Sep 2023 11:43:31 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E067E140670 for ; Fri, 15 Sep 2023 15:43:30 +0000 (UTC) X-FDA: 81239251380.24.20D4E54 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A982D40022 for ; Fri, 15 Sep 2023 15:43:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GZc5rY0J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694792608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+HjRpUexdgJAehf7Qv6azxAmOLDK2cUSsvpp8na9Sbw=; b=zCg7qsjblYAbGCh25MyWeXBAIELG/ki6/Qc2TCj/PwsdfJldbCr2OPM2Gd2rKl6Hjhx784 KbT+c29+9i61zUzuqUqLkO8W5U1YKeESXFdSorZ/OScfp+HpFkDTJ8hsmCbuofewjXUcSs umJE5kMKkfLuHLH4LOq/iAp0ew6poic= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GZc5rY0J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694792608; a=rsa-sha256; cv=none; b=oG9iuJCQje+iXeKlg7WNWQ38ir9F09BCuzoKE8cetmQ/cHJMP1Re4AxeB/rn0Vi7EUKdMq g5eZF8MFgHgjkRdUbGug3fJ3eBPi16IRZ3mt9/5KuLhbxXbe3ViMfVvx8Ze74o+GLuyp3u KwZissTm+1sz7NFq+tK3A1btuihx2ro= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694792608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HjRpUexdgJAehf7Qv6azxAmOLDK2cUSsvpp8na9Sbw=; b=GZc5rY0JB5NU20UPt6+JbhsDoeHEHb3yGP508HVWNiBEByAum8yeIucpTcrAzYMLz3BRXL O8HFBaonRMK4qvqpyotRk9kDzMYWPgqzayIoP2YWNVeCkcMy56HL5C5myg4ndiB4xvATo3 mcyKh2TZU1Q0DWkIFJr2h/E1jjzsKcc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-yLnhhVaBMVaXufsVagEeIA-1; Fri, 15 Sep 2023 11:43:24 -0400 X-MC-Unique: yLnhhVaBMVaXufsVagEeIA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5009121067cso2733453e87.2 for ; Fri, 15 Sep 2023 08:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694792603; x=1695397403; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+HjRpUexdgJAehf7Qv6azxAmOLDK2cUSsvpp8na9Sbw=; b=CbN1GWcr2+UVl5biTrEdil+gYMupmZDbylmzz8HZD4uzC9SG0NXB6DtgNYzcHtW0Yj trUkGDHrGJVJLIiddlhvkHdub8dJF+xoK8HIChGIt3B9dsYBtfwglA4mc+v+/5sp3CZO yqC0gSryfZbet5we7dHTHDr+sYJQ3HRohShW2p5ZwRqgmzxkUVAr1h2R+hjtNaiLuh0p 4cHHdYdDPPnNh47k35m6PDGuopRepiyXm23p6d7U3hU67feZ3gzovWM3f7o5xm5LzAD8 KeGjSxxcwYape9EvgIYbqTDsasH5RhTVEApb0TnYHji3hLhmL1vnJIcjE8U/vWtd//9s IIjw== X-Gm-Message-State: AOJu0Ywn28xhfG+o3c31ovKsms7ZZspNMeClgEqWpqhWSsFt0LKHaSxE N0lW2dQvC2q1QM1Tdj0Cd6WsaKKzTRHpNf/IWsfNd7pJzg5w7PI8Bk/P4pIBpTepzpjFpNVGmmQ SmC52/tpIrAw= X-Received: by 2002:a05:6512:2528:b0:4fd:f84f:83c1 with SMTP id be40-20020a056512252800b004fdf84f83c1mr1921027lfb.64.1694792603017; Fri, 15 Sep 2023 08:43:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUlzqnI9IhxadefzLCHSEYLKXLnj68ovmQNeMXOp3JfxSWFhttFec7rrRBDh3udFZ2SJb/Tg== X-Received: by 2002:a05:6512:2528:b0:4fd:f84f:83c1 with SMTP id be40-20020a056512252800b004fdf84f83c1mr1920990lfb.64.1694792602530; Fri, 15 Sep 2023 08:43:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c728:e000:a4bd:1c35:a64e:5c70? (p200300cbc728e000a4bd1c35a64e5c70.dip0.t-ipconnect.de. [2003:cb:c728:e000:a4bd:1c35:a64e:5c70]) by smtp.gmail.com with ESMTPSA id x25-20020ac24899000000b004fb738796casm685274lfc.40.2023.09.15.08.43.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 08:43:22 -0700 (PDT) Message-ID: <15b067d7-8f95-d409-64be-d22359f0942a@redhat.com> Date: Fri, 15 Sep 2023 17:43:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/6] shmem: high order folios support in write path To: Matthew Wilcox Cc: Daniel Gomez , "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav References: <20230915095042.1320180-1-da.gomez@samsung.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A982D40022 X-Stat-Signature: ge37iogfbqhx5ktsuceff5u1s4ww7dwx X-Rspam-User: X-HE-Tag: 1694792608-560605 X-HE-Meta: U2FsdGVkX19KbOtMzTq7YWt6ZhAOOVCLJxPb2juQ4PlARrrBlDQHe7NNd4ddQb5mYxTCj/7H7bqaLe7irhJ7a5S/0Wkau74k6AuzZP/QZcGJhyRkEo+D6lW43ZTeGSYuPk/FWltSRkdQPdqyMqZIgsjqrRXkVOKUxyHZ+Q2MK+2IIHdiMKw9pjF5+uNt9BAEBZ1Vr01fy1ZyWWT0UnZOuKhatJ9ynKqAKWlEFErhW0MR/uQE/hWuS7yjOW183O4qa14AwR4UK3Sx0zv1qtRUcIFMBjB/K3WTNqad5pfbZ2iZhPZ9PvKvIH7JX/1z7Ak104ij7pY3l1CB5iTxYBwpPOv2FllwevmEFurxigigECx+Ssaa45WN1GpY3lXDIsrpB4a4RF1kpLMR39ukv2aBAf4nFrr0Iz1BNGighB/YA7QwWTF5AHaDEmzGAipQicEBp00CqU9ncPHYegpRNDaDLPBVdrXKwEHHXB4iOOibZrMikRoizPRAmokenkUxz8o1hUn0gea2N7y7ruDYhPXREL/4VRlK+tOxFoRz5M2U4z2K0Tefg0Fhh5a+AROci+eXA56U1Cnr+kXkwr7XphAFPyqWAumj6iPNzB1b1XrjjpgCy8g8tTucZmUyprISiapRKHfwj55ytpxDql9DhVTrwG/77MqaxY3BbGmDKHU8EpTpmmi5EtbGK6FZcTXPDXWBwK0uEQ4rz9P7O8sKazODiFZrqaSeJxTdV+xbJzJhPlGaMwEWhmNRy2b93wRRw9qYb68tiDACMCXAC0De0VoPHXNzIP7klET39JzAtM704KSA0NvvXreSA/9yBFM5LZvmJ31/AOvRDCpUN5l87NeDIG/FjrAYLqD8GKxAYw5xW/OPFl08UbAEPo7GhZfDM0VaqaCGr9z0tl2kqgOBTDWObdrCvpgoSDIAJlAfQAPrUK52Don/kBWWRzDHxkCgjH3AKvaRYqltc9IoXIe3k7x g6sx3ITb 6ikq9aiLPkloZZne81txuzYb34HjOtvqIiyk6HITubLmI/OZrhoVyJ0UcRwHQrFpk75XK7Ib6obbjR6I2S2m7VFi55wTjSxAXMOy6udAFOb+pkFLDwQ1MaMfshoeOEfHPyBu+JL+8UR4BXD9+soi72JeMqBtlXC1xfcfxgUOSsV98t12WKEcG97EWtkiScfWnbco/b5rSqh404+uB68QV5TI2xr37Y26NaSwOSzFuybjGLsnk4fSPqYJn4YO0/zK9FU7Jn5WfhmsVWPDa3nAvYg4qaGhhEZ6lpiO+YjvzGtkVEuO4Z7fi/nSury8bE+of7UHoNMXq//eOWJnHsZfBgzBcqoGpi/EIDrX45V+Pt4cIpRHj+wTp10S2hd4yWNCqMYXd+QkmRNtULmlT7sVpXLcXvQaBuv/+ZtT/MB7gpXgz0xo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.09.23 17:40, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 05:36:27PM +0200, David Hildenbrand wrote: >> On 15.09.23 17:34, Matthew Wilcox wrote: >>> No, it can't. This patchset triggers only on write, not on read or page >>> fault, and it's conservative, so it will only allocate folios which are >>> entirely covered by the write. IOW this is memory we must allocate in >>> order to satisfy the write; we're just allocating it in larger chunks >>> when we can. >> >> Oh, good! I was assuming you would eventually over-allocate on the write >> path. > > We might! But that would be a different patchset, and it would be > subject to its own discussion. > > Something else I've been wondering about is possibly reallocating the > pages on a write. This would apply to both normal files and shmem. > If you read in a file one byte at a time, then overwrite a big chunk of > it with a large single write, that seems like a good signal that maybe > we should manage that part of the file as a single large chunk instead > of individual pages. Maybe. > > Lots of things for people who are obsessed with performance to play > with ;-) :) Absolutely. ... because if nobody will be consuming that written memory any time soon, it might also be the wrong place for a large/huge folio. -- Cheers, David / dhildenb