From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D07C3ABC3 for ; Tue, 13 May 2025 13:10:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70A158E0002; Tue, 13 May 2025 09:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F628E0001; Tue, 13 May 2025 09:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5302C8E0002; Tue, 13 May 2025 09:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3230F8E0001 for ; Tue, 13 May 2025 09:10:34 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5C1A55C6C6 for ; Tue, 13 May 2025 13:10:34 +0000 (UTC) X-FDA: 83437918788.09.728C6CC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 13F9818000F for ; Tue, 13 May 2025 13:10:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CjYClsyw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HqOyFuz1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CjYClsyw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HqOyFuz1; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747141832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=11tBS+jgpcKxdYTiqo2FzazKreTFp9sunKwlAVzvbHk=; b=q/ageF9I7ztNiU+sBALsFbgli/blDWwLw3429P/4Bxr3mzs5/1dBRvXd6LYRpY9+OyE4/Q sojoHXP3OuaoFDEjuExB4JeLaEcjbjlw/Nqnr68xuz9fFBAjOgzPo9krJ5dUMcMEfT+Y0M TfqX1VAZXfuvdOzd78zWVki7k4GG7WY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CjYClsyw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HqOyFuz1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CjYClsyw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HqOyFuz1; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747141832; a=rsa-sha256; cv=none; b=bDbdL6uXx5dd64A1nfeNv3Z0EtTTCgqezLd/2QLQysO3FuUvM5jJ3CKNPu2e76bCkqs49r zILbkW18zlMZhYSE0W+omnsJqb3G/FVgwIvTvDmMBRykUohw3yqyCo2m7vGNTLk7JctPjh vQGDY2DiY8/Hc/cXGXZORjpvEJv9vBg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6C751211D1; Tue, 13 May 2025 13:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747141830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11tBS+jgpcKxdYTiqo2FzazKreTFp9sunKwlAVzvbHk=; b=CjYClsywKLaDBM62r83pYPtQ9vRn9P2askBSq/j8TyTAIZDHSXgV+f0DN38jIhrg5WZLi7 +oco2iO79P4l37FveGiO6fE7GSHN8IDPd+bgwmk0j3SbjOi1gRWz04FikRuVbB9l+X+dVm gSLtX4qUegfnrS81k6jhYOfoitvuYFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747141830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11tBS+jgpcKxdYTiqo2FzazKreTFp9sunKwlAVzvbHk=; b=HqOyFuz16rB3ZSwvQ8tMS0i3rcKt/ldfHhkXsBycV26U6/l0QZlQpUiu2aV/DhShMipAQL jUiD41h0VPmhcpBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747141830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11tBS+jgpcKxdYTiqo2FzazKreTFp9sunKwlAVzvbHk=; b=CjYClsywKLaDBM62r83pYPtQ9vRn9P2askBSq/j8TyTAIZDHSXgV+f0DN38jIhrg5WZLi7 +oco2iO79P4l37FveGiO6fE7GSHN8IDPd+bgwmk0j3SbjOi1gRWz04FikRuVbB9l+X+dVm gSLtX4qUegfnrS81k6jhYOfoitvuYFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747141830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11tBS+jgpcKxdYTiqo2FzazKreTFp9sunKwlAVzvbHk=; b=HqOyFuz16rB3ZSwvQ8tMS0i3rcKt/ldfHhkXsBycV26U6/l0QZlQpUiu2aV/DhShMipAQL jUiD41h0VPmhcpBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 368FC137E8; Tue, 13 May 2025 13:10:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2kzNDMZEI2jLVAAAD6G6ig (envelope-from ); Tue, 13 May 2025 13:10:30 +0000 Message-ID: <15a8e990-4eb0-489f-bf2f-a192e4fe9543@suse.cz> Date: Tue, 13 May 2025 15:10:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 7/7] memcg: no stock lock for cpu hot-unplug Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250513031316.2147548-1-shakeel.butt@linux.dev> <20250513031316.2147548-8-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250513031316.2147548-8-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 13F9818000F X-Rspamd-Server: rspam09 X-Stat-Signature: 33tkoqjo8b7daswbpaexqmkg33i6qjxw X-HE-Tag: 1747141831-23361 X-HE-Meta: U2FsdGVkX1+IOoY5FArxT6ghB3wdGdh7Cc+69Z6oC7dYlvK/SBDwvJCE6+x+kl3cqVUDuC+tMWV3wrftKfTwPifYwvg2fjJFAGT2q/bIyd5AsqYOubKLhV3ikxka0HuS4D1zeWlN/uywmD8FGBmnZ+6rHPGtJl9DH8jIlVZN8oCqQeB7CV+oQ39kHkLHYqb3ak58nb5hPs+TsmBirHbwatfGkPSJSAf9E60RqJjyN8IgrFm9SLcqL+d1euDXQ35fA91L/mvUtiElLTHSoBnwQxkYuswymfnacxd5e2ilt1Udbt2BjvXssHn9oZEa+lu8XL/jb+YCdmXPrgN5f6llI73VCQabJJRmiI59++oym2D6l3LWP9haF1CiNlkMmt/Z19fRtUaw2g8LuW0rqSCckf5x2CUIbitwAMoL6615I2nCe8HFiRs8KrQFrgcyHaaWw0cl7WzxEwTPcAI6keQqyOdrPcuyA3klLRUuDtt4smnhhUe78bygkPGAs8pJEkNCrMpVgTZJ+6d053B4i17D5qzzi+cbK8QR6xC53Ph/fj0XvcouAdQ4FdUzwq4GiN0djsycQ0vtpoAucJTvGPnmmpZwMYCK+9YVfCbQd/z3CwE050OrA0yaSphy92XXnNaRBQfvvY9sDC9/DYy1/NTxVMZtY9JNnPp9GEo5RLEL1vviSVPGckWbbdsy57EuA42mDGohahj48m0aa4OlLKCyiIyWafZp5gYQ1jkxTPgF1COQztTYYJUoNXeslKetD3bx/dsXtAm2vDKFSwabgviLQ3kd6N6+H9ydef3yoAY9zYCVaExCkbQMAh0EDiwqiCERBsWErmxeGhmkOelFWJkQ5d7spEMKlar9w3qtzYqs1aPb95OFFgQsRPBovz9WMFHc6Q1YxMx5D6liIVuXBHP+gPYMk45ETG6XM+O39oVY5UOVKYJGRRBy/kMWyFQ2jXU0l1id+HnZ942y2drUCsY Oj7VIjfF ee2nUfaa8RRaWy7GkdqePcwcfW/yACKawafNJ9tBJ2oMi49HG6tpGvv1g+wxVaiEZdL/MMh0VZQMHdmd/jqqFtlrR1jPf42ePA9FYXsn6vmHYDWxzoVE54KSkIS0jTNFcrkD6JshYvCiIWFKHJcPQvYG/8agq0LIt92B4hyyqF82cAyowrAY+ENYcl79/LUgTrfs7HIk0RC7CD1M+ARFL8tvP9WGYVghFU9kXNbPnLOxzIfkEth2XfJO9ue33vH0c7TI19GS0fo74Si3TLlyqO+X/z8Fu29LXmziEKRIMf8sUK+vI9g6mxkgKtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 05:13, Shakeel Butt wrote: > Previously on the cpu hot-unplug, the kernel would call > drain_obj_stock() with objcg local lock. However local lock was not > neede as the stock which was accessed belongs to a dead cpu but we kept needed > it there to disable irqs as drain_obj_stock() may call > mod_objcg_mlstate() which required irqs disabled. However there is no > need to disable irqs now for mod_objcg_mlstate(), so we can remove the > lcoal lock altogether from cpu hot-unplug path. local > > Signed-off-by: Shakeel Butt I think you could switch ordering of this patch with 6/7 to avoid changing memcg_hotplug_cpu_dead() twice? Acked-by: Vlastimil Babka