From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0482EC636CC for ; Mon, 13 Feb 2023 06:37:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78F496B0071; Mon, 13 Feb 2023 01:37:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 717BD6B0074; Mon, 13 Feb 2023 01:37:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5910F6B0075; Mon, 13 Feb 2023 01:37:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 41F9C6B0071 for ; Mon, 13 Feb 2023 01:37:23 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0C34212017C for ; Mon, 13 Feb 2023 06:37:23 +0000 (UTC) X-FDA: 80461311966.04.615AAA1 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 218A8120003 for ; Mon, 13 Feb 2023 06:37:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k6tlOEQZ; spf=pass (imf29.hostedemail.com: domain of groeck7@gmail.com designates 209.85.161.54 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676270241; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r+mD21wjZ7sbz4e4MxBS6xbK/1FhjAg9+awm6A789ww=; b=WlSxRb8oixzfjXSQe0iHsNw/VfmE1M3QjkaeqopWe8T85RniTB+uYIZW/5sbbtEzwbXnkE RBw8s85hTg9yv6Gm0zy0qH57TKPQAT00WSl2L6Q7xtD11BN1Lm4NpHYRyvT26KN2gmUr6B 1MOnXZSue1hgSu5jkeXskuvoQ3LvOx4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k6tlOEQZ; spf=pass (imf29.hostedemail.com: domain of groeck7@gmail.com designates 209.85.161.54 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676270241; a=rsa-sha256; cv=none; b=xexpJGuco4wNx3vGk0O6a2WDDGMP9pBIrKWLtU6ZjTVsWVyNihL5uua7+4W9grjO1lHGVE bzkCEPB49jKPaskj7rffh9ecZICrmCDkabc5+6QyXqFjvdZdHrf48aOtgKVkI6sXQlSDoo 27CnVsYnxj8w8Puhui7i4VKb4K0+jEE= Received: by mail-oo1-f54.google.com with SMTP id y13-20020a4ae7cd000000b0051a750e2ebdso1103389oov.5 for ; Sun, 12 Feb 2023 22:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=r+mD21wjZ7sbz4e4MxBS6xbK/1FhjAg9+awm6A789ww=; b=k6tlOEQZNhmHTa+ZCajRLjNoXOkqSfo4mR8OrWgNmaL2MKywaTjKPH0ulYH6V9boxY 52UWHSIcC8rNsw1dQfTkq/COZKRQGSqbB6Kc2G15s3DFFoFMZdeK0fle1rX83pU7KJ4L ++BO1fcXWC7mjkIEb9evuvP+OSvCviMd3N1ZHNescW7Lpv6a0HL6BarepuSkif6zPqmJ C0miEzpiGke8zc2vSBRq5eRVJsUX8UcbybG0D55ni/6ICUXuIpztwVcd4DNb/6z3a9gS 0Q6J9mDHSQbj/EfASGYAa6yP1HnW6//0d7Bxm++QcZv8+DAFF4S+17znkvYeLv4XlC8U Iyig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r+mD21wjZ7sbz4e4MxBS6xbK/1FhjAg9+awm6A789ww=; b=V/768fLEiRIZ+yIlmXohbZlmeYsAahN0L9N5nd9nFFsojhspKNVbvZwaAxvgg3toWJ Y3GTdzBHDofzYPuu6n6Swpywv9WoqMEgcCJyJPbtTHU+4XSwq+75nZPIAZIfAH3EsV5C 48GXkoZKgp4gviKwHVpn/rVdGmDhDrhBokpfv8qIKCC4Q7dnm07+3BAVI5BXS0M6Sg4a OTaQI/cqrRoSbbq+A/QoHtibZh/GvsKJELM40LA9VyJ2bKrfiogGjpjxAijGnjN6KWj5 2ZnQb0exnCudsrzZUsrTqn6/qH5GuGPaB1EnEr7tS9iYcNljj+9lxk5J1aIvPerKd+ph Ajmw== X-Gm-Message-State: AO0yUKVXmdRBeHi1QRPR00q1i+YYwM9gYRY59+AQrqUCvTRs/UjkaNQ/ V7KJB7JcvfXunAxYJIIAzUo= X-Google-Smtp-Source: AK7set8CrGfl+FsDAT8ZOxZzNC5b1OZaQkksHfF8KDK4IpXQlQWLkqRaCxpy9jhC5xUjdOk1jrrITw== X-Received: by 2002:a4a:d623:0:b0:512:2016:53e5 with SMTP id n3-20020a4ad623000000b00512201653e5mr12513885oon.6.1676270240292; Sun, 12 Feb 2023 22:37:20 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id b15-20020a4ad88f000000b004fc4000ae48sm4528998oov.15.2023.02.12.22.37.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 22:37:19 -0800 (PST) Message-ID: <15a2c023-fdfa-9543-ac36-a846e5f8a000@roeck-us.net> Date: Sun, 12 Feb 2023 22:37:15 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM Content-Language: en-US To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> <20230212161320.GA3784076@roeck-us.net> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 218A8120003 X-Stat-Signature: tqcpzam3exsmnuyqau671dq7h1m6neck X-Rspam-User: X-HE-Tag: 1676270240-141467 X-HE-Meta: U2FsdGVkX19OpBcM7NNFfA+iDPlzosu3P6eDy3FS3F6bN0yAOaogBdmym9ScanaYiXC1yCHplXOSgJQdfeI3APV+0jTnXcYgXY9E2zdFAt5a3KKT7ezLnoFYfSoAAwKrtzBrSSO+dwfLZw70WuXx1zZKpu9nHzJAdqE0rkMEaA2WJIS9tsBeu/nzbFjXjv+1FxjmATYG5XdL23mau0Q5NdO4lEjo6p2ZDxNRRtkn1J5+L59geVOpP0yae5IHntLaC87fziihGpFuGFnhcLA1tbiEg3IelrDd6j/WcJ/jawBqeVbaRIIYjt/LxMNX85iL0GxfdK5Db1TCozMvK1oHi1xVC4p7db5GrzGIIP5S509bF1WVw5Kx9TO7DAaiWZElV8KxfNXiHAl2wkKSIHcChHePrdxp+TtiGbvjt74LBV6S6fCbHbWtots72942eU6GfsSu4EZ8KFJ7LcqDNXu1fzQ677L/ffETWglhwfMRZwuuyP2gAc6zENZb9BnmtCq1LAutUWcd5+dR6K0qUljUm4ICaBY2ywd1amPq53z4rDhuOoaYF+fDqg5PA83d5HKIhfDI7nLTo9M4xsV6G6xz7Oev2qgcKqbu/3aW5CGtqYwyhhDX+SCZUqnixZdCyZY0OT9vXmBsdyxvJVK84YWkwu5A5h1uRj6ucdC/mmhexfZiODvbLnksuCxLE+Xy5kTa9GPlIZerYGGL5ypxgSHNK/DDdVZaw0SjgLyGe4P2EYjvA8Yh+IRb4JnSzKZ78moK5UH4EU5yC3XDIjaqR1IE4tEIEJGUlgzae2QP1p8oiwJLVDT0FkswuPhxbl9GY2NvsyeYhIMGlARdsGP3t5xQ4J/okmfqdo/xXHAS0KDcdFj+2ZlsDpbco0yOTY0V2UPYsAKsrPGe6tRhxu7WXP1i0uSlESmMgUIbr9H/mSJ/+51SLzk/5azaxgYi3Bt35bUqIbWQaqzWvc5wjI6+J7V Ev/DiCQI 0SumBBGzpHxvVdszH7OtYA+bERkT96E4gDh+4NRyymMHOzOPDoZbUK7aizW3aK3pRh4aK0oTkCBgsObTQ44fAGAtOtVMyitsYOI+/4P2oOr5EHANYh3suePu+h/6DhP/1JuM4yTijkOZFtvLK3S+oYz8qDOsAlOylSH7mcAz1p2qTucAh6TV1n11I75JXrk+9IMLgaogAyP/98rRVndOGiuF4HUXoTrOlE8WrqrvVbgdjuG4tlM74s9HOoykKKEk8Xm7XcSlpa7TYWOngsWv2FAAT3t8mWofCiqOQ7A4m3df5hwgo++IZIH87/1CK2Fx3Stg08cttPDTHZivuMEVO4dBMpz+e++TKp3CR2dk/WX2Ympyl2vAw2YK9e3zO4YoTDl4g0unApihTsQJmmLOs7oAQUrfWoztIF3zS2oEBNW8QWhywxBeCfSg8txltZhtG/2Nsuj8zDFYJp3+9wfU6doMaGjvRfBqXNesijRCootShLWLirb3Cpqv5I3lMsWBFDc8AFAYYWT2lwcG5Bi7yrahQ5G4BfRBdZpnMA5rFeSL7LIBPzlF4RhefzRIcC0RF1IgOem+oTF5QSIo0a3k7rLs580rP19vNR9E7gMKa4LTdtxh6zOYoTH0e4UyFFusRY/1+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/12/23 17:26, Mike Rapoport wrote: > On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: >> On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> Every architecture that supports FLATMEM memory model defines its own >>> version of pfn_valid() that essentially compares a pfn to max_mapnr. >>> >>> Use mips/powerpc version implemented as static inline as a generic >>> implementation of pfn_valid() and drop its per-architecture definitions. >>> >> >> With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot. >> Reverting this patch fixes the problem. > > This should be a better fix than a revert: > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index 506784702430..bf1b54055316 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -301,6 +301,7 @@ void __init paging_init(void) > */ > max_low_pfn = max_pfn = memblock_end_of_DRAM() >> PAGE_SHIFT; > min_low_pfn = __MEMORY_START >> PAGE_SHIFT; > + set_max_mapnr(max_low_pfn - min_low_pfn); > > nodes_clear(node_online_map); > Confirmed, this fixes the problem for me. Thanks, Guenter > >> Guenter >> >> --- >> # bad: [6ba8a227fd19d19779005fb66ad7562608e1df83] Add linux-next specific files for 20230210 >> # good: [4ec5183ec48656cec489c49f989c508b68b518e3] Linux 6.2-rc7 >> git bisect start 'HEAD' 'v6.2-rc7' >> # good: [94613f0efc69ed41f9229ef5c294db3ec37145da] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >> git bisect good 94613f0efc69ed41f9229ef5c294db3ec37145da >> # good: [19e62c715fe70dae4582c2874ed3e66715d09af6] Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git >> git bisect good 19e62c715fe70dae4582c2874ed3e66715d09af6 >> # good: [5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6] Merge branch 'for-next' of https://gitlab.com/peda-linux/mux.git >> git bisect good 5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6 >> # good: [c349bf6ec83903b20fe570c5609b9a864a64e09c] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode.git >> git bisect good c349bf6ec83903b20fe570c5609b9a864a64e09c >> # good: [5a06a9f17454df38f35672be522ff5eb9b4277d2] selftest: add testing unsharing and counting ksm zero page >> git bisect good 5a06a9f17454df38f35672be522ff5eb9b4277d2 >> # bad: [f5d115a7b06e5661ed5218ffa9a2644c4ff1c135] Merge branch 'mm-nonmm-unstable' into mm-everything >> git bisect bad f5d115a7b06e5661ed5218ffa9a2644c4ff1c135 >> # bad: [acb018d6ea0c055381fba7dddaef386ee28f8075] mm/vmalloc.c: allow vread() to read out vm_map_ram areas >> git bisect bad acb018d6ea0c055381fba7dddaef386ee28f8075 >> # good: [1a5d9782ac969dc6e61c6786500b5160603188ea] mm/mmap: remove __vma_adjust() >> git bisect good 1a5d9782ac969dc6e61c6786500b5160603188ea >> # good: [4b32363697de957dcc890b6245bec3f58903639a] arm: include asm-generic/memory_model.h from page.h rather than memory.h >> git bisect good 4b32363697de957dcc890b6245bec3f58903639a >> # bad: [328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8] mm/migrate: convert isolate_movable_page() to use folios >> git bisect bad 328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8 >> # bad: [b704c765b08cabe82adf76a4d1a74f3688eee410] mm/mempolicy: convert queue_pages_pmd() to queue_folios_pmd() >> git bisect bad b704c765b08cabe82adf76a4d1a74f3688eee410 >> # bad: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM >> git bisect bad e5734c8b0edfd2a053a5c256189586a3b1e9f63d >> # good: [ad8aecea034c591b9754bc5908da9719853aa7fa] mips: drop definition of pfn_valid() for DISCONTIGMEM >> git bisect good ad8aecea034c591b9754bc5908da9719853aa7fa >> # first bad commit: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM >