From: David Howells <dhowells@redhat.com>
To: willy@infradead.org
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 6/6] mm: Pass a file_ra_state struct into force_page_cache_readahead() [ver #2]
Date: Wed, 02 Sep 2020 16:45:00 +0100 [thread overview]
Message-ID: <159906150036.663183.11566577279669811013.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <159906145700.663183.3678164182141075453.stgit@warthog.procyon.org.uk>
Pass a file_ra_state struct into force_page_cache_readahead(). One caller
has one that should be passed in and the other doesn't, but the former
needs to pass its in.
Signed-off-by: David Howells <dhowells@redhat.com>
---
mm/fadvise.c | 3 ++-
mm/internal.h | 3 ++-
mm/readahead.c | 5 ++---
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/mm/fadvise.c b/mm/fadvise.c
index 997f7c16690a..e1b09975caaa 100644
--- a/mm/fadvise.c
+++ b/mm/fadvise.c
@@ -106,7 +106,8 @@ int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
{
DEFINE_READAHEAD(rac, file, mapping, start_index);
- force_page_cache_readahead(&rac, nrpages);
+ force_page_cache_readahead(&rac, &rac.file->f_ra,
+ nrpages);
}
break;
case POSIX_FADV_NOREUSE:
diff --git a/mm/internal.h b/mm/internal.h
index d62df5559500..ff7b549f6a9d 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -49,7 +49,8 @@ void unmap_page_range(struct mmu_gather *tlb,
unsigned long addr, unsigned long end,
struct zap_details *details);
-void force_page_cache_readahead(struct readahead_control *, unsigned long);
+void force_page_cache_readahead(struct readahead_control *, struct file_ra_state *,
+ unsigned long);
void __do_page_cache_readahead(struct readahead_control *,
unsigned long nr_to_read, unsigned long lookahead_size);
diff --git a/mm/readahead.c b/mm/readahead.c
index d8e3e59e4c46..3f3ce65afc64 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -272,11 +272,10 @@ void __do_page_cache_readahead(struct readahead_control *rac,
* memory at once.
*/
void force_page_cache_readahead(struct readahead_control *rac,
- unsigned long nr_to_read)
+ struct file_ra_state *ra, unsigned long nr_to_read)
{
struct address_space *mapping = rac->mapping;
struct backing_dev_info *bdi = inode_to_bdi(mapping->host);
- struct file_ra_state *ra = &rac->file->f_ra;
unsigned long max_pages, index;
if (unlikely(!mapping->a_ops->readpage && !mapping->a_ops->readpages &&
@@ -655,7 +654,7 @@ void page_cache_sync_readahead(struct readahead_control *rac,
/* be dumb */
if (rac->file && (rac->file->f_mode & FMODE_RANDOM)) {
- force_page_cache_readahead(rac, req_count);
+ force_page_cache_readahead(rac, ra, req_count);
return;
}
prev parent reply other threads:[~2020-09-02 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:44 [RFC PATCH 0/6] mm: Make more use of readahead_control " David Howells
2020-09-02 15:44 ` [RFC PATCH 1/6] Fix khugepaged's request size in collapse_file() " David Howells
2020-09-02 15:44 ` [RFC PATCH 2/6] mm: Make ondemand_readahead() take a readahead_control struct " David Howells
2020-09-02 15:44 ` [RFC PATCH 3/6] mm: Push readahead_control down into force_page_cache_readahead() " David Howells
2020-09-02 15:54 ` Matthew Wilcox
2020-09-02 15:44 ` [RFC PATCH 4/6] mm: Pass readahead_control into page_cache_{sync,async}_readahead() " David Howells
2020-09-02 15:44 ` [RFC PATCH 5/6] mm: Fold ra_submit() into do_sync_mmap_readahead() " David Howells
2020-09-02 15:45 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159906150036.663183.11566577279669811013.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox