From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3F4C433E6 for ; Tue, 1 Sep 2020 07:50:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B538C2071B for ; Tue, 1 Sep 2020 07:50:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gu+J64Tk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B538C2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F9526B005C; Tue, 1 Sep 2020 03:50:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A9B56B005D; Tue, 1 Sep 2020 03:50:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BE636B0062; Tue, 1 Sep 2020 03:50:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 053656B005C for ; Tue, 1 Sep 2020 03:50:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BE768180AD806 for ; Tue, 1 Sep 2020 07:50:32 +0000 (UTC) X-FDA: 77213720304.03.power64_2307e7027096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 91D1328A4E8 for ; Tue, 1 Sep 2020 07:50:32 +0000 (UTC) X-HE-Tag: power64_2307e7027096 X-Filterd-Recvd-Size: 5357 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 07:50:32 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id d22so335105pfn.5 for ; Tue, 01 Sep 2020 00:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=jx4ijV48pwkIXlEWTCV3kDv1viRliVSaJ9ejxp3xhoM=; b=Gu+J64Tks9uYyPaMRIQ/8V2pHoO5Lffox20RipKXlRjHDaPSkNEA9w/P9gzP7tuiXC pqFcnhhXZHsX6nGtN/2hA+LrfaCqvjyhkaMz+JsgD8pvANzp+gZpwrMlINQf3wKGWLoi RLl6DdPsasJ8DfrRa3440bJk1+NyvyXYJHyOH1VIUF2mTmtRFopcolxtdJFRV06xeC03 e+1WzE3ACXeKt2eqqaee4n3luLhIUXd2Ury98fv7hy5SO7K5VMeoK/vhITl3WUAEOlxy KSDsVXYY/RBz6VHjcUD7DoDCk001RSF2ObOP3LSXqfol9qzhEECJszREEsFEzSypJxqp XQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=jx4ijV48pwkIXlEWTCV3kDv1viRliVSaJ9ejxp3xhoM=; b=j/0a6DBNx9NGfVBB03JHzMeAkE2xoJBeOgezKweM8KodFZku6u9RN44LGE4ROVANxS MB9GBumxrTtejhz9HyRJT2yLiucb5jr4FttA5zN7dEBve8kI0lT5OOw2TP1fHe6Hj/HM WeEA25SOUrPRKWlwuOcbWUz2VreX7WkTl747m1ezpiNmLTjiVzignXNBnn4vGQZifR8D xRNYDJWmAATodIfJEyJa49i4hVgbIaTNGzRTXz0g7jYNKzs4p+uDh0ol4FWktkAU3GlD Sx5Tb26rJBW4GWCv+1rZBnkqqnq2E0utr3Vp/sAiBnSFfsbB+Aj0vxAAvFBaVtjMGVr1 ShlA== X-Gm-Message-State: AOAM5325/ccf+G8ShF2iExYTitxXkOyac38QP/CE0VIi7Ww/iTGz1pSc 3lsfYymKS046HZN0DuP4AMY= X-Google-Smtp-Source: ABdhPJySDrdLwU7jnwyr/UTlWsUOS+xFQepQCqThWcvpUucdNdxugC+OL2ioqTY/JTHWg9DOYbezpg== X-Received: by 2002:a63:4c57:: with SMTP id m23mr439797pgl.77.1598946631169; Tue, 01 Sep 2020 00:50:31 -0700 (PDT) Received: from localhost ([203.185.249.227]) by smtp.gmail.com with ESMTPSA id s1sm1171322pgh.47.2020.09.01.00.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 00:50:30 -0700 (PDT) Date: Tue, 01 Sep 2020 17:50:24 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 09/23] m68k: use asm-generic/mmu_context.h for no-op implementations To: Geert Uytterhoeven Cc: Arnd Bergmann , Linux-Arch , Linux Kernel Mailing List , linux-m68k , Linux MM References: <20200826145249.745432-1-npiggin@gmail.com> <20200826145249.745432-10-npiggin@gmail.com> <1598941313.t5y1w43jgl.astroid@bobo.none> In-Reply-To: MIME-Version: 1.0 Message-Id: <1598945161.7wv2e8mu4h.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 91D1328A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Geert Uytterhoeven's message of September 1, 2020 5:03 pm: > Hi Nick, >=20 > On Tue, Sep 1, 2020 at 8:23 AM Nicholas Piggin wrote: >> Excerpts from Geert Uytterhoeven's message of August 27, 2020 7:33 pm: >> > On Wed, Aug 26, 2020 at 4:53 PM Nicholas Piggin wr= ote: >> >> Cc: Geert Uytterhoeven >> >> Cc: linux-m68k@lists.linux-m68k.org >> >> Signed-off-by: Nicholas Piggin >> > >> > With the below fixed: >> > Acked-by: Geert Uytterhoeven >> > >> >> --- a/arch/m68k/include/asm/mmu_context.h >> >> +++ b/arch/m68k/include/asm/mmu_context.h >> >> @@ -79,19 +76,6 @@ static inline void switch_mm(struct mm_struct *pre= v, struct mm_struct *next, >> >> set_context(tsk->mm->context, next->pgd); >> >> } >> >> >> >> -/* >> >> - * After we have set current->mm to a new value, this activates >> >> - * the context for the new mm so we see the new mappings. >> >> - */ >> >> -static inline void activate_mm(struct mm_struct *active_mm, >> >> - struct mm_struct *mm) >> >> -{ >> >> - get_mmu_context(mm); >> >> - set_context(mm->context, mm->pgd); >> >> -} >> > >> > Assumed switch_mm() in [PATCH v2 01/23] is revived with the above body= . >> >> I'm not sure what you mean here. We can remove this because it's a copy >> of switch_mm above, and that's what the new header defaults to if you >> don't provide an active_mm. >=20 > IC. I thought it started relying on for this= , > where you removed switch_mm(). >=20 > Seems I missed the definition above. It's supposed to all build incrementally, I'll try to make sure it's right... >=20 >> Patch 1 should not have changed that, it should only affect the nommu >> architectures (and actually didn't touch m68k because it was not using >> the asm-generic/mmu_context.h header). >=20 > OK. Sorry for the noise. No problem thanks for looking at it. Thanks, Nick