From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2879C433E2 for ; Tue, 1 Sep 2020 07:09:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABE68204EC for ; Tue, 1 Sep 2020 07:09:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lXBGg1pT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABE68204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 49B7D6B0055; Tue, 1 Sep 2020 03:09:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 425536B005A; Tue, 1 Sep 2020 03:09:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ED8D6B005C; Tue, 1 Sep 2020 03:09:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 123C46B0055 for ; Tue, 1 Sep 2020 03:09:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CB97D181AEF1E for ; Tue, 1 Sep 2020 07:09:30 +0000 (UTC) X-FDA: 77213616900.04.queen98_060b7e327096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 9D2428009EAD for ; Tue, 1 Sep 2020 07:09:30 +0000 (UTC) X-HE-Tag: queen98_060b7e327096 X-Filterd-Recvd-Size: 6444 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 07:09:30 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id m8so287333pfh.3 for ; Tue, 01 Sep 2020 00:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=jFgH868brKLfolG8ClhHF9TtNA3LHrtGgMA4zxAiKX0=; b=lXBGg1pTqn6cby0WgpOe3/q47uedcKbwy1UqSIzT6KgmufWJuQxrOoKcdUDcd6c0FB wxDe+BzsSkSf/ZsTcdMlFn8n0qtwjIOY1FNVQVRsuX+JX0I3QopCxJtSdXL182io0Hxv snQXH27sz8ZOgxhixuD9Il92w2qq0U53YTe5i/flbm12Tqe5qieAFyEzzBNQvBSJxATc CFC8owh4UiGrCzHKI4q7VFcsviOX/0TnqVMTS66tG795pMo7UKiv0Q1yPUQI0SnK1qRH 1fpabcG8UpprkbzupiPnCrPNP8p98/XHl2dfGHxuuPTOkJRkjndY2tsjbjnLhZfkcAid 7xAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=jFgH868brKLfolG8ClhHF9TtNA3LHrtGgMA4zxAiKX0=; b=RZD1Phm6mHAsRGDoNCqfbvDd7D5jZ6im/G4gP8R5ufSqP2bkdRIxdewiYdWmQlSrwr Bvr7KSZSUxc9JYU4KZWYTom5EtzBu7WmxT8eeLRgTFqBGjKdKCI8y7OliVXp0BgZObEo 6G15SwpOmzX77pIyTHzDb5wFa3cUVSbei4HiEmBotiLZK1r/wezABVDVAbcXGfKfTYLl XVzlSRM57iX7fAnHM/+t7kjiyAewcFeTclb+jj4EO1bY0aBnws+dVxwuYX65C0nzQBxk WQAvIXFIwwZohPt01ZqwNKE8g7qbAyADONTuj+SuOcQ19PN0yfMS4p7Y4cmNapqpOFzG o2Rg== X-Gm-Message-State: AOAM5309byP0qNNqamiH8cNRh3vOgkE06MPcV4H9NrcAO+PITu3nLnwY BAA/3WPp7Pha4/CWC+QgfC6wKRwLbxE= X-Google-Smtp-Source: ABdhPJw8IvUUs2LGl7PRJUTj57KcLBnaKUUSmv/YtwZ3U7UATVswK2AawtjMtjLfDcaS087AMzr53A== X-Received: by 2002:aa7:9685:: with SMTP id f5mr556166pfk.232.1598944169271; Tue, 01 Sep 2020 00:09:29 -0700 (PDT) Received: from localhost ([203.185.249.227]) by smtp.gmail.com with ESMTPSA id z26sm537750pfa.55.2020.09.01.00.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 00:09:28 -0700 (PDT) Date: Tue, 01 Sep 2020 17:09:22 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 10/23] microblaze: use asm-generic/mmu_context.h for no-op implementations To: linux-arch@vger.kernel.org, Michal Simek , Michal Simek Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20200826145249.745432-1-npiggin@gmail.com> <20200826145249.745432-11-npiggin@gmail.com> <4d2bdc87-f39c-3737-0aa8-b2efe7b2d93e@monstr.eu> <1598940875.v2bbea400c.astroid@bobo.none> <2daa0a52-5e48-8078-cfeb-bd8ff29cc992@xilinx.com> In-Reply-To: <2daa0a52-5e48-8078-cfeb-bd8ff29cc992@xilinx.com> MIME-Version: 1.0 Message-Id: <1598944138.dirzqy8hof.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9D2428009EAD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Michal Simek's message of September 1, 2020 4:41 pm: >=20 >=20 > On 01. 09. 20 8:15, Nicholas Piggin wrote: >> Excerpts from Michal Simek's message of September 1, 2020 12:15 am: >>> >>> >>> On 26. 08. 20 16:52, Nicholas Piggin wrote: >>>> Cc: Michal Simek >>>> Signed-off-by: Nicholas Piggin >>>> --- >>>> arch/microblaze/include/asm/mmu_context_mm.h | 8 ++++---- >>>> arch/microblaze/include/asm/processor.h | 3 --- >>>> 2 files changed, 4 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/arch/microblaze/include/asm/mmu_context_mm.h b/arch/micro= blaze/include/asm/mmu_context_mm.h >>>> index a1c7dd48454c..c2c77f708455 100644 >>>> --- a/arch/microblaze/include/asm/mmu_context_mm.h >>>> +++ b/arch/microblaze/include/asm/mmu_context_mm.h >>>> @@ -33,10 +33,6 @@ >>>> to represent all kernel pages as shared among all contexts. >>>> */ >>>> =20 >>>> -static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_s= truct *tsk) >>>> -{ >>>> -} >>>> - >>>> # define NO_CONTEXT 256 >>>> # define LAST_CONTEXT 255 >>>> # define FIRST_CONTEXT 1 >>>> @@ -105,6 +101,7 @@ static inline void get_mmu_context(struct mm_struc= t *mm) >>>> /* >>>> * We're finished using the context for an address space. >>>> */ >>>> +#define destroy_context destroy_context >>>> static inline void destroy_context(struct mm_struct *mm) >>>> { >>>> if (mm->context !=3D NO_CONTEXT) { >>>> @@ -126,6 +123,7 @@ static inline void switch_mm(struct mm_struct *pre= v, struct mm_struct *next, >>>> * After we have set current->mm to a new value, this activates >>>> * the context for the new mm so we see the new mappings. >>>> */ >>>> +#define activate_mm activate_mm >>>> static inline void activate_mm(struct mm_struct *active_mm, >>>> struct mm_struct *mm) >>>> { >>>> @@ -136,5 +134,7 @@ static inline void activate_mm(struct mm_struct *a= ctive_mm, >>>> =20 >>>> extern void mmu_context_init(void); >>>> =20 >>>> +#include >>>> + >>>> # endif /* __KERNEL__ */ >>>> #endif /* _ASM_MICROBLAZE_MMU_CONTEXT_H */ >>>> diff --git a/arch/microblaze/include/asm/processor.h b/arch/microblaze= /include/asm/processor.h >>>> index 1ff5a82b76b6..616211871a6e 100644 >>>> --- a/arch/microblaze/include/asm/processor.h >>>> +++ b/arch/microblaze/include/asm/processor.h >>>> @@ -122,9 +122,6 @@ unsigned long get_wchan(struct task_struct *p); >>>> # define KSTK_EIP(task) (task_pc(task)) >>>> # define KSTK_ESP(task) (task_sp(task)) >>>> =20 >>>> -/* FIXME */ >>>> -# define deactivate_mm(tsk, mm) do { } while (0) >>>> - >>>> # define STACK_TOP TASK_SIZE >>>> # define STACK_TOP_MAX STACK_TOP >>>> =20 >>>> >>> >>> I am fine with the patch but I pretty much don't like that commit >>> message is empty and there is only subject. >>> With fixing that you can add my: >>> Acked-by: Michal Simek >>=20 >> Thanks for the review, will do. Any suggestion for a useful commit messa= ge? >=20 > What about? > Wire asm-generic/mmu_context.h to provide generic empty hooks for arch > code simplification. Sure I'll add it. Thanks, Nick