From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866C2C433E6 for ; Tue, 1 Sep 2020 06:24:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3671A20FC3 for ; Tue, 1 Sep 2020 06:24:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u/8xKySa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3671A20FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CDAB2900002; Tue, 1 Sep 2020 02:24:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAFF76B005A; Tue, 1 Sep 2020 02:24:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B79B4900002; Tue, 1 Sep 2020 02:24:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 9EA046B0055 for ; Tue, 1 Sep 2020 02:24:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 618DA824556B for ; Tue, 1 Sep 2020 06:24:01 +0000 (UTC) X-FDA: 77213502282.01.verse55_1a1553727096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 7E9F110048E1F for ; Tue, 1 Sep 2020 06:23:50 +0000 (UTC) X-HE-Tag: verse55_1a1553727096 X-Filterd-Recvd-Size: 4658 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 06:23:50 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id h12so143009pgm.7 for ; Mon, 31 Aug 2020 23:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=RVGLHamJzIsi2NPjK9hiUaVNhWfKazmqgrgVWvgKEHQ=; b=u/8xKySagQqUxNK94lZKIgRUUzmd+kNZBlVT095jfGRKwLcRzmv2xy2s+ZfLwXqtgQ P7hlJKRJaerCDkgROptY+FHAS8AJhu0ygp1h2yGBnXYlud/cuxQRKHiONIKBwsLFM+og FlWBsXuxhVqT+jGhz8HXYTIVtbh0IEYyZbkk7Tn/mjqdwrM5vMaWWmsyXBcrTbQ7TRaN LX9pjncHTcPhjUV4VmcHBgASGhV1vXfJTLeu9w3CnuUpS9NMv8/Ao6IdQz/USBEnasNM 28MPFs47TCVMKdHti+xFDxzFU7yereCiyF8rZamDfG2RvFpYv+QRsdItbsMHgjFkf//P +BBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=RVGLHamJzIsi2NPjK9hiUaVNhWfKazmqgrgVWvgKEHQ=; b=jpTevgtuvM1goNb3/ic+jcozgxvnFCaTJZa5aHCeEn4GxOcXGVDI0tu1DFU6D3SU4C VoaqbLkMGgDCRpIchcXASc+18rQmwI+B22e+YJhhjnw8mYh7jr6NOIaOSEepdzk7ZYew ig/2IK2nLg3m06+IDveaBwbOeQwzt9lCRxZLHrVwN97hoUHvqREPNCjBbWdOqY/PGlE8 WCxvcZ9f9mRt4fVhXwPoKOQWLcSE8lFU6ryDRJgnEo29Hcs/00/YbNILtUyZMtqmC6w9 r1Xm/JpYhKVX4sA5bAzQOQ8Bdl+DZu/OYFxLXHPs4chfk+hFOoFtSP1KhX7ZfrJ3+INf rU8w== X-Gm-Message-State: AOAM533iT03FmryRoR6+4IQgw8f90yC2t7EWmy7YFQAxHJsauYV4Wmad 1n+71f0NawCPmyIFHFefPlcw1L4DTQE= X-Google-Smtp-Source: ABdhPJxcnRzndGcAWpqS1MuYZXOgZ414SHNOTOUHPUuMitSjLhvCnI030JLXSMoPjWtiVx2ujhJTUw== X-Received: by 2002:aa7:8c0f:: with SMTP id c15mr432295pfd.284.1598941429288; Mon, 31 Aug 2020 23:23:49 -0700 (PDT) Received: from localhost ([203.185.249.227]) by smtp.gmail.com with ESMTPSA id w203sm358260pfc.97.2020.08.31.23.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 23:23:48 -0700 (PDT) Date: Tue, 01 Sep 2020 16:23:43 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 09/23] m68k: use asm-generic/mmu_context.h for no-op implementations To: Geert Uytterhoeven Cc: Arnd Bergmann , Linux-Arch , Linux Kernel Mailing List , linux-m68k , Linux MM References: <20200826145249.745432-1-npiggin@gmail.com> <20200826145249.745432-10-npiggin@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <1598941313.t5y1w43jgl.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7E9F110048E1F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Geert Uytterhoeven's message of August 27, 2020 7:33 pm: > On Wed, Aug 26, 2020 at 4:53 PM Nicholas Piggin wrote= : >> Cc: Geert Uytterhoeven >> Cc: linux-m68k@lists.linux-m68k.org >> Signed-off-by: Nicholas Piggin >=20 > With the below fixed: > Acked-by: Geert Uytterhoeven >=20 >> --- a/arch/m68k/include/asm/mmu_context.h >> +++ b/arch/m68k/include/asm/mmu_context.h >> @@ -79,19 +76,6 @@ static inline void switch_mm(struct mm_struct *prev, = struct mm_struct *next, >> set_context(tsk->mm->context, next->pgd); >> } >> >> -/* >> - * After we have set current->mm to a new value, this activates >> - * the context for the new mm so we see the new mappings. >> - */ >> -static inline void activate_mm(struct mm_struct *active_mm, >> - struct mm_struct *mm) >> -{ >> - get_mmu_context(mm); >> - set_context(mm->context, mm->pgd); >> -} >=20 > Assumed switch_mm() in [PATCH v2 01/23] is revived with the above body. I'm not sure what you mean here. We can remove this because it's a copy of switch_mm above, and that's what the new header defaults to if you don't provide an active_mm. Patch 1 should not have changed that, it should only affect the nommu architectures (and actually didn't touch m68k because it was not using the asm-generic/mmu_context.h header). Thanks, Nick