From: Nicholas Piggin <npiggin@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2 09/23] m68k: use asm-generic/mmu_context.h for no-op implementations
Date: Tue, 01 Sep 2020 16:23:43 +1000 [thread overview]
Message-ID: <1598941313.t5y1w43jgl.astroid@bobo.none> (raw)
In-Reply-To: <CAMuHMdX5qo+2XpEm5QNbuwWRn508Ewee9rHYtmCBadj0x=3VnA@mail.gmail.com>
Excerpts from Geert Uytterhoeven's message of August 27, 2020 7:33 pm:
> On Wed, Aug 26, 2020 at 4:53 PM Nicholas Piggin <npiggin@gmail.com> wrote:
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: linux-m68k@lists.linux-m68k.org
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> With the below fixed:
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>> --- a/arch/m68k/include/asm/mmu_context.h
>> +++ b/arch/m68k/include/asm/mmu_context.h
>> @@ -79,19 +76,6 @@ static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next,
>> set_context(tsk->mm->context, next->pgd);
>> }
>>
>> -/*
>> - * After we have set current->mm to a new value, this activates
>> - * the context for the new mm so we see the new mappings.
>> - */
>> -static inline void activate_mm(struct mm_struct *active_mm,
>> - struct mm_struct *mm)
>> -{
>> - get_mmu_context(mm);
>> - set_context(mm->context, mm->pgd);
>> -}
>
> Assumed switch_mm() in [PATCH v2 01/23] is revived with the above body.
I'm not sure what you mean here. We can remove this because it's a copy
of switch_mm above, and that's what the new header defaults to if you
don't provide an active_mm.
Patch 1 should not have changed that, it should only affect the nommu
architectures (and actually didn't touch m68k because it was not using
the asm-generic/mmu_context.h header).
Thanks,
Nick
next prev parent reply other threads:[~2020-09-01 6:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:52 [PATCH v2 00/23] Use asm-generic for mmu_context no-op functions Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 01/23] asm-generic: add generic MMU versions of mmu context functions Nicholas Piggin
2020-08-26 18:13 ` kernel test robot
2020-09-01 6:49 ` Mike Rapoport
2020-09-01 7:14 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 02/23] alpha: use asm-generic/mmu_context.h for no-op implementations Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 03/23] arc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 04/23] arm: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 05/23] arm64: " Nicholas Piggin
2020-08-26 15:25 ` Catalin Marinas
2020-08-26 16:20 ` Nicholas Piggin
2020-10-27 9:59 ` Naresh Kamboju
2020-10-27 15:08 ` Arnd Bergmann
2020-08-26 18:42 ` kernel test robot
2020-08-26 18:57 ` kernel test robot
2020-08-26 23:55 ` kernel test robot
2020-08-26 14:52 ` [PATCH v2 06/23] csky: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 07/23] hexagon: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 08/23] ia64: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 09/23] m68k: " Nicholas Piggin
2020-08-27 9:33 ` Geert Uytterhoeven
2020-09-01 6:23 ` Nicholas Piggin [this message]
2020-09-01 7:03 ` Geert Uytterhoeven
2020-09-01 7:50 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 10/23] microblaze: " Nicholas Piggin
2020-08-31 14:15 ` Michal Simek
2020-09-01 6:15 ` Nicholas Piggin
2020-09-01 6:41 ` Michal Simek
2020-09-01 7:09 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 11/23] mips: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 12/23] nds32: " Nicholas Piggin
2020-08-28 10:09 ` Greentime Hu
2020-08-26 14:52 ` [PATCH v2 13/23] nios2: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 14/23] openrisc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 15/23] parisc: " Nicholas Piggin
2020-08-29 9:09 ` Helge Deller
2020-08-26 14:52 ` [PATCH v2 16/23] powerpc: " Nicholas Piggin
2020-09-01 7:30 ` Michael Ellerman
2020-08-26 14:52 ` [PATCH v2 17/23] riscv: " Nicholas Piggin
2020-08-26 16:42 ` Pekka Enberg
2020-08-26 14:52 ` [PATCH v2 18/23] s390: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 19/23] sh: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 20/23] sparc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 21/23] um: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 22/23] x86: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 23/23] xtensa: " Nicholas Piggin
2020-08-26 20:12 ` [PATCH v2 00/23] Use asm-generic for mmu_context no-op functions Arnd Bergmann
2020-08-30 10:18 ` Mike Rapoport
2020-09-01 6:17 ` Nicholas Piggin
2020-09-01 6:54 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598941313.t5y1w43jgl.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox