From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F9BC433E1 for ; Fri, 21 Aug 2020 11:11:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 63C3220738 for ; Fri, 21 Aug 2020 11:11:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="raPLPjcf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63C3220738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6CD48D0040; Fri, 21 Aug 2020 07:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1D0D8D0008; Fri, 21 Aug 2020 07:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32C28D0040; Fri, 21 Aug 2020 07:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id BE1998D0008 for ; Fri, 21 Aug 2020 07:11:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7D7CE1E00 for ; Fri, 21 Aug 2020 11:11:27 +0000 (UTC) X-FDA: 77174309814.09.lake23_3508aa327038 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 57D12180AD804 for ; Fri, 21 Aug 2020 11:11:27 +0000 (UTC) X-HE-Tag: lake23_3508aa327038 X-Filterd-Recvd-Size: 4333 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 11:11:26 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id d188so915096pfd.2 for ; Fri, 21 Aug 2020 04:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=O0JOI3uzd7ucCmR5qeZbGG+pRLYOys3ZnqIcbO7aSA8=; b=raPLPjcfRS5fGs6GsJeKHoRE7KZtMB/Kmt/+3TpNhYGZEkTmc9rqs5EaeEt2jXkwmR Pjke8YLKuCt52Qjfrrzo1cjJGbM51qa/lguoTsbuRVTntBeFV6YmmbbY91kIBTfhraZt ep/meXsgBak78BLiUDvktrLgzmxL4hY2nlMLVL2+jskO41rg2XgfixV0JeShCBEwUwgm Yfwnv4PKI0n4/IwHrjUQClJ3xVdb5ixzGgAZH867Y6KYjBhurxhwLe5fjo/8pWJU+JOg 50NpKfxgOc2nACLFdQ9cfs9a4AaFxhk/lnmJj9JSeIi1b8zizgfXdoE1Obx8JMc2l11N 2ttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=O0JOI3uzd7ucCmR5qeZbGG+pRLYOys3ZnqIcbO7aSA8=; b=cpekPxCSHcHsRfL5g36th6v2kYnOS5zXS+wsleuwo1u9cltg/ZJAFBd0KRVGsp93nO VSpHIxfekSvEabaQbwIiwDOml2xYTXcmbgvESx9MBbtuj6GJJOJQXcXEbbSHgn16P95D kB2AGvYnPQkEY896vMTrLyEU235g48YGxrnQKZltgO1GCl02VvTQuZl9xaXXNIADXU2M EHv16zN1wbEkBZMj8/2fjNRdfm3ljJzVakSMh310keAsuVg0c8U90Vx8Cszu3EYP0hlq V/HBvNcnWYik4xZTWJIC6NRWOTq0iMqjqQCaKrRnL5FRHsqGmvKPmO8uCreacRqpulOU kfrQ== X-Gm-Message-State: AOAM533zAIexwcI2BqxTDBxldykohpRVmi6sbtuch2w62IaoTbOrf61f PNgAXdqe11pNOBol8rEEDx0= X-Google-Smtp-Source: ABdhPJyN95KoCLSGpi+TFBy6i2yfFQWUvteLJM7qPop/EXa6ZcjYNEgf2G5C1Xl8hpt0GydW8Ox0Hw== X-Received: by 2002:a65:6287:: with SMTP id f7mr1981459pgv.307.1598008285896; Fri, 21 Aug 2020 04:11:25 -0700 (PDT) Received: from localhost (61-68-212-105.tpgi.com.au. [61.68.212.105]) by smtp.gmail.com with ESMTPSA id o7sm1613042pjl.48.2020.08.21.04.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 04:11:25 -0700 (PDT) Date: Fri, 21 Aug 2020 21:11:19 +1000 From: Nicholas Piggin Subject: Re: [PATCH v5 0/8] huge vmalloc mappings To: Andrew Morton , Christophe Leroy , linux-mm@kvack.org Cc: Jonathan Cameron , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Zefan Li References: <20200821044427.736424-1-npiggin@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <1598006399.kdw772nr6n.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 57D12180AD804 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Christophe Leroy's message of August 21, 2020 3:47 pm: >=20 >=20 > Le 21/08/2020 =C3=A0 06:44, Nicholas Piggin a =C3=A9crit=C2=A0: >> I made this powerpc-only for the time being. It shouldn't be too hard to >> add support for other archs that define HUGE_VMAP. I have booted x86 >> with it enabled, just may not have audited everything. >=20 > I like this series, but if I understand correctly it enables huge=20 > vmalloc mappings only for hugepages sizes matching a page directory=20 > levels, ie on a PPC32 it would work only for 4M hugepages. Yeah it really just uses the HUGE_VMAP mapping which is already there. > On the 8xx, we only have 8M and 512k hugepages. Any change that it can=20 > support these as well one day ? The vmap_range interface can now handle that, then adding support is the main work. Either make it weak and arch can override it, or add some arch helpers to make the generic version create the huge pages if it's not too ugly. Then you get those large pages for ioremap for free. The vmalloc part to allocate and try to map a bigger page size and use=20 it is quite trivial to change from PMD to an arch specific size. Thanks, Nick