linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: use blk_io_schedule() for avoiding task hung in sync io
@ 2020-08-03 13:36 Xianting Tian
  0 siblings, 0 replies; only message in thread
From: Xianting Tian @ 2020-08-03 13:36 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel

swap_readpage() does the sync io for one page, the io is not big, normally,
the io can be finished quickly, but it may take long time or wait forever
in case of io failure or discard.
This patch is to use blk_io_schedule() instead of io_schedule() to avoid
task hung and crash(when set /proc/sys/kernel/hung_task_panic) in case of
above exception occur.
We have prevented task hung in submit_bio_wait(), blk_execute_rq() and
__blkdev_direct_IO().

Signed-off-by: Xianting Tian <xianting_tian@126.com>
---
 mm/page_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_io.c b/mm/page_io.c
index e8726f3..5d52f7b 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -424,7 +424,7 @@ int swap_readpage(struct page *page, bool synchronous)
 			break;
 
 		if (!blk_poll(disk->queue, qc, true))
-			io_schedule();
+			blk_io_schedule();
 	}
 	__set_current_state(TASK_RUNNING);
 	bio_put(bio);
-- 
1.8.3.1



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-03 13:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 13:36 [PATCH] mm: use blk_io_schedule() for avoiding task hung in sync io Xianting Tian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox