From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35059C433E1 for ; Mon, 20 Jul 2020 02:49:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C694420724 for ; Mon, 20 Jul 2020 02:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CdpDdzgw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C694420724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A8C66B0003; Sun, 19 Jul 2020 22:49:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 133EB6B0005; Sun, 19 Jul 2020 22:49:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 023FD6B0006; Sun, 19 Jul 2020 22:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id E06A86B0003 for ; Sun, 19 Jul 2020 22:49:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 296618248047 for ; Mon, 20 Jul 2020 02:49:09 +0000 (UTC) X-FDA: 77056922418.14.pear11_560acf126f21 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id F1CD318002DCF for ; Mon, 20 Jul 2020 02:49:08 +0000 (UTC) X-HE-Tag: pear11_560acf126f21 X-Filterd-Recvd-Size: 4371 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 02:49:08 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id mn17so9446232pjb.4 for ; Sun, 19 Jul 2020 19:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=MHAQuV7wqFXE2gTJXyIGBJkkSS+/2fb6/SqEN+IMJpU=; b=CdpDdzgwHD6KDQNhDlu82DlmyWWjZ/tE6sKRBv4R+f6DNQQk3obKV028wEN8NHQe44 ivpvsS3MyhDPBNTyPoxFeJ7XFObRFd8p5lDUvQWmEZLORZNpDUmsYDtCQtQBjWEph5Jh 4UbuZHebtzX2AFmWHCKMSDCUU6CrNCv//mNYHHIp2g9SX31oJe5mi7j4eUwDehYc29+H ylq58SwOBe5p0fVnwPLea9PkWcZG7C43Si1MqGYbndJH1usUs612RiFtiYzoCGbhlNlq NNAAB8WinXGMNgzrYPheT/QyRtpMt8ZSuDngMgeue+/ZpaK+oENAp4e9Kc8cNPqxAKW8 HoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=MHAQuV7wqFXE2gTJXyIGBJkkSS+/2fb6/SqEN+IMJpU=; b=t78c/CrWvna2Of/UlvSpt1E8ARlZESY/zo/A+5/EMc0nOdmJuTk56/dd80vW4p8ldL P9M/su9EKxNRTJsxjfLAIcRzY9zQ09aUSgYSbGWtQSHVvXfEzZaF0vkbOQ81PSk6IKYW BX4IrU1YeGFuDbxm4AdFqE4rQT3OhjXxSRE54/BxCgwgwCmUVHfW3kKnwh/0VIYlgvph l03lWU2SBxDFbvcbN/SNLUvvQGuctPdp7kPINHApm3btnWA5DnKhL/pvlybaNy27ss55 36MH9C7ZXC1SFUncxlLIlqLejo6QbzZ4jzx5pFH8LEq/5prd0/sWG0+jDTVQoe2cYRyZ HYRg== X-Gm-Message-State: AOAM531O86/s5vSyoiG8f/5WnDSdVP7vPPwT/t8gXFthUqySdENUJcSO SfS8V6BHEjKMEXJb1U34MJQ3jjNe X-Google-Smtp-Source: ABdhPJyKOJqndxCg3mIhcaYDZPJSsTmVuKMyFWNLPeExLhzmb2sdnZbuRmCL/dLOi+bJNfrzWai0hA== X-Received: by 2002:a17:90a:6448:: with SMTP id y8mr21541193pjm.142.1595213347563; Sun, 19 Jul 2020 19:49:07 -0700 (PDT) Received: from localhost (110-174-173-27.tpgi.com.au. [110.174.173.27]) by smtp.gmail.com with ESMTPSA id f131sm13389215pgc.14.2020.07.19.19.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2020 19:49:06 -0700 (PDT) Date: Mon, 20 Jul 2020 12:49:02 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings To: linux-mm@kvack.org, Zefan Li Cc: =?iso-8859-1?q?Borislav=0A?= Petkov , Catalin Marinas , "H. Peter Anvin" , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , =?iso-8859-1?q?Thomas=0A?= Gleixner , Will Deacon , x86@kernel.org References: <20200413125303.423864-1-npiggin@gmail.com> <20200413125303.423864-5-npiggin@gmail.com> <0e43e743-7c78-fb86-6c36-f42e6184d32c@huawei.com> In-Reply-To: <0e43e743-7c78-fb86-6c36-f42e6184d32c@huawei.com> MIME-Version: 1.0 Message-Id: <1595213278.m30kayfsvu.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F1CD318002DCF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Zefan Li's message of July 20, 2020 12:02 pm: >> +static int vmap_pages_range_noflush(unsigned long start, unsigned long = end, >> + pgprot_t prot, struct page **pages, >> + unsigned int page_shift) >> +{ >> + if (page_shift =3D=3D PAGE_SIZE) { >=20 > Is this a typo of PAGE_SHIFT? Oh good catch, yeah that'll always be going via the one-at-a-time route=20 and slow down the small page vmaps. Will fix. Thanks, Nick >=20 >> + return vmap_small_pages_range_noflush(start, end, prot, pages); >> + } else { >> + unsigned long addr =3D start; >> + unsigned int i, nr =3D (end - start) >> page_shift; >> + >> + for (i =3D 0; i < nr; i++) { >> + int err; >> + >> + err =3D vmap_range_noflush(addr, >> + addr + (1UL << page_shift), >> + __pa(page_address(pages[i])), prot, >> + page_shift); >> + if (err) >> + return err; >> + >> + addr +=3D 1UL << page_shift; >> + } >> + >> + return 0; >> + } >> +} >> + >=20