From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@lge.com, Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Roman Gushchin <guro@fb.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Michal Hocko <mhocko@suse.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v5 4/9] mm/migrate: clear __GFP_RECLAIM to make the migration callback consistent with regular THP allocations
Date: Mon, 13 Jul 2020 15:41:52 +0900 [thread overview]
Message-ID: <1594622517-20681-5-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1594622517-20681-1-git-send-email-iamjoonsoo.kim@lge.com>
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
new_page_nodemask is a migration callback and it tries to use a common
gfp flags for the target page allocation whether it is a base page or a
THP. The later only adds GFP_TRANSHUGE to the given mask. This results
in the allocation being slightly more aggressive than necessary because
the resulting gfp mask will contain also __GFP_RECLAIM_KSWAPD. THP
allocations usually exclude this flag to reduce over eager background
reclaim during a high THP allocation load which has been seen during
large mmaps initialization. There is no indication that this is a
problem for migration as well but theoretically the same might happen
when migrating large mappings to a different node. Make the migration
callback consistent with regular THP allocations.
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
mm/migrate.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/migrate.c b/mm/migrate.c
index 3b3d918..1cfc965 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1547,6 +1547,11 @@ struct page *new_page_nodemask(struct page *page,
}
if (PageTransHuge(page)) {
+ /*
+ * clear __GFP_RECALIM to make the migration callback
+ * consistent with regular THP allocations.
+ */
+ gfp_mask &= ~__GFP_RECLAIM;
gfp_mask |= GFP_TRANSHUGE;
order = HPAGE_PMD_ORDER;
}
--
2.7.4
next prev parent reply other threads:[~2020-07-13 6:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 6:41 [PATCH v5 0/9] clean-up the migration target allocation functions js1304
2020-07-13 6:41 ` [PATCH v5 1/9] mm/page_isolation: prefer the node of the source page js1304
2020-07-13 6:41 ` [PATCH v5 2/9] mm/migrate: move migration helper from .h to .c js1304
2020-07-13 6:41 ` [PATCH v5 3/9] mm/hugetlb: unify migration callbacks js1304
2020-07-13 6:41 ` js1304 [this message]
2020-07-13 7:36 ` [PATCH v5 4/9] mm/migrate: clear __GFP_RECLAIM to make the migration callback consistent with regular THP allocations Michal Hocko
2020-07-13 7:52 ` Vlastimil Babka
2020-07-14 0:44 ` Joonsoo Kim
2020-07-13 6:41 ` [PATCH v5 5/9] mm/migrate: make a standard migration target allocation function js1304
2020-07-13 7:53 ` Vlastimil Babka
2020-07-14 0:46 ` Joonsoo Kim
2020-07-13 6:41 ` [PATCH v5 6/9] mm/mempolicy: use a standard migration target allocation callback js1304
2020-07-13 6:41 ` [PATCH v5 7/9] mm/page_alloc: remove a wrapper for alloc_migration_target() js1304
2020-07-13 6:41 ` [PATCH v5 8/9] mm/memory-failure: " js1304
2020-07-13 6:41 ` [PATCH v5 9/9] mm/memory_hotplug: " js1304
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594622517-20681-5-git-send-email-iamjoonsoo.kim@lge.com \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hch@infradead.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox