linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@lge.com, Vlastimil Babka <vbabka@suse.cz>,
	Christoph Hellwig <hch@infradead.org>,
	Roman Gushchin <guro@fb.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Michal Hocko <mhocko@suse.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v5 1/9] mm/page_isolation: prefer the node of the source page
Date: Mon, 13 Jul 2020 15:41:49 +0900	[thread overview]
Message-ID: <1594622517-20681-2-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1594622517-20681-1-git-send-email-iamjoonsoo.kim@lge.com>

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

For locality, it's better to migrate the page to the same node rather than
the node of the current caller's cpu.

Acked-by: Roman Gushchin <guro@fb.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/page_isolation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index f6d07c5..aec26d9 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -309,5 +309,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
 
 struct page *alloc_migrate_target(struct page *page, unsigned long private)
 {
-	return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]);
+	int nid = page_to_nid(page);
+
+	return new_page_nodemask(page, nid, &node_states[N_MEMORY]);
 }
-- 
2.7.4



  reply	other threads:[~2020-07-13  6:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13  6:41 [PATCH v5 0/9] clean-up the migration target allocation functions js1304
2020-07-13  6:41 ` js1304 [this message]
2020-07-13  6:41 ` [PATCH v5 2/9] mm/migrate: move migration helper from .h to .c js1304
2020-07-13  6:41 ` [PATCH v5 3/9] mm/hugetlb: unify migration callbacks js1304
2020-07-13  6:41 ` [PATCH v5 4/9] mm/migrate: clear __GFP_RECLAIM to make the migration callback consistent with regular THP allocations js1304
2020-07-13  7:36   ` Michal Hocko
2020-07-13  7:52   ` Vlastimil Babka
2020-07-14  0:44     ` Joonsoo Kim
2020-07-13  6:41 ` [PATCH v5 5/9] mm/migrate: make a standard migration target allocation function js1304
2020-07-13  7:53   ` Vlastimil Babka
2020-07-14  0:46     ` Joonsoo Kim
2020-07-13  6:41 ` [PATCH v5 6/9] mm/mempolicy: use a standard migration target allocation callback js1304
2020-07-13  6:41 ` [PATCH v5 7/9] mm/page_alloc: remove a wrapper for alloc_migration_target() js1304
2020-07-13  6:41 ` [PATCH v5 8/9] mm/memory-failure: " js1304
2020-07-13  6:41 ` [PATCH v5 9/9] mm/memory_hotplug: " js1304

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594622517-20681-2-git-send-email-iamjoonsoo.kim@lge.com \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=hch@infradead.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox