From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0378BC27C4F for ; Fri, 21 Jun 2024 05:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACB06B04A7; Fri, 21 Jun 2024 01:08:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C456B04A8; Fri, 21 Jun 2024 01:08:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224936B04A9; Fri, 21 Jun 2024 01:08:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 044356B04A7 for ; Fri, 21 Jun 2024 01:08:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 757A1C08DB for ; Fri, 21 Jun 2024 05:08:08 +0000 (UTC) X-FDA: 82253714256.13.D8122AB Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf13.hostedemail.com (Postfix) with ESMTP id 8B9A220004 for ; Fri, 21 Jun 2024 05:08:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=411VLvKM; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718946479; a=rsa-sha256; cv=none; b=GAjmT+f1vLCUgk4rEwaNGj/5OVF8wXrhFmf68M8CD/tuK4ZcK/ooC0TdK+DYVuGkUr5ucG 1Ik8k5LD8w2odzuFQnBZvLJWUcH1/NDiZXJkg4+IQisC9J3+WfffQ3sZBixImW/WdRVtQ+ kr7r7x4GINH6tNE0v5586gDjWsoHZIw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=411VLvKM; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718946479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nvkbLRrbGjOkgieY3cO8LfFeVN6dBo6m0P5rvSyPRVQ=; b=7j3ja2eAyaGiTbMLOeEd3mA7sYx5p8MGpW3sLhOw0F45Tj+gn3hV199PadIoYBt9smfRuW xkr2YNMPhf+mALSznb6kLDFHCMLlAnVBmXOO7TvdUyHxmeNzIC9bbnHZ4hyZfVsi45+J5K vksfCWuZpneKnENCFcVGzY2S1trqeNw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718946484; bh=O+nHjv3muSzRtuvuuUzuGvB5XhfVur/SQhzT0Hwt4Wk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=411VLvKM/4J+v8Ysik4EqTFiGpMaUs8Dck92Xw820XQUk+aijmN0EprLrX6bYFfdG uxaJz7ZmncDu+5UU1vzfVBdnlYInTbvGKx4pOOSEXKTwQ0BZkE9Q9NbMtz26XWiBlV zY4yZdoYGqwV4ZZR4hCLQW7NrB/frPTzbjDwR5wj3H8KWtqUTN4vYCBrwBF1FWTSi6 rWrtSrsDwGRhhlJpgZnkvD5XY4rBoT1d6Pl73PNeGDJk+IqKTTAwVO4jWus2NPksb2 39tafoIXFz9HHW0jAoom/GNHDKLxAiAq9OdqS9OT6vwOZRHpftp60zxdJjuTZPOElv GVqZvLRsfc8kQ== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id C3B063781144; Fri, 21 Jun 2024 05:08:00 +0000 (UTC) Message-ID: <1591a354-d999-45b4-aff2-357fa7612634@collabora.com> Date: Fri, 21 Jun 2024 10:08:38 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors To: Jiaqi Yan , nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, osalvador@suse.de References: <20240620184856.600717-1-jiaqiyan@google.com> <20240620184856.600717-4-jiaqiyan@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240620184856.600717-4-jiaqiyan@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8B9A220004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pcyo789w7e5eyrexksr139f7n7of6cp6 X-HE-Tag: 1718946486-841459 X-HE-Meta: U2FsdGVkX1+TT1L5ZGctI9wt4knO+33kTABhJWh5hPtcYyks/ZOHfPB9xS0JFI95V+cX4lRZ18acSXV7Vov7rqVDEh6RbWYylRh1tuDtm6gR7ru9gPGyEq7+4Ybbq2C1O62NS4lcxZp5urPD9fumThMUGJdX8Pgmfm+mS/ql/xIx8KHZnHXw2RJ2Np6R7jJDpj0Bd9vHi+rRQvqrmh8amLQRtge/1HePhvp90jutw7/BIllzWn+f8rq3snmkSd3og2o3p8WBpgfiUnEEFftAVEEe3WXe7SiFGu4dauZvBhDKAkFdP8qW69+QSQFfa2RRCTH8bw06dDc+WxbOBGA/K5poXx8C0GPQwcSqJwGHn3yJlIWCtsHVBgDMV7MJRalXpGxrChKlUfSZwUdIoQvHFB+v/riNBtpQdsyFhCZnjzz0MI59XxWSw7It4x+aYactGJBU2cXgpIvm2xQP59lFiLWI9gsHIGIY6lmwpQkL+z3LU/HXdEebcQVURJRqlzaqUyYuf6VoRNKClp8IZw+uf/00F9LhDUfZwonCn54n6+umpJ5srtqmJJobeh60IR8shqL710j0XDilB+JkA9F4YR8nw+0WD4p2wLdFC+h/OAWV+BrrTxUWQi6NUx50nMBS2/NTS7kbmvE68jeaSIPaC5QWxKer5jStrpd/Y69ayEZXfFQ0HWIIGRwQkAhN+M29QkKuorcN+xkKQ0IJtb8U1KdioRBXccqUgGzvsPStEdjz/j8f3kUVaCLEg7Ig0x1HInhzrBpRi00ZtMghE422vWBYvoyv3hmcA78enlgr2ddjQyBkZwB0h+9ZfWiAORWisDwB5gf3NdtAl5u8ZqgCcYnyFzLEvbwusD1ZwMLSGiSIDfPuWk5PlJmxCRCV0KQ/RIiGj2a3dFVGn1BP9FbYbNUOQ66j9IfFRJmXNJAeGiyOC7JDkAObBmImi0AjIAnDPkrZzRYOYHnfLtTTyPY w6fHbY3s c4Qt26Rnfap2+Go9EzQX8nlmdShpLhvsUoDMo5s27OwmIK5Jx/p2p/oyPY/ds7/YHeN/msFpFoJ3zOMyCXuOpQx1osebnhS1hbk8YCj1zAvgee7oTQbIQkuQTBAQ3TsmjrP7hERMKjraJtCSSiiV7E668HlJ7trNHMFgnxaXrJTerFCz7g1lvRAR9lehhb5LnrPQl8b7+n5xuUT2yP7JRwXd2tuCG96AKv1IHVI7h8l8oiAB2IQsncFjhpZLRJIgyKuImIL3Fhz7jfer3lynBMj7IaU6sLGJ43a1FJElz38REqphRpy5aNRqNaIZxVsW19tO2r9+QAOGP+4tW8OPlJdKR1aeGD1IwsJL0V+rHJwmN2+R4dQlrFmrjs0YvpWjbXjwLNLiONfVZLrlho3PiLzSj5Uowu3ClyZcmnY+Hx/VC7cNGb2JCx0EieWiN1QVbJFD1yLSg02yO3TZOtawVc12UQzSaUsGMjNz14OkfSb3JWMz+aXtFEL+F+WwYBDphx+lbbbMc3ijI6lwFBgpYn7plSaYKPQVHyvxJ3gzbZ8QDyzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/24 11:48 PM, Jiaqi Yan wrote: > Add regression and new tests when hugepage has correctable memory > errors, and how userspace wants to deal with it: > * if enable_soft_offline=1, mapped hugepage is soft offlined > * if enable_soft_offline=0, mapped hugepage is intact > > Free hugepages case is not explicitly covered by the tests. > > Hugepage having corrected memory errors is emulated with > MADV_SOFT_OFFLINE. > > Signed-off-by: Jiaqi Yan > --- > tools/testing/selftests/mm/.gitignore | 1 + > tools/testing/selftests/mm/Makefile | 1 + > .../selftests/mm/hugetlb-soft-offline.c | 229 ++++++++++++++++++ > tools/testing/selftests/mm/run_vmtests.sh | 4 + > 4 files changed, 235 insertions(+) > create mode 100644 tools/testing/selftests/mm/hugetlb-soft-offline.c > > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore > index 0b9ab987601c..064e7b125643 100644 > --- a/tools/testing/selftests/mm/.gitignore > +++ b/tools/testing/selftests/mm/.gitignore > @@ -6,6 +6,7 @@ hugepage-shm > hugepage-vmemmap > hugetlb-madvise > hugetlb-read-hwpoison > +hugetlb-soft-offline > khugepaged > map_hugetlb > map_populate > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 3b49bc3d0a3b..d166067d75ef 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -42,6 +42,7 @@ TEST_GEN_FILES += gup_test > TEST_GEN_FILES += hmm-tests > TEST_GEN_FILES += hugetlb-madvise > TEST_GEN_FILES += hugetlb-read-hwpoison > +TEST_GEN_FILES += hugetlb-soft-offline > TEST_GEN_FILES += hugepage-mmap > TEST_GEN_FILES += hugepage-mremap > TEST_GEN_FILES += hugepage-shm > diff --git a/tools/testing/selftests/mm/hugetlb-soft-offline.c b/tools/testing/selftests/mm/hugetlb-soft-offline.c > new file mode 100644 > index 000000000000..5701eea4ee48 > --- /dev/null > +++ b/tools/testing/selftests/mm/hugetlb-soft-offline.c > @@ -0,0 +1,229 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Test soft offline behavior for HugeTLB pages: > + * - if enable_soft_offline = 0, hugepages should stay intact and soft > + * offlining failed with EINVAL. > + * - if enable_soft_offline = 1, a hugepage should be dissolved and > + * nr_hugepages/free_hugepages should be reduced by 1. > + * > + * Before running, make sure more than 2 hugepages of default_hugepagesz > + * are allocated. For example, if /proc/meminfo/Hugepagesize is 2048kB: > + * echo 8 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > + */ > + > +#define _GNU_SOURCE > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > + > +#ifndef MADV_SOFT_OFFLINE > +#define MADV_SOFT_OFFLINE 101 > +#endif > + > +#define PREFIX " ... " > +#define EPREFIX " !!! " > + > +enum test_status { > + TEST_PASS = 0, > + TEST_FAILED = 1, > + // From ${ksft_skip} in run_vmtests.sh. > + TEST_SKIPPED = 4, > +}; Include ../kselftest.h and use macros from there instead of redifining. Also try to use helper functions from same header file to mark the test pass/fail or exit the test entirely. You can look at soft-dirty.c how that is written. -- BR, Muhammad Usama Anjum