From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9272C433DF for ; Sat, 23 May 2020 09:41:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D3E0206DD for ; Sat, 23 May 2020 09:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D3E0206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A6D880008; Sat, 23 May 2020 05:41:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857D380007; Sat, 23 May 2020 05:41:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76D1280008; Sat, 23 May 2020 05:41:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 5B89580007 for ; Sat, 23 May 2020 05:41:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 149504DD9 for ; Sat, 23 May 2020 09:41:38 +0000 (UTC) X-FDA: 76847491476.12.debt55_829c2bbac6f55 X-HE-Tag: debt55_829c2bbac6f55 X-Filterd-Recvd-Size: 2636 Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sat, 23 May 2020 09:41:37 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21269533-1500050 for multiple; Sat, 23 May 2020 10:41:25 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200522051931.54191-1-jhubbard@nvidia.com> References: <20200522051931.54191-1-jhubbard@nvidia.com> To: Andrew Morton , John Hubbard From: Chris Wilson Cc: Souptick Joarder , Matthew Wilcox , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Tvrtko Ursulin , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, John Hubbard Subject: Re: [PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() Message-ID: <159022688563.11139.3402294435382936623@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Sat, 23 May 2020 10:41:25 +0100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting John Hubbard (2020-05-22 06:19:27) > The purpose of posting this series is to launch a test in the > intel-gfx-ci tree. (The patches have already been merged into Andrew's > linux-mm tree.) >=20 > This applies to today's linux.git (note the base-commit tag at the > bottom). >=20 > Changes since V1: >=20 > * Fixed a bug in the refactoring patch: added FOLL_FAST_ONLY to the > list of gup_flags *not* to WARN() on. This lead to a failure in the > first intel-gfx-ci test run [1]. >=20 > [1] https://lore.kernel.org/r/159008745422.32320.5724805750977048669@buil= d.alporthouse.com Ran this through our CI, warn and subsequent lockup were gone. That lockup is worrying me now, but that doesn't seem to be an issue from this series. The i915 changes were simple enough, I would have computed the pin flags just once (since the readonly bit is static, that would be interesting if that was allowed to change mid gup :) Reviewed-by: Chris Wilson -Chris