From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5465FC021B1 for ; Thu, 20 Feb 2025 18:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD912440204; Thu, 20 Feb 2025 13:14:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8892280323; Thu, 20 Feb 2025 13:14:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B505C440204; Thu, 20 Feb 2025 13:14:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 98730280323 for ; Thu, 20 Feb 2025 13:14:51 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 146EF828F0 for ; Thu, 20 Feb 2025 18:14:51 +0000 (UTC) X-FDA: 83141123982.06.74C24B3 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf25.hostedemail.com (Postfix) with ESMTP id 0EE6EA0009 for ; Thu, 20 Feb 2025 18:14:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AcG6VmVa; spf=pass (imf25.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740075289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oObvhUMt4cjhg8s99kHncplBjGhp4cxwDQbmBZl3oBw=; b=du6dPMVLznhGVw2L2UgBCLzsgMRAqVzzvuSVV1z8idkPXTbwXWUkMUubv9rW+D5f1W5Cd7 BVEsSjyM1pWPQkoj8/1Nay99d0p0kFzpGC6xXjhVwwYL0+LTguiuv56hOv31hb2W71fMoM GPKQIJvlYfY0HUeCLh6orASX1qjSuaE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AcG6VmVa; spf=pass (imf25.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740075289; a=rsa-sha256; cv=none; b=xTtA3REZpxDIr9QRr9ZV/jBZGmI1EBb70K39sSioh+3fBRyo/btVaJP1gpowEs7YVH4Njw in5T0WiYlJqkbh0r5w5eosoxSTUEVmUQHM9SQ+hGQjynf/m3Lt1ycFaFI2HjiqOSCyB6NE v5l1RbTIWu8Y2qy6u6CQbn11B+wWlAU= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220d39a5627so20202795ad.1 for ; Thu, 20 Feb 2025 10:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740075288; x=1740680088; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oObvhUMt4cjhg8s99kHncplBjGhp4cxwDQbmBZl3oBw=; b=AcG6VmVaP9cZHifQ86ZpZHTEKZ3PcVzhYiQQqUYecHUYjIcpXdYW7TXnikwzSywPPb lrg50gv6/VgI072QJ2ShOLaiz4tX+RQwjFv5wmPmL1GBsYf9HsNQjqQKA4UlS1vTADmU FB7N3ehP+aLar9oGh3QYwhiFlQEFuxiUrARsHOabP7vdp0CayS9Z9v8tdeWhj4VpxUxN Otd3xBsmGXngApidGSLjRplT2PEk6EieM4p41PBfrYCvD4JynHCDU63M7qz4EeYjgIxj So0hvqxUr0myIFPD/4QuuhwRa8LR5ZA7iGX01kQKCWSsP/aL1A9OljXlHfZsHZKwJX+M k2mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740075288; x=1740680088; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oObvhUMt4cjhg8s99kHncplBjGhp4cxwDQbmBZl3oBw=; b=qRL0504DkCss2FU6W0ZSieivNfbeyCpu9tvdLarYks5Ma6axsdPUJhBNUzdGg5L2FN +Hxgj37KIWdwgm1aTEGf20QqKACJWA6OH/S/F+h7GpYpEryEbyZaOG83Idy2tF4Freig aWEaNUqtLx0Rah9kPCpSt7IDX4G19ZXbuf8MDG55g25hFJN6WtT75tc39+C0aSJnFVFk JVkyUQk0zhiKasCoyBor6ZgAUKQBmpCwlFD/5dBaN3ldOh/7yxIuPEP5abwEqq+cL8P0 VCCWcxiKmvCCpP7a3+dQc6+hU790EVrzPuG5FjFgI46D9mblUQ4+Lr+7N2izyqP+naCb wm5g== X-Forwarded-Encrypted: i=1; AJvYcCXY+wIkMsL8bcnRT7O16C8PdW5DHSpDZZNdaT4O9pHkupPjDUU5kHIPglLlCVIGxMM2qmpe/pJoRg==@kvack.org X-Gm-Message-State: AOJu0Ywb3Gjc0Mky+XS6w0gn7RRBTaVCD+1h2qTw0lOjefp/9Z7DBolQ VNz5e431MimN2LDex48e2byCahTUGekFbwTY0FNN1TziYxqoJM1Q X-Gm-Gg: ASbGncueJvKPFvlbKeVGxQ8vtlxUdX4MtZannFdX+7aXvHo8QVBgXPKpqTKiGrO8BHG Q9tlXaHS1EzWL2NRdyO+QVFWPLDOUYVMseKdiNaMBTmMs3rPANgk/2/T4056hwW8CYbbQJ0TYiu msCoKaEFuFCkAuBBlVtohp7kTl9A62TgbadAyjR4s8QQAulVks5CtX7TCSk1FLToaD6oMPZp/xr QQkKAZsOusXx4mPzKoN+PaySRawqFMnGR5y4za0VUOZmFdFJ7XIQCcEfsiZqPrmTDxfurgECrMd g8XBuTwyTdQpLsfFcMPbg1LFaExGD61mrjpa5hkoCSiGzPc4 X-Google-Smtp-Source: AGHT+IFBSASVMdXYA+Pmss8qMHeZIJWACcBNMLBfrQ8MGynyGryeSXT+bNOgbCZ9MwyLBI8E67CvBg== X-Received: by 2002:a17:902:e889:b0:221:7b4a:476c with SMTP id d9443c01a7336-2219ff9ee80mr1369405ad.18.1740075287787; Thu, 20 Feb 2025 10:14:47 -0800 (PST) Received: from ?IPV6:2a03:83e0:1151:15:23bb:b0c4:3d98:81d7? ([2620:10d:c090:500::4:3465]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d536738csm124699655ad.68.2025.02.20.10.14.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 10:14:47 -0800 (PST) Message-ID: <158ea157-3411-45e6-bca4-fb70d67fb1c5@gmail.com> Date: Thu, 20 Feb 2025 10:14:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] cgroup: separate rstat trees To: Yosry Ahmed , Shakeel Butt Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250218031448.46951-1-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0EE6EA0009 X-Stat-Signature: rwxbonbyn73em1zqmfhrdtwh6m335abd X-Rspamd-Server: rspam03 X-HE-Tag: 1740075288-859208 X-HE-Meta: U2FsdGVkX1/KJqt8S0Ln+zbhWYV8IHvcnsnK8tPvBffnlQh2v6TbzQ/KwlDWpjK7YnqUQBgPFLVmhT1V8YzARfyKEKTgUkt27g3vVpBQ5o8LEMBHv29ldB8+Y9f2W2ctFDqT92Zp+je2653Bq+8hoxYHWsR8gUyUxX/cyvXk6aZoi6nHnfgPawBYJxc7Zh2WlaStaV3W1S5rzGcw3H/RYtpzfMgrHIXZw4sN3jvgCzuSaDuCrCYxOBT2mqTPdH1MskCYv257n1LupSktpWnpDy/CyUGcSG+b1c9v06oe2rtyZzbpeh/f+YgFWYLyLLRePtjOalGyTDUXqtQZlpBNbh51wUSGms+auZkghy7u4KYpoTSey/FqV2dx2Jr/as60uumT3YNMY0IW+UG4fLvoV2haRqkimxEmeohUWITF4FPSpbZcGxV/FNIyuhyfaZI2g06meoGf1lkPujXVg85pR7TDwqPY5J8LDEsQbrb918LeVRme3yWm8RIYsrbYr+7J+7WghZhPNr3NCLBJyT0+batRmi/QAewEQnNs6jcfpo7WHQzrwcTqdStHcVEquKQvwxa5Ew43GLlILwgBIpPFXxN733D4KGrxg+RfNE6Fg1HwFNtM22QcwZqDUMhEvgxOtGq1NH0ZICEOO0XRhdGekFH4maTb06a+KJFvERu7Tc0bvSFSa59MgnGVSDj1YHetyumkQahB5iZdlnYt19htdupZ++NliLEzAI9iUPuu8OAPRF1b/DWQ6DR30hJLau9Ik84pSMerGuTP+XjjpaYoTqhURpWvedgEF7GWwtmYx1nOgjgAQact7P/x8C6Twra2ECxFSKnupOX21jzYQfje8bvNfp53gUHZZA6SOfPx+uJpnDO5PNgYrZg+v3WZhjjnoNA+9kgSlBGQ2h36JdADTz57B0uDwA0yL+sQjIvFO4XpBOKojFTYpeX3j7cjjMlKc3gm/zzWQE0Fp/xQYSO lgiDBgnm IY/N6o3YTkyLg+gkPz/g1te/1Ur5as/qptzFmowQCGiGUTcLqVPc2cxz1Io1z5o/BbU7r863eldshn3OBc9uVUiek8G1SaubOqn+AoH7u846uE796Vt/KXCGXJgRkCrXb3x/eKh/W0SdxSRjdyAU4vbM2RlwlzTAUo2+XmdW1O83M5bWOvJBA/x4n3NGO3eIrq8Jg+LyvgJizP2oR4QJYy0Lurh+Hh4/UkWBhulgKiQzQArVVueGEfcltbeiEJd3XE6lBZMJ3fSI3nSFFLv6K2QK1+gYcTmiCvtddg82mOMrxriIF0bvKr0901a8gJcPhPHUjV3l9pXriKHYxq0YhU6RwiDP8+6NcdN4uvBUQ+abkF/U96UOwljIM7CP5asIe0k9hLblpn8fps+w8imZiIVHPFmZ/GAHK96K3kGZx58t15g123/s/uxF6ZNDHpfTmn5OC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000218, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/20/25 9:59 AM, Yosry Ahmed wrote: > On Thu, Feb 20, 2025 at 09:53:33AM -0800, Shakeel Butt wrote: >> On Thu, Feb 20, 2025 at 05:26:04PM +0000, Yosry Ahmed wrote: >>> >>> Another question is, does it make sense to keep BPF flushing in the >>> "self" css with base stats flushing for now? IIUC BPF flushing is not >>> very popular now anyway, and doing so will remove the need to support >>> flushing and updating things that are not css's. Just food for thought. >>> >> >> Oh if this simplifies the code, I would say go for it. > > I think we wouldn't need cgroup_rstat_ops and some of the refactoring > may not be needed. It will also reduce the memory overhead, and keep it > constant regardless of using BPF which is nice. Yes, this is true. cgroup_rstat_ops was only added to allow cgroup_bpf to make use of rstat. If the bpf flushing remains tied to cgroup_subsys_state::self, then the ops interface and supporting code can be removed. Probably stating the obvious but the trade-off would be that if bpf cgroups are in use, they would account for some extra overhead while flushing the base stats. Is Google making use of bpf- based cgroups?