From: Souptick Joarder <jrdr.linux@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Souptick Joarder <jrdr.linux@gmail.com>
Subject: [PATCH] mm/gup.c: Handle error at earliest for incorrect nr_pages value
Date: Fri, 1 May 2020 01:41:58 +0530 [thread overview]
Message-ID: <1588277518-21425-1-git-send-email-jrdr.linux@gmail.com> (raw)
As per documentation, pin_user_pages_fast() & get_user_pages_fast()
will return 0, if nr_pages <= 0. But this can be figure out only after
going inside the internal_get_user_pages_fast().
This can be handled early. Adding a check for the same.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
mm/gup.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mm/gup.c b/mm/gup.c
index 50681f0..a13aaa6 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2817,6 +2817,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
*/
if (WARN_ON_ONCE(gup_flags & FOLL_PIN))
return -EINVAL;
+ if (nr_pages <= 0)
+ return 0;
/*
* The caller may or may not have explicitly set FOLL_GET; either way is
@@ -2854,6 +2856,8 @@ int pin_user_pages_fast(unsigned long start, int nr_pages,
/* FOLL_GET and FOLL_PIN are mutually exclusive. */
if (WARN_ON_ONCE(gup_flags & FOLL_GET))
return -EINVAL;
+ if (nr_pages <= 0)
+ return 0;
gup_flags |= FOLL_PIN;
return internal_get_user_pages_fast(start, nr_pages, gup_flags, pages);
--
1.9.1
next reply other threads:[~2020-04-30 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:11 Souptick Joarder [this message]
2020-04-30 21:23 ` Andrew Morton
2020-04-30 21:24 ` Ira Weiny
2020-05-01 21:16 ` Souptick Joarder
2020-05-01 21:33 ` John Hubbard
2020-05-01 21:46 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588277518-21425-1-git-send-email-jrdr.linux@gmail.com \
--to=jrdr.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox