From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A584C3815B for ; Mon, 20 Apr 2020 08:01:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B988A206D5 for ; Mon, 20 Apr 2020 08:01:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dluh6E6W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B988A206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AAA68E000D; Mon, 20 Apr 2020 04:01:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 633898E0003; Mon, 20 Apr 2020 04:01:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FBE58E000D; Mon, 20 Apr 2020 04:01:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 3093A8E0003 for ; Mon, 20 Apr 2020 04:01:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB32121E4 for ; Mon, 20 Apr 2020 08:01:02 +0000 (UTC) X-FDA: 76727487564.15.frogs05_6065f81c21e19 X-HE-Tag: frogs05_6065f81c21e19 X-Filterd-Recvd-Size: 5648 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 08:01:02 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id t16so3654571plo.7 for ; Mon, 20 Apr 2020 01:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=alIHvAxi8J0gI0njDpPhNJX2AYMkhsIun+mstYhBeyw=; b=Dluh6E6WcvI4lCJpWZru0HsbFamltg/pDLxUXPDdcyd7U73u2Tjuy76v2EqKxIPN1D 8HfOy0yDAfSEDDCFo8/d107vtsHmZaPhqvlyuQC6EY7L6XeoHELvFxBJ+av+24J71Huc GAFwaB5ev5fbbKZzTocmnb1TzfiI2wBFoh6YUP/5jZgdyE9z6PTenV2AJH3xF+wZOBvw 5+ToqCayK/FEfBPb92ENTgpdeHppCkVkswO803xRpv1Re7dpzo0T90E8rDMsjFk0qdzs 5SUonL8Eo+6uRoQ26ijPU006Jhx7mPwwucsRAyrOe4E8tRVDb8AuMFIVbT9R8yLx9fqx GI6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=alIHvAxi8J0gI0njDpPhNJX2AYMkhsIun+mstYhBeyw=; b=VRR27u7ZWPOqgthpP8zQ3KFmxrxb4kZC30T7/V6OBcq5tT5TT5Jb37DqX4qhvM9pqe 4F9ol03hQMYFJILulUUYQUNCH0K+0CNwnjxPWxVf9Yrqp8lq425lFssPj77RNY34Lixj Yb2LYoG2EdABBSvm87hMdgIMJTIgJ4w06EkV7CysRCvQWOY76248aoowW+S6qOCf2u0t rkfjPPEB7Z7r9jAETuZhXbQxePV4+YMhuaqyr8PslvNEhVZK98rHfuzt6wcydXOXnxcl E0rwAPF7g4K77IeCY2wWf6XmmESdpFmjvE8iYKL/6KPSIAcC2dZbPT+C0jEdkVn08ekv naIg== X-Gm-Message-State: AGi0PuZNtgYeg48qJodwqvMPrWBM0WNlUeNdVi5RRanFe07IXhLi9Dqx 7kYhpPk6NoAQn6dXdczNIQY= X-Google-Smtp-Source: APiQypJDuKPiCH8RK1OqawZFGOeQwm51EdRyDy79rVDacXxLqIv3PWmH4AI8ZUJeDdV3IBbkNclw8Q== X-Received: by 2002:a17:902:968a:: with SMTP id n10mr15110926plp.74.1587369661464; Mon, 20 Apr 2020 01:01:01 -0700 (PDT) Received: from localhost.localdomain ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id n9sm314947pjt.29.2020.04.20.01.00.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 01:01:01 -0700 (PDT) From: js1304@gmail.com X-Google-Original-From: iamjoonsoo.kim@lge.com To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , Joonsoo Kim Subject: [PATCH 08/10] mm: separate PageHighMem() and PageHighMemZone() use case Date: Mon, 20 Apr 2020 16:59:40 +0900 Message-Id: <1587369582-3882-9-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1587369582-3882-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1587369582-3882-1-git-send-email-iamjoonsoo.kim@lge.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Joonsoo Kim Until now, PageHighMem() is used for two different cases. One is to check if there is a direct mapping for this page or not. The other is to check the zone of this page, that is, weather it is the highmem type zone or not. Now, we have separate functions, PageHighMem() and PageHighMemZone() for each cases. Use appropriate one. Note that there are some rules to determine the proper macro. 1. If PageHighMem() is called for checking if the direct mapping exists or not, use PageHighMem(). 2. If PageHighMem() is used to predict the previous gfp_flags for this page, use PageHighMemZone(). The zone of the page is related to the gfp_flags. 3. If purpose of calling PageHighMem() is to count highmem page and to interact with the system by using this count, use PageHighMemZone(). This counter is usually used to calculate the available memory for an kernel allocation and pages on the highmem zone cannot be available for an kernel allocation. 4. Otherwise, use PageHighMemZone(). It's safe since it's implementation is just copy of the previous PageHighMem() implementation and won't be changed. I apply the rule #3 for this patch. Signed-off-by: Joonsoo Kim --- mm/memory_hotplug.c | 2 +- mm/page_alloc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 8573d2fc..85361e2 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -593,7 +593,7 @@ void generic_online_page(struct page *page, unsigned int order) __free_pages_core(page, order); totalram_pages_add(1UL << order); #ifdef CONFIG_HIGHMEM - if (PageHighMem(page)) + if (PageHighMemZone(page)) totalhigh_pages_add(1UL << order); #endif } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d469384..9997f87 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7470,7 +7470,7 @@ void adjust_managed_page_count(struct page *page, long count) atomic_long_add(count, &page_zone(page)->managed_pages); totalram_pages_add(count); #ifdef CONFIG_HIGHMEM - if (PageHighMem(page)) + if (PageHighMemZone(page)) totalhigh_pages_add(count); #endif } -- 2.7.4