From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF48C2BB1D for ; Tue, 14 Apr 2020 04:04:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1F50206D5 for ; Tue, 14 Apr 2020 04:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="eLlp+rk9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1F50206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 755E18E0003; Tue, 14 Apr 2020 00:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 708678E0001; Tue, 14 Apr 2020 00:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61BE68E0003; Tue, 14 Apr 2020 00:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 4755F8E0001 for ; Tue, 14 Apr 2020 00:04:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0E0EF40CA for ; Tue, 14 Apr 2020 04:04:13 +0000 (UTC) X-FDA: 76705117986.07.gold07_78df9130113b X-HE-Tag: gold07_78df9130113b X-Filterd-Recvd-Size: 5111 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 04:04:11 +0000 (UTC) X-UUID: fb8d16a7e36847f78ef8bd67a06b0e83-20200414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=rvn2PVQiizHx5tZZ+IO9x2+n8wWcsuPFFKqlIz6AgBE=; b=eLlp+rk9NuLw3Q/1mwhbmKBu/Uf6dQuJJfA6R7I/OiGeUUZE8EcqeFuzfT0X/dFl8UVM7Hkx/fkSRRONwpfgd6qmm5fjXI61dNKrrsUF8sP1rckuNX0gIbsgFvVxYuFxiH69Jbw633FivxYQ36tSuU0r+RUT2p3ZCZqWH3/sLGg=; X-UUID: fb8d16a7e36847f78ef8bd67a06b0e83-20200414 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 701018196; Tue, 14 Apr 2020 12:04:07 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Apr 2020 12:04:05 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 14 Apr 2020 12:04:06 +0800 Message-ID: <1586837046.23318.14.camel@mtkswgap22> Subject: Re: [patch 07/35] mm/gup: fix null pointer dereference detected by coverity From: Miles Chen To: Linus Torvalds CC: Andrew Morton , Peter Xu , , Linux-MM , Date: Tue, 14 Apr 2020 12:04:06 +0800 In-Reply-To: References: <20200410143047.bf34a933ce1affdc042c7c80@linux-foundation.org> <20200410213235.M6eTaELL2%akpm@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: T24gRnJpLCAyMDIwLTA0LTEwIGF0IDE1OjI0IC0wNzAwLCBMaW51cyBUb3J2YWxkcyB3cm90ZToN Cj4gT24gRnJpLCBBcHIgMTAsIDIwMjAgYXQgMjozMiBQTSBBbmRyZXcgTW9ydG9uIDxha3BtQGxp bnV4LWZvdW5kYXRpb24ub3JnPiB3cm90ZToNCj4gPg0KPiA+IEluIGZpeHVwX3VzZXJfZmF1bHQo KSwgaXQgaXMgcG9zc2libGUgdGhhdCB1bmxvY2tlZCBpcyBOVUxMLA0KPiA+IHNvIHdlIHNob3Vs ZCB0ZXN0IHVubG9ja2VkIGJlZm9yZSB1c2luZyBpdC4NCj4gDQo+IFRoaXMgc2VlbXMgd3Jvbmcu DQo+IA0KPiA+IEZvciBleGFtcGxlLCBpbiBhcmNoL2FyYy9rZXJuZWwvcHJvY2Vzcy5jLCBOVUxM IGlzIHBhc3NlZA0KPiA+IHRvIGZpeHVwX3VzZXJfZmF1bHQoKS4NCj4gPg0KPiA+ICAgICAgICAg cmV0ID0gZml4dXBfdXNlcl9mYXVsdChjdXJyZW50LCBjdXJyZW50LT5tbSwgKHVuc2lnbmVkIGxv bmcpIHVhZGRyLA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGQVVMVF9GTEFH X1dSSVRFLCBOVUxMKTsNCj4gDQo+IFllcywgYnV0IGl0IGRvZXNuJ3Qgc2V0IEZBVUxUX0ZMQUdf QUxMT1dfUkVUUlksIGV4YWN0bHkgX2JlY2F1c2VfDQo+ICd1bmxvY2tlZCcgaXMgTlVMTC4NCj4g DQo+IEJhc2ljYWxseSwgcmV0cnkgaXMgZnVuZGFtZW50YWxseSB0aWVkIHRvIHRoYXQgInVubG9j a2VkIiBmbGFnLiBZb3UNCj4gY2FuJ3QgYXNrIGZvciByZXRyeSB3aXRob3V0IGFsc28gc2F5aW5n ICJwbGVhc2UgdGVsbCBtZSBpZiB5b3UNCj4gdW5sb2NrZWQgdGhlIG1tYXBfc2VtIGR1cmluZyB0 aGUgcmV0cnkiLiBTbyB0aGUgdHdvIGdvIGhhbmQgaW4gaGFuZA0KPiB0aGVyZS4NCj4gDQo+IFNv IEkgdGhpbmsgdGhpcyBpcyBqdXN0IGNvdmVyaXR5IG5vdCB1bmRlcnN0YW5kaW5nIHRoZSBydWxl cy4NCj4gDQo+IE9yIG1heWJlIEknbSB0aGUgb25lIG1pc3Npbmcgc29tZXRoaW5nLiBEaWQgeW91 IGFjdHVhbGx5IHNlZSBhIHByb2JsZW0/DQoNClRoYW5rcyBmb3IgdGhlIGV4cGxhbmF0aW9uLCBp dCBpcyBqdXN0IGEgY292ZXJpdHkgaXNzdWUsIG5vdCBhIHJlYWwNCnByb2JsZW0uDQoNCkkgd29y cnkgYWJvdXQgdGhlIGZvbGxvd2luZyBjYXNlOiBzb21lb25lIHBhc3NlcyBGQVVMVF9GTEFHX0FM TE9XX1JFVFJZDQp0byBmaXh1cF91c2VyX2ZhdWx0KCkgd2l0aCB1bmxvY2tlZCA9PSBOVUxMLg0K DQplLmcuLCANCnJldCA9IGZpeHVwX3VzZXJfZmF1bHQoY3VycmVudCwgY3VycmVudC0+bW0sIHVh ZGRyLA0KICAgICAgICAgICAgICAgICAgICAgICBmbGFncyB8IEZBVUxUX0ZMQUdfQUxMT1dfUkVU UlksIE5VTEwpOw0KDQoNCiNkZWZpbmUgRkFVTFRfRkxBR19ERUZBVUxUICAoRkFVTFRfRkxBR19B TExPV19SRVRSWSB8IFwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFVTFRfRkxBR19L SUxMQUJMRSB8IFwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFVTFRfRkxBR19JTlRF UlJVUFRJQkxFKQ0KDQoNCkluIGZpeHVwX3VzZXJfZmF1bHQoKSwgaXQgYWRkcyBGQVVMVF9GTEFH X0FMTE9XX1JFVFJZIGlmIHVubG9ja2VkIGlzIG5vdA0KTlVMTCwgYnV0IGl0IGRvZXMgbm90IHJl bW92ZSBGQVVMVF9GTEFHX0FMTE9XX1JFVFJZIGlmIHVubG9ja2VkIGlzIE5VTEwuDQoNCmludCBm aXh1cF91c2VyX2ZhdWx0KHN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrLCBzdHJ1Y3QgbW1fc3RydWN0 ICptbSwNCiAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgYWRkcmVzcywgdW5zaWdu ZWQgaW50IGZhdWx0X2ZsYWdzLA0KICAgICAgICAgICAgICAgICAgICAgYm9vbCAqdW5sb2NrZWQp DQp7DQouLi4NCglpZiAodW5sb2NrZWQpDQoJCWZhdWx0X2ZsYWdzIHw9IEZBVUxUX0ZMQUdfQUxM T1dfUkVUUlkgfCBGQVVMVF9GTEFHX0tJTExBQkxFOw0KLi4uDQp9DQoNClRoaW5ncyBjb3VsZCBn byB3cm9uZyBpbiB0aGUgYWJvdmUgY2FzZS4NCg0KSSBjaGVja2VkIHRoZSBzb3VyY2UgY29kZSBh bmQgdGhlcmUgaXMgbm8gc3VjaCBjYXNlLiBJIHdvcnJ5IHRvbyBtdWNoDQphYm91dCBpdC4NCg0K ICBNaWxlcw0KPiANCj4gICAgICAgICAgICAgICAgICAgIExpbnVzDQoNCg==