From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1321C2BA2B for ; Sat, 11 Apr 2020 10:12:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52BE520709 for ; Sat, 11 Apr 2020 10:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H5ghIjTE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52BE520709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE3238E00A7; Sat, 11 Apr 2020 06:12:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D93DD8E0007; Sat, 11 Apr 2020 06:12:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA8E98E00A7; Sat, 11 Apr 2020 06:12:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B08B08E0007 for ; Sat, 11 Apr 2020 06:12:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 66EF6181AEF0B for ; Sat, 11 Apr 2020 10:12:06 +0000 (UTC) X-FDA: 76695158652.22.rod31_86c52f6634014 X-HE-Tag: rod31_86c52f6634014 X-Filterd-Recvd-Size: 5622 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 10:12:05 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id m13so2071024pgd.8 for ; Sat, 11 Apr 2020 03:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OVzQqFEoc2Z1cD6F3AZ39C8HuvuCRfqRmrAizJDXF4k=; b=H5ghIjTE3dXCr9y268knH91Kmezn50JifUatYpjYW/SjfnecfvfCJupACkXfY5Dt+7 QePVwbm5NFQeKlpuNP5yH14tqL3hwqVW4BIaZvx3WSibHiPYnnaUFUj3xZAkzHw4HCcZ 7B7XPKyvLH4ljxx74OLtj5oTz6P1VsvWlfvtKzNvYW6QXzA7PmNSnfcctRql/jgOB8da J4hmEOJA08T+0Xj/oZ1RAtrjh5el9os6ARvSpfEjrKymCDixLYN2TFxd4quYmZ6LYmPM WWGONZXQrUqk4gb05UO//aetlh9p/KDRE7Vd8QWRfgwFTGpaPWCQnCl8OtOJqO7JCQEK EOaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OVzQqFEoc2Z1cD6F3AZ39C8HuvuCRfqRmrAizJDXF4k=; b=bhY3J2g9EqQ10zfFKGwqFDszYc9EotL3PcAj6JJFQCbHIGInsPrqVVCyJfLYQT8xz6 Agruk6I8o4ABGdd/3EmfoE7+vK24mx2ugNDOteWW/u0DvT4fjuUE4dfdPTGQYo2o5DmR +nb0lUfCdbU1p9GQIhU3gk67fYYgn2snKODcI/MsKaAOU0TX+aXUyPCES5vbjOdlliLy bWo7/iefozu8fKu/K6TVwu6mMOMx85kKx8xcVkVQBzF/n8zFF/qrUm8pCP7tNc6r45IU qKZ65cduz+kJQUiGADU+N668PtvauMk04gT7n36w1Eu0+R3W8nh/InT/H8CRRIkiXF7c zj6A== X-Gm-Message-State: AGi0PuaybgDJWyYZHMoEDVgH4uJWUO7pqBumGR4YPxxbnvvrvLkbNGIT W08GqIkUqV2NrR+ww2v0QWY= X-Google-Smtp-Source: APiQypKQbz8aTn1sfrN6BusDdI3Yq92Ca9ELoq+jUmugU5nBzKy0iBJ3q3eMxpQwQY8k9Tqpp4yzaQ== X-Received: by 2002:a63:e74b:: with SMTP id j11mr8598511pgk.145.1586599925068; Sat, 11 Apr 2020 03:12:05 -0700 (PDT) Received: from localhost ([43.224.245.179]) by smtp.gmail.com with ESMTPSA id my15sm4120276pjb.28.2020.04.11.03.12.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 11 Apr 2020 03:12:04 -0700 (PDT) From: qiwuchen55@gmail.com To: akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, richard.weiyang@gmail.com, mhocko@suse.com, pankaj.gupta.linux@gmail.com, yang.shi@linux.alibaba.com, cai@lca.pw, bhe@redhat.com Cc: linux-mm@kvack.org, chenqiwu Subject: [RESEND PATCH 1/3] mm: Replace zero-length array with flexible-array member Date: Sat, 11 Apr 2020 18:11:54 +0800 Message-Id: <1586599916-15456-1-git-send-email-qiwuchen55@gmail.com> X-Mailer: git-send-email 1.9.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: chenqiwu The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: chenqiwu --- include/linux/mm.h | 2 +- include/linux/mmzone.h | 2 +- include/linux/swap.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 5a32342..9831bb5 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1718,7 +1718,7 @@ struct frame_vector { unsigned int nr_frames; /* Number of frames stored in ptrs array */ bool got_ref; /* Did we pin pages by getting page ref? */ bool is_pfns; /* Does array contain pages or pfns? */ - void *ptrs[0]; /* Array of pinned pfns / pages. Use + void *ptrs[]; /* Array of pinned pfns / pages. Use * pfns_vector_pages() or pfns_vector_pfns() * for access */ }; diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 1b9de7d..f6b9fa9 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -1147,7 +1147,7 @@ struct mem_section_usage { DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION); #endif /* See declaration of similar field in struct zone */ - unsigned long pageblock_flags[0]; + unsigned long pageblock_flags[]; }; void subsection_map_init(unsigned long pfn, unsigned long nr_pages); diff --git a/include/linux/swap.h b/include/linux/swap.h index b835d8d..e1bbf7a 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -275,7 +275,7 @@ struct swap_info_struct { */ struct work_struct discard_work; /* discard worker */ struct swap_cluster_list discard_clusters; /* discard clusters list */ - struct plist_node avail_lists[0]; /* + struct plist_node avail_lists[]; /* * entries in swap_avail_heads, one * entry per node. * Must be last as the number of the -- 1.9.1