From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A980BC43331 for ; Fri, 3 Apr 2020 07:09:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 67795206A3 for ; Fri, 3 Apr 2020 07:09:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dAnLP0l8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67795206A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE90E8E0008; Fri, 3 Apr 2020 03:09:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E98D48E0007; Fri, 3 Apr 2020 03:09:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8ABD8E0008; Fri, 3 Apr 2020 03:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id BAF718E0007 for ; Fri, 3 Apr 2020 03:09:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7A73A8245578 for ; Fri, 3 Apr 2020 07:09:01 +0000 (UTC) X-FDA: 76665666882.18.sheet27_6bd871510fd05 X-HE-Tag: sheet27_6bd871510fd05 X-Filterd-Recvd-Size: 5071 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 07:09:00 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id z3so2555029pjr.4 for ; Fri, 03 Apr 2020 00:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hUeMyZXwhEwxA2pTgUgOHD5pi6gNLXqmjrpmUkxG2Wo=; b=dAnLP0l83oyhGTyako6RaKdhUPYM2sm93cFTRTBhIxQwG5GVot90Q23ASOMXNYeaCc e3WpsdPG8GrvftSALir2ZwM8f00E0JikYGnknSkgRwcKz6dM34OtYW97TRArgSu5Ec8u 1MBPKYB1v58iJvAbow7BPLttK1QcM8N/xpnxaz1OgDp60bD4lgR4bzg/qZgKXi6LXd+f nvpBIQdHEOjz9Cc7fwtZGEaRNXrEL//pRXlWX+lIxeNAtN+bv0jNYAqZfD6le/ot9ltz ft7QtAMulDGSFlZ2UFn53jB87BWpha02sO3OxTd6KBi175QEewIpNyWdwvtCqZ+pV3nv snww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hUeMyZXwhEwxA2pTgUgOHD5pi6gNLXqmjrpmUkxG2Wo=; b=REVslgq9yljkNfJ1GdCkqHQ9GqgRfaMi+hrmjKI3aCGDGNMy06TTQGZ4RJbyYiWHH8 7AIHrz7SA52YkL/1OevhRm59FOS+yPz1rVBGfI4LfMK7nbIoz+d1+5lc1SLP47z1F4AH tQlA1FTyPJbUJgig9HuYr8FhELtMYgmUx5/ivVD1FedfO5NU1+mfZCsLVekB3HTep0jF F0x6l4rK/INTeHgGuaV03yn34k+ZHcVcXliOdpKRfkMi+SlFgFmkm7rqD9bDWphx8w6M zI2HQRz4bmqWY2dvaXHh9oEfYnb7/LFYsPuXJUNkft0Xwc1NOXoE5DDneAG38lw3ScgM RwsQ== X-Gm-Message-State: AGi0PubrzUBPGj8kDIWCuPKPbQM1MIW+QPmuoc1ZqjHPKiG2hV5edYpn 5nDqJKahum/BMzZySMB0aZc= X-Google-Smtp-Source: APiQypIyc29p12oIot4LSR0q+gQoJiZn73WcptRl8o42ruSnFvv5GeHdiTxoejBZZ6WRIPj6eQ4efw== X-Received: by 2002:a17:902:aa08:: with SMTP id be8mr6119717plb.299.1585897739827; Fri, 03 Apr 2020 00:08:59 -0700 (PDT) Received: from localhost ([43.224.245.179]) by smtp.gmail.com with ESMTPSA id y131sm5135908pfb.78.2020.04.03.00.08.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 03 Apr 2020 00:08:59 -0700 (PDT) From: qiwuchen55@gmail.com To: akpm@linux-foundation.org Cc: alexander.h.duyck@linux.intel.com, willy@infradead.org, vbabka@suse.cz, pankaj.gupta.linux@gmail.com, bhe@redhat.com, mhocko@kernel.org, linux-mm@kvack.org, chenqiwu Subject: [PATCH 1/2] mm: Replace zero-length array with flexible-array member Date: Fri, 3 Apr 2020 15:08:52 +0800 Message-Id: <1585897733-4696-1-git-send-email-qiwuchen55@gmail.com> X-Mailer: git-send-email 1.9.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: chenqiwu The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: chenqiwu --- include/linux/mm.h | 2 +- include/linux/mmzone.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index c54fb96..8dc699a 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1528,7 +1528,7 @@ struct frame_vector { unsigned int nr_frames; /* Number of frames stored in ptrs array */ bool got_ref; /* Did we pin pages by getting page ref? */ bool is_pfns; /* Does array contain pages or pfns? */ - void *ptrs[0]; /* Array of pinned pfns / pages. Use + void *ptrs[]; /* Array of pinned pfns / pages. Use * pfns_vector_pages() or pfns_vector_pfns() * for access */ }; diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 462f687..0e3c685 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -1187,7 +1187,7 @@ static inline unsigned long section_nr_to_pfn(unsigned long sec) struct mem_section_usage { DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION); /* See declaration of similar field in struct zone */ - unsigned long pageblock_flags[0]; + unsigned long pageblock_flags[]; }; void subsection_map_init(unsigned long pfn, unsigned long nr_pages); -- 1.9.1