From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E93C10DCE for ; Thu, 12 Mar 2020 13:33:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C98F206E7 for ; Thu, 12 Mar 2020 13:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="fzPYth0x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C98F206E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BFD0A6B0007; Thu, 12 Mar 2020 09:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BADA96B0008; Thu, 12 Mar 2020 09:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9C1D6B000A; Thu, 12 Mar 2020 09:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 8FFC36B0007 for ; Thu, 12 Mar 2020 09:33:24 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 640D87584 for ; Thu, 12 Mar 2020 13:33:24 +0000 (UTC) X-FDA: 76586801928.26.bone80_8f53e766f52 X-HE-Tag: bone80_8f53e766f52 X-Filterd-Recvd-Size: 3947 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 13:33:23 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id d22so4335614qtn.0 for ; Thu, 12 Mar 2020 06:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=vdp99kBqJfGiQv6F9UTNp9A5C6kAffpbNzB4DpZx8tM=; b=fzPYth0xZm9OoYTE3PiBGE7On1NFZx1IBEPXPEmLQmvwXSpYkIBO+ZoVTnDJU5CJ/B xiHS1SVnGsF03Rof7Nc2jET2WgnrpPhvHwcouzYxDJqMsM9QceNnfPfvshG9KEmmrppn V5FnzxfRhX2qfhuepl8PyNsVttV6kEBPEGsmNVt2c+eHedzggAnwDyas0c6lRnqkwVZD YLiky49Z2jtXp5d+0B7HbeoBZxIokG11FsaR0SMrWu/MDDpwDR3zlbJupasDUf1xxwNl N7B/jT4rukl8RT0RXhWREdysvJTF4NGAl9TjZXQgN1irbTwWXkk0ZS/COqA/Ecxy0IV5 8+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=vdp99kBqJfGiQv6F9UTNp9A5C6kAffpbNzB4DpZx8tM=; b=BMjBZOr80Ob2AN5YZDi7IbstWmztcfrBQJxRcfbBzSne3UUlthdMzWzwsmDMeHnWQW X4V/Ts0RXbaZzEMXsxPWqbN89gpQHZIO3xz11Hp9Ai99vttEQvJeupqkOLiLy4yV9Ef2 sxCkB4Dx3iar/bVtzuS+8jWjBs6tjekao53bSYHg0xprxxCMh5Tny8jGGA4LwEUygNg5 2BAWR+3/sJUD2kRmwhYmHcNh2e200LWxuMemooLwnmELzTnHpWtWwutqebN5G37MZ8ae +bjeOTA2QKgptyVHXsSX9MAfxnsiIKriizKne/vGPHjbplvEWbzNY66+fhGZ5yNrW5a/ AqGA== X-Gm-Message-State: ANhLgQ00WvHColxA92Pe2f9yJpv4FAduTAGqDwQs6MR47oqEslTumTA4 xQwcFgY04YN/iMoRyA1ZGICxzQ== X-Google-Smtp-Source: ADFU+vvDRZeSII7JjTWNMdHX9psSp1KBxs/GLiI1qtL2Ztqq8rO4QK5syjpynATSxvbPS875SqDTgg== X-Received: by 2002:ac8:2bf8:: with SMTP id n53mr7309390qtn.1.1584020002510; Thu, 12 Mar 2020 06:33:22 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id a27sm14228344qto.38.2020.03.12.06.33.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2020 06:33:21 -0700 (PDT) Message-ID: <1584020000.7365.178.camel@lca.pw> Subject: Re: [PATCH v3] mm: hugetlb: optionally allocate gigantic hugepages using cma From: Qian Cai To: Roman Gushchin , Andrew Morton Cc: Michal Hocko , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, Rik van Riel , Andreas Schaufler , Mike Kravetz Date: Thu, 12 Mar 2020 09:33:20 -0400 In-Reply-To: <20200311220920.2487528-1-guro@fb.com> References: <20200311220920.2487528-1-guro@fb.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2020-03-11 at 15:09 -0700, Roman Gushchin wrote: > +#ifdef CONFIG_CMA > +static unsigned long hugetlb_cma_size __initdata; > + > +static int __init cmdline_parse_hugetlb_cma(char *p) > +{ > + unsigned long long val; > + char *endptr; > + > + if (!p) > + return -EINVAL; > + > + val =3D simple_strtoull(p, &endptr, 0); > + hugetlb_cma_size =3D memparse(p, &p); > + return 0; > +} > + Here will generate a compilation warning, mm/hugetlb.c: In function 'cmdline_parse_hugetlb_cma': mm/hugetlb.c:5548:21: warning: variable 'val' set but not used [-Wunused-= but- set-variable] =C2=A0 unsigned long long val; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^~~ Also, the comments for simple_strtoull() in lib/vsprintf.c said, "This function is obsolete. Please use kstrtoull instead."