From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3A2C10F25 for ; Fri, 6 Mar 2020 20:44:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1E13206CC for ; Fri, 6 Mar 2020 20:44:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="sVQp0SNz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1E13206CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50FF86B000A; Fri, 6 Mar 2020 15:44:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C2476B000C; Fri, 6 Mar 2020 15:44:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AE996B000D; Fri, 6 Mar 2020 15:44:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 245106B000A for ; Fri, 6 Mar 2020 15:44:48 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D89631EE6 for ; Fri, 6 Mar 2020 20:44:47 +0000 (UTC) X-FDA: 76566116214.09.line79_46b21d8607914 X-HE-Tag: line79_46b21d8607914 X-Filterd-Recvd-Size: 7633 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Mar 2020 20:44:45 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id v15so2768652qto.2 for ; Fri, 06 Mar 2020 12:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=VIytyDCq7f0kiHtZyAPYuhAfxkdQ6oPpVlPc91ezlzw=; b=sVQp0SNzavyEmQgQgPO7gOzbjdxNHOBGOKLb2+i6xH5nTB6ZP6ociRcsHZFKZahWzv lVQMhT0TucKZE0jr1svRTaAecWqS9Lak/5QCDTaDSkOc6vq9y74In5QZ3C0vju5Y/YSJ seKiYzybOes0y2OWOOVvb45ZEYoBXTTL7/NQZvUeV5Umj/iFPmYuELjQmpwwRG/RbM00 WMRsRryr0bUnfhZtTUXyLUc60zizY1/bRX7olknPmplQ8VZG+HU7CqTLWPWwICtR5QAk sPbgocfLtbClg6uijm1uY7WawL446OXTMUcERTf+StMaVG507VDTlm1AAJaTPJabMPKz 9fdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=VIytyDCq7f0kiHtZyAPYuhAfxkdQ6oPpVlPc91ezlzw=; b=h3ARUDIJagnfZPMpSGEuFJOWyQ+eJauNVC5a0TyteykCHAV+LZ6f8iwcg0JgZ3/W8n rPW9r0mgWLFGKfqGWW5+VkAENOE9LHh2HZpISP2YAcQw+EbSxQ56TJu0XoG2iTuXsVXW jL3WAhTE9S3H2anwbSm1rbAZ2LEZHqYU1GHuQeDnVXnVpaVem+P72Xl76Zu2d8BWSS1F QPzM6/srf7F2SNt5iY7qpE0RzYF6YlZgnf3a0pfzZqzdSKkj5RH9E50y+NtY0GQA0fPw vrd91BvOPtuczjABt6wgPU5pNF48a9D+ChjedKnUv4q+KfZY+NzaTPk8XZTRjvXpoqYQ 4AEw== X-Gm-Message-State: ANhLgQ32+2XuDK0v89G0iBSA5L9aIzrOy35rUyBhmJ8XByP71NoXLSg6 QcxppJ0NpmE0tGACqnVOkba/Ow== X-Google-Smtp-Source: ADFU+vtc3atgWoG361itKB4xApBMGrMUExpxNIdab4Ow4UUWS5fC6T+QADXDozQS4OkwoR392p5sKA== X-Received: by 2002:ac8:43c1:: with SMTP id w1mr4780630qtn.381.1583527484932; Fri, 06 Mar 2020 12:44:44 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g15sm14611541qtq.71.2020.03.06.12.44.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Mar 2020 12:44:44 -0800 (PST) Message-ID: <1583527481.7365.165.camel@lca.pw> Subject: Re: [PATCH V15] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy Date: Fri, 06 Mar 2020 15:44:41 -0500 In-Reply-To: <1583452659-11801-1-git-send-email-anshuman.khandual@arm.com> References: <1583452659-11801-1-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2020-03-06 at 05:27 +0530, Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table helpers or addition of new ones. >=20 > This test covers basic page table entry transformations including but n= ot > limited to old, young, dirty, clean, write, write protect etc at variou= s > level along with populating intermediate entries with next page table p= age > and validating them. >=20 > Test page table pages are allocated from system memory with required si= ze > and alignments. The mapped pfns at page table levels are derived from a > real pfn representing a valid kernel text symbol. This test gets called > inside kernel_init() right after async_synchronize_full(). >=20 > This test gets built and run when CONFIG_DEBUG_VM_PGTABLE is selected. = Any > architecture, which is willing to subscribe this test will need to sele= ct > ARCH_HAS_DEBUG_VM_PGTABLE. For now this is limited to arc, arm64, x86, = s390 > and ppc32 platforms where the test is known to build and run successful= ly. > Going forward, other architectures too can subscribe the test after fix= ing > any build or runtime problems with their page table helpers. Meanwhile = for > better platform coverage, the test can also be enabled with CONFIG_EXPE= RT > even without ARCH_HAS_DEBUG_VM_PGTABLE. >=20 > Folks interested in making sure that a given platform's page table help= ers > conform to expected generic MM semantics should enable the above config > which will just trigger this test during boot. Any non conformity here = will > be reported as an warning which would need to be fixed. This test will = help > catch any changes to the agreed upon semantics expected from generic MM= and > enable platforms to accommodate it thereafter. OK, I get this working on powerpc hash MMU as well, so this? diff --git a/Documentation/features/debug/debug-vm-pgtable/arch-support.t= xt b/Documentation/features/debug/debug-vm-pgtable/arch-support.txt index 64d0f9b15c49..c527d05c0459 100644 --- a/Documentation/features/debug/debug-vm-pgtable/arch-support.txt +++ b/Documentation/features/debug/debug-vm-pgtable/arch-support.txt @@ -22,8 +22,7 @@ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= nios2: | TODO | =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0openrisc: | TODO | =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0parisc= : | TODO | -=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0powerpc/32: |=C2=A0=C2=A0ok=C2=A0=C2= =A0| -=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0powerpc/64: | TODO | +=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0powerpc: |=C2=A0=C2= =A0ok=C2=A0=C2=A0| =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= riscv: | TODO | =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0s390: |=C2=A0=C2=A0ok=C2=A0=C2=A0| =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0sh: | TODO | diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 2e7eee523ba1..176930f40e07 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -116,7 +116,7 @@ config PPC =C2=A0 # =C2=A0 select ARCH_32BIT_OFF_T if PPC32 =C2=A0 select ARCH_HAS_DEBUG_VIRTUAL - select ARCH_HAS_DEBUG_VM_PGTABLE if PPC32 + select ARCH_HAS_DEBUG_VM_PGTABLE =C2=A0 select ARCH_HAS_DEVMEM_IS_ALLOWED =C2=A0 select ARCH_HAS_ELF_RANDOMIZE =C2=A0 select ARCH_HAS_FORTIFY_SOURCE diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 96a91bda3a85..98990a515268 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -256,7 +256,8 @@ static void __init pte_clear_tests(struct mm_struct *= mm, pte_t *ptep, =C2=A0 pte_t pte =3D READ_ONCE(*ptep); =C2=A0 =C2=A0 pte =3D __pte(pte_val(pte) | RANDOM_ORVALUE); - WRITE_ONCE(*ptep, pte); + set_pte_at(mm, vaddr, ptep, pte); + barrier(); =C2=A0 pte_clear(mm, vaddr, ptep); =C2=A0 pte =3D READ_ONCE(*ptep); =C2=A0 WARN_ON(!pte_none(pte));