From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55856C352A3 for ; Tue, 11 Feb 2020 11:39:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2FCD020842 for ; Tue, 11 Feb 2020 11:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FCD020842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B53306B02AF; Tue, 11 Feb 2020 06:39:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B04256B02B1; Tue, 11 Feb 2020 06:39:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19836B02B2; Tue, 11 Feb 2020 06:39:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 87CEC6B02AF for ; Tue, 11 Feb 2020 06:39:08 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3801982499B9 for ; Tue, 11 Feb 2020 11:39:08 +0000 (UTC) X-FDA: 76477649976.16.swim74_15721f8b3b732 X-HE-Tag: swim74_15721f8b3b732 X-Filterd-Recvd-Size: 1662 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 11:39:07 +0000 (UTC) Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104] helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j1TsX-0007P4-KK; Tue, 11 Feb 2020 14:38:57 +0300 Subject: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() From: Kirill Tkhai To: akpm@linux-foundation.org, guro@fb.com, vvs@virtuozzo.com, ktkhai@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 11 Feb 2020 14:38:57 +0300 Message-ID: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break(). Fixes: bf8d5d52ffe8 "memcg: introduce memory.min" Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b1863de475fb..f6efe2348ba3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) continue; } memcg_memory_event(memcg, MEMCG_LOW); - break; + /* fallthrough */ case MEMCG_PROT_NONE: + mem_cgroup_iter_break(target_memcg, memcg); /* * All protection thresholds breached. We may * still choose to vary the scan pressure