linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Edwards <chris.edwards@otago.ac.nz>
To: Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: Paging out when free memory is low but not exhausted (and available memory remains high)
Date: Tue, 28 Jan 2020 03:22:02 +0000	[thread overview]
Message-ID: <1580181722920.30551@otago.ac.nz> (raw)
In-Reply-To: <20200127100646.GA203985@cmpxchg.org>

Thank you both for the assistance and the patch. I'm afraid the problem remains with the patch applied, when exercising either the block buffer cache and the filesystem page cache. Is there anything I can do to try to pinpoint the problem? Tweaking some kernel vm.* parameters, perhaps? I wonder if others are able to reproduce the behaviour.

(Sorry for top-posting - lousy Outlook Web Access!)
--
Chris

________________________________________
From: Johannes Weiner <hannes@cmpxchg.org>
Sent: Monday, 27 January 2020 23:06
To: Michal Hocko
Cc: Chris Edwards; linux-mm@kvack.org
Subject: Re: Paging out when free memory is low but not exhausted (and available memory remains high)

Just to confirm, Chris, would you be able to test whether the
following patch fixes the problem you are seeing?

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 74e8edce83ca..1f1403681960 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2744,7 +2744,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
         * anonymous pages.
         */
        file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE);
-       if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE))
+       if (file >> sc->priority && !inactive_is_low(target_lruvec, LRU_INACTIVE_FILE))
                sc->cache_trim_mode = 1;
        else
                sc->cache_trim_mode = 0;


  reply	other threads:[~2020-01-28  3:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22  0:40 Chris Edwards
2020-01-23 12:31 ` Michal Hocko
2020-01-24  5:43   ` Chris Edwards
2020-01-24 10:04     ` Michal Hocko
2020-01-24 10:28       ` Michal Hocko
2020-01-27 10:06       ` Johannes Weiner
2020-01-28  3:22         ` Chris Edwards [this message]
2020-01-28  4:58           ` Chris Edwards
2020-01-28  7:19             ` Chris Edwards
2020-01-29 11:36               ` Chris Edwards
2020-01-29 13:39                 ` Michal Hocko
2020-01-29 16:39                   ` Johannes Weiner
2020-02-02 22:56                     ` Chris Edwards
2020-02-10  8:50                       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1580181722920.30551@otago.ac.nz \
    --to=chris.edwards@otago.ac.nz \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox