From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A79C55ABD for ; Fri, 13 Nov 2020 22:20:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4C44206F9 for ; Fri, 13 Nov 2020 22:20:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Mr40u2Na" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C44206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5EFEC6B007B; Fri, 13 Nov 2020 17:20:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 576286B007D; Fri, 13 Nov 2020 17:20:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EAD36B007E; Fri, 13 Nov 2020 17:20:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 1264B6B007B for ; Fri, 13 Nov 2020 17:20:31 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B09AB181AEF07 for ; Fri, 13 Nov 2020 22:20:30 +0000 (UTC) X-FDA: 77480815020.26.time43_6006bb327312 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 8D5D91804B668 for ; Fri, 13 Nov 2020 22:20:30 +0000 (UTC) X-HE-Tag: time43_6006bb327312 X-Filterd-Recvd-Size: 4676 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 22:20:29 +0000 (UTC) Received: by mail-qk1-f202.google.com with SMTP id o25so7630773qkj.1 for ; Fri, 13 Nov 2020 14:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=Jsr+yOOqZi2Nj6qjC5GqIPggpAtw8z6+rbSLs9IYMt8=; b=Mr40u2Na+744Lu2xB5XH5N7NJUu5zkCz5bvYutyv8bprHVKibdWrcZ08RTuHeheEFy 9jmFVE9u4pMUBRSsH8duKKAxLckAMS81HXO4Xd+IF5ViTs3z+IiCHYitEFwvlrygLVdl Fp1Iu8qVyEn4/oBWnVHCDlVMIVq/wT8DxVhflITdtyJe4/pBd2b+AM+ccSDdOjDiwdhT xJhX33OueoxZPgKqC96ik1I2rYb4dt4KvgmOopH5k0UnP/KslDnr1Hsw0cCUNHD6tkYZ pie5A+DraMOwWtJRPgmHqz7/llq9yX68G1qf4bknJXWyJ3BKIpXkFHmhJnfNhv7ht2kH CfAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Jsr+yOOqZi2Nj6qjC5GqIPggpAtw8z6+rbSLs9IYMt8=; b=mt1mFIRSPNyNjyU1qJDgKPiY2dG6+X7Gw4EjEci4Pc1gM1EPGBYWlMij9xecwdPvVF 5DIgJmR2TH1gXRKiIFRAYkDkkMzSqJxFEQBrim6YFDG5Cmx75ncbQIA+Kuy+qCRQP3Ke rjz7erhOKpAlau4Tku4b82SsRdPs2YzOaRnjLMDMyapwzWvWWuR2AXftbKCllyeTzYy0 s4Jj50n4sb6YCQhjIgy2A7Sz2uQF2yDa0NynESFSo6vjFBiNgi2wCaclu4pE3STB/vmn s/ctz3KS39STA9vcezTWmD32lpZejrod43+JgUAz2vbECv2taprpmJ/lbYamShWzJnGl 8Cvw== X-Gm-Message-State: AOAM532MWoH+GK2XmZT6uW7pr8EEcHLKXTTMbEgBxafEek15rHELPrF2 I8IrMRygdcMDD8YH68uo8N1w+2EMtN+tcIkn X-Google-Smtp-Source: ABdhPJwVIBicKScDqVn4tuFRRg0l3bRUAKZbS6vROY4eFdr5r/DaOJjnoyZljU2l4klUlopSKmUGVNXS2wDcCsNI X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:ad4:4633:: with SMTP id x19mr4837837qvv.11.1605306029294; Fri, 13 Nov 2020 14:20:29 -0800 (PST) Date: Fri, 13 Nov 2020 23:19:56 +0100 In-Reply-To: Message-Id: <157e9dfe43c5612ab028638c39ed5774b613449d.1605305978.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog Subject: [PATCH mm v3 06/19] kasan: remove __kasan_unpoison_stack From: Andrey Konovalov To: Andrew Morton Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There's no need for __kasan_unpoison_stack() helper, as it's only currently used in a single place. Removing it also removes unneeded arithmetic. No functional changes. Signed-off-by: Andrey Konovalov Reviewed-by: Dmitry Vyukov Reviewed-by: Marco Elver Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 --- mm/kasan/common.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 7648a2452a01..fabd843eff3d 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -65,18 +65,12 @@ void kasan_unpoison_range(const void *address, size_t size) } #if CONFIG_KASAN_STACK -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) -{ - void *base = task_stack_page(task); - size_t size = sp - base; - - unpoison_range(base, size); -} - /* Unpoison the entire stack for a task. */ void kasan_unpoison_task_stack(struct task_struct *task) { - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); + void *base = task_stack_page(task); + + unpoison_range(base, THREAD_SIZE); } /* Unpoison the stack for the current task beyond a watermark sp value. */ -- 2.29.2.299.gdc1121823c-goog